Commit Graph

15138 Commits

Author SHA1 Message Date
Markus Lampert
bfcd21361f Insert dressups at the same position in the operations list as the parent op is/was 2018-11-04 14:50:04 -03:00
Markus Lampert
de5b785f6e Moved Deburr out of experimental features. 2018-11-04 14:50:04 -03:00
pekkaroi
2f2f5af4c2 Path: PathSurface task panel update 2018-11-04 14:49:21 -03:00
pekkaroi
5118118740 generalized optimization algorithm 2018-11-04 14:49:21 -03:00
pekkaroi
c40060bc20 Path: Optimize output of OCL dropcutter algo. 2018-11-04 14:49:21 -03:00
Abdullah Tahiri
13f589a0a6 Sketcher: Allow driven constraints when autoredundancy removal and autorecomputes active
==========================================================================================

https://forum.freecadweb.org/viewtopic.php?f=3&t=31998#p266626
2018-11-04 14:46:37 -03:00
DeepSOIC
195c492993 Part: Attacher: fix blocking error message
fix #3662
for now, just allow accepting attachment even if attachment is faulty
2018-11-04 14:45:49 -03:00
Abdullah Tahiri
0a667889a0 Sketcher: Trim bug
==================

Trim tool fails to generate coincidence upon trimming an arc of ellipse at the end of the arc.

https://forum.freecadweb.org/viewtopic.php?f=3&t=31594&start=50#p266765
2018-11-04 14:43:24 -03:00
Abdullah Tahiri
d779e5b4b9 Sketcher: Fillet radius estimation improvement 2018-11-04 14:43:24 -03:00
Abdullah Tahiri
6f42f3dacc Part: Geometry tangent with Vector3d overload 2018-11-04 14:43:24 -03:00
Abdullah Tahiri
293e5732ad Sketcher: SketchObject Debug disabled by default 2018-11-04 14:43:24 -03:00
Abdullah Tahiri
abc7101118 Sketcher: Add DEBUG macro to SketchObject 2018-11-04 14:43:24 -03:00
Abdullah Tahiri
69d62787eb Sketcher: Intercurve fillet Improvement and delete constraint on point fix
==========================================================================

Intercurve fillet uses endpoint constraints for improved accuracy, but before this
commit was only considering a coincident constraint. Now it also considers an endpoint
tangency or perpendicular.

delConstraintOnPoint with coincidentonly=false, was not checking endpoint perpendiculars and
would therefore fail to delete them.

https://forum.freecadweb.org/viewtopic.php?f=3&t=31594&start=30#p265731
2018-11-04 14:43:24 -03:00
Abdullah Tahiri
fe78c1a037 Sketcher: Expose mass datum commands to python 2018-11-04 14:41:20 -03:00
Abdullah Tahiri
2c41e70c91 Sketcher: Mass operations on dimensionals
=========================================

This commit introduces two functions to operate on all datum constraints exclusively:

- Make all datum constraints driving or not driving, depending on the argument.
- Move all datum constraints at the end of the constraint list.

The practical use an ongoing effort towards improving the block constraint behaviour, that will be defered to 0.19
2018-11-04 14:41:20 -03:00
Abdullah Tahiri
6a1aed66e2 Sketcher: Refactor code relating to dimensional constraint checks 2018-11-04 14:41:20 -03:00
Abdullah Tahiri
8e2e5d7b6a Sketcher: Made constraints aware of whether they are dimensionals or not
========================================================================

Centralise the knowledge on whether a constraint is dimensional or not within the constraint
2018-11-04 14:41:20 -03:00
marvellouschandan
071bc89cf1 Indentation error solved 2018-11-04 14:38:45 -03:00
marvellouschandan
2765ed4792 Resolved issue: Exporting rectangular section to ifc 2018-11-04 14:38:45 -03:00
Yorik van Havre
90a1f4ad1c Draft: Fixed py3 bug in getSVG 2018-11-04 15:36:07 -02:00
wmayer
c3014fc65f fix blocking of SelectionObserver 2018-11-04 11:54:40 +01:00
luz.paz
4c2f2cd210 Misc. typos and whitespace
Found via `codespell -q 3 --skip="*.po,*.ts,./.git,./src/3rdParty,./src/CXX,./src/zipios++,./src/Mod/Assembly/App/opendcm,./ChangeLog.txt" -I ../fc-word-whitelist.txt` and `grep`. Excess whitespace auto-removed by Atom editor.
2018-11-03 16:13:06 -03:00
wmayer
5ff383b46c fix gcc8 build failure 2018-11-02 18:57:43 +01:00
Yorik van Havre
684b4ab03a Draft: Fixed wrong Placement of Draft Wire - fixes #3558 2018-11-01 14:42:52 -03:00
Przemo Firszt
e4b1cfc430 Fix COPR build and remove fedora specific xdg files
Signed-off-by: Przemo Firszt <przemo@firszt.eu>
2018-11-01 10:50:07 -03:00
wmayer
e86f7caea8 Improve TaskAttacher dialog:
+ correct handling of active document
+ properly handle case if the view provider or document is deleted while the dialog is still open
2018-10-31 14:29:42 +01:00
wmayer
347f99364d add/extend helper classes to safely access documents, document objects or view providers 2018-10-31 14:27:28 +01:00
wmayer
40cec5f72a add/extend helper classes to savely access document, document objects or view providers 2018-10-31 11:24:45 +01:00
wmayer
0c8da1c38a add an assert to several Command methods to be notified in debug mode if no active document exists 2018-10-31 11:21:33 +01:00
wmayer
f898eafd64 move from deprecated boost.signals to boost.signals2 library 2018-10-30 19:09:03 +01:00
wmayer
3858b179c3 improve whitespaces 2018-10-30 13:48:00 +01:00
Abdullah Tahiri
e10068a648 Sketcher: Trimming support bug
==============================

OCCT Geom2dAPI_InterCurveCurve based intersector does not detect intersection with the endpoint of a tangent line:
https://tracker.dev.opencascade.org/view.php?id=30217

This is a work-around that introduces endpoints of secondary curves as intersections, and uses projection to reject
projections further away than precision::confusion().

fixes #2463
2018-10-30 13:41:40 +01:00
wandererfan
408c31634f Fix BSpline/Circle conversion 2018-10-30 13:25:33 +01:00
wandererfan
f0420d6cbd Add formatter for gp_Pnt 2018-10-30 13:25:33 +01:00
wmayer
2f4b61dacb fixes -Winconsistent-missing-override 2018-10-30 13:21:59 +01:00
kreso-t
cd34f3d127 Path: Adaptive - set as standard feature
- i.e. removed from experimental features
2018-10-29 23:29:08 +01:00
kreso-t
976e804e2c Path: Adaptive - fix for path cleaning
- fix for side-effect introduced by last change
(completely collinear paths were filtered out)
2018-10-29 23:29:08 +01:00
Clemens Weissbacher
6e7beb1a0b py3: OpenSCAD: fix type cast 2018-10-29 17:18:13 +01:00
Clemens Weissbacher
1be9f18b52 py3: OpenSCAD: use io.open more explicit 2018-10-29 17:17:53 +01:00
wmayer
1538a14eca leave license field and url of a Part container empty to avoid possible confusion with imported 3rd-party STEP/IGES models 2018-10-29 15:24:12 +01:00
wandererfan
2b84be64cc Fix spurious error message
-  in FeatureGroove, the check for multiple
   solids in result was checking the wrong
   variable.
2018-10-29 10:29:23 -03:00
kreso-t
c2f2db8b56 Path: Adaptive - finishing path improvements
- fixed bug in path cleaning (artifacts on the finish path)
- increased path discretization resolution
2018-10-29 10:28:54 -03:00
wmayer
1e7aa1becf fix crash with Py3 when releasing memory buffer 2018-10-29 11:59:34 +01:00
wmayer
42c5b2e9ca fixes 0003657: automatic rotation disabled by default 2018-10-28 20:45:02 +01:00
wmayer
53ba33a805 fix -Wunused-private-field 2018-10-28 18:58:38 +01:00
Abdullah Tahiri
1d86a83b30 Sketcher: Fillet UI command Improved exception handling 2018-10-28 18:35:41 +01:00
Abdullah Tahiri
957c22a61a Sketcher: Fillet extended CAD kernel information 2018-10-28 18:35:27 +01:00
Abdullah Tahiri
044e0f6c20 Sketcher: Use transparent exception mechanism for fillets
=========================================================

This ensures that the exception back in the c++ that invoked python retains the type of exception and can be properly catched.
2018-10-28 18:34:50 +01:00
Abdullah Tahiri
7effa68eeb Part: Geometry use CADKernelError exception for OCCT
====================================================

Part of the geometry was using CADKernelError and part was using RunTimeError exceptions, so unify criteria.

Runtime is very generic and does not need to stem from OCCT.

- Also rename of a typo basic to basis, to be coherent with OCCT terminology
2018-10-28 18:34:36 +01:00
Abdullah Tahiri
4b9d90321a Sketcher: GUI command updated to support filleting of bounded curves 2018-10-28 18:34:23 +01:00