Commit Graph

23829 Commits

Author SHA1 Message Date
Abdullah Tahiri
bffb82d531 Sketcher: Solver - Improvement of popularity contest and bug fix
================================================================

Master has a problem in that internal alignment constraints are suggested to the user for removal.

This is fundamentally wrong, as an internal alignment constraint are an inherent part of the geometry. They cannot be the ones suggested for removal.

The popularity contest algorithm is an heuristic algorithm that determines which redundant/conflicting constraints should be proposed for removal.

Basically, the algorithm works on groups of redundant/conflicting constraints detected via the QR decomposition. A constraint may belong to more than one group.

The algorithm runs some heuristics, each constraint scoring a value, the one constraint from each group scoring the highest is proposed (is more popular and wins the contest).

This PR documents the algorithm, and adds a further condition, that internal alignment constraints are never proposed.

As the solver works with solver constraints as opposed to the sketcher, which works with sketcher constraints, information about whether a solver constraint originated from a
sketcher constraint that is internal alignment is necessary. So the solver constraint is extended to accomodate this piece of information.

As a bonus, it fixes a bug. Solver constraints carry information of the ID of the corresponding sketcher constraint in their tag. Knots are not currently implemented as constraints.
However, the tag index was not being update. This caused the popularity contest to provide wrong suggestions despite good detection.
2022-10-21 19:54:51 +02:00
Paddle
a46bed1a78 Sketcher: remove select DOF. 2022-10-21 09:47:07 -05:00
0penBrain
4c6ba8ed4d Sketcher: remove unneeded flag 2022-10-21 15:15:43 +02:00
wmayer
dc02c3f1dd Part: [skip ci] fix German translation 2022-10-21 13:31:36 +02:00
wmayer
ee0a0817f9 Sketcher: fix possible crash when closing the sketcher
For more details see the forum thread: https://forum.freecadweb.org/viewtopic.php?f=13&t=72774
2022-10-21 10:23:53 +02:00
Kuzemko Alexsandr
63174d487f [App] Fix of untranslated first document's name (#7156)
* Change no need function newDocument("Unnamed") call to variant without parameter. "Unnamed" set in App newDocument function instead.
* Refactor New Document command to run without parameter.
* Translate new document's userName. Internal name = "Unnamed".
* Crowdin Add to updatets.py App.ts. Create new file App.ts
* Fix error where document name is set with one function parameter. In this situation set internal and user name to string variable. For default function call (without parameter) set internal name to Unnamed, userName = translate ("Unnamed")
2022-10-20 21:35:09 -05:00
wandererfan
02fbf1334d [TD]fix check of wrong variable
- replace check of pages in selection with check of
  pages in document
- fix mixed {} conventions
- fix fail to exit on user cancel
2022-10-20 21:28:04 -04:00
0penBrain
0a12d435a2 [Bugfix]Spreadsheet: fix multi-screen management of QtColorPicker
+ set parent when instantiating
2022-10-20 16:08:01 -05:00
Zheng, Lei
5fcc1c3d03 Spreadsheet: fix cell span handling
When undo/redo, copy/paste, and removing row/column
2022-10-20 16:03:20 -05:00
Zheng, Lei
05e0aba701 Spreadsheet: fix cell span synchronization with SheetTableView
Also, allow merge cell with overlaps, by auto split overlapped cells
first
2022-10-20 16:03:20 -05:00
wandererfan
16c52bb18c [TD]expose DVP projectPoint to Python 2022-10-19 20:00:27 -04:00
luz paz
57090a43f7 [Sketcher] [Part] Fix typos and whitespace 2022-10-19 11:36:56 +02:00
0penBrain
525c05fae5 [Bugfix]Sketcher/BackEdit : Backedit lost if user changed camera mode
- in current implementation, backedit feature is lost if user changes camera mode (for example from orthographic to
   perspective, or oppositely). This happens because when changing camera mode, Coin actually do not just change a
   parameter of the camera node, but delete the current camera node and add a new one to the scenegraph. Thus the
   SoFieldSensor currently used (attached to camera orientation) is just detached and sensing is left -- notice is would
   be same with a SoNodeSensor attached to camera node --. The solution is to attach the sensor at scenegraph root node
   so it isn't lost when camera mode changed. No pre-check (such as checking if camera node changed since last call) has
   been added currently because it would not actually reduce callback execution time (and even worsen it).
2022-10-19 11:34:17 +02:00
wandererfan
ce4ba703d9 [TD]ActiveView from different document 2022-10-18 09:04:28 -04:00
sliptonic
9ae1432c3d Merge pull request #7605 from mlampert/bugfix/loading-path-wb-error
[PATH]: bugfix/loading-path-wb-error
2022-10-17 10:35:42 -05:00
sliptonic
38710ecf5f Merge pull request #7599 from sliptonic/codespell
fix codespell warnings
2022-10-17 10:35:00 -05:00
jim
f79055c1e5 fix whitespace and add comments 2022-10-17 11:15:09 -04:00
jim
d4e368a1d1 increase the height FreeType uses to draw glyphs in order to preserve precision of very fine features when converted to FC wires. scale the result back down appropriately. 2022-10-17 11:15:09 -04:00
Yorik van Havre
d8d55a0e88 Merged crowdin translations 2022-10-17 15:12:16 +02:00
Yorik van Havre
27d853c619 Merge pull request #7611 from Roy-043/Draft-Escape-should-not-switch-off-continue-mode
Draft: Escape should not switch off continueMode
2022-10-17 14:47:41 +02:00
Yorik van Havre
9ff670f273 Merge pull request #7608 from Roy-043/Draft-fix-path-array-float-math-issue
Draft: Fix path array float math issue
2022-10-17 14:44:04 +02:00
Yorik van Havre
dd7b589ff1 Updated ts files 2022-10-17 11:18:07 +02:00
Uwe
81143c17a1 [FEM] HypothesisPy: add inclusion comment
- add comments to avoid in future cases like this: https://github.com/FreeCAD/FreeCAD/issues/7585#issuecomment-1280170176
- also include explicitly SMESH_Version.h as safe guard in case HypothesisPy.h might in future be included in a different position
2022-10-17 04:12:07 +02:00
Uwe
85b0fcf66d [Sketch] TaskSketcherGeneral.ui: add missing stdset
- were strangely removed by out sort_ui.py script but are of course important
2022-10-17 02:51:25 +02:00
Uwe
1bfbba320b [Sketch] TaskSketcherGeneral.ui: fix compiler warning
- problem was the customwidget declaration
- the other changes were made by Qt's designer and our sort_ui.py script
2022-10-17 02:36:33 +02:00
Uwe
c3e4d3c258 Revert "[Sketch] TaskSketcherGeneral: restore wording of FC 0.20"
This reverts commit 354cffe559.
2022-10-17 02:31:08 +02:00
wandererfan
a22b0c89d3 [TD]update export icons 2022-10-16 07:55:35 -04:00
Ajinkya Dahale
3d7871fca5 [Sketcher] Allow driving constraint on construction geometry
Fixes issue #7442.

Also, the following commits are squashed into this one:

[Sketcher] Remove unnecessary variables

[Sketcher] Use `setDriving` within `toggleDriving`

Suggestion courtesy @0penbrain.

[Sketcher] Remove redundant check: `SketchObject::testDrivingChange`

`GeoEnum::GeoUndef = -2000` so checking if it's `< 0` is redundant.
2022-10-16 11:20:15 +02:00
Uwe
f50d1c39da [Part] remove now obsolete code for Visual Studio compiler
- see the discussion in https://github.com/FreeCAD/FreeCAD/pull/7241
2022-10-16 11:17:01 +02:00
flachyjoe
48b4eed55c [Start] Fix New document name translation
Fix FreeCAD-translations/issues/198
2022-10-16 02:55:01 +02:00
Markus Lampert
d784cffe3f Fixed typo in UI test case 2022-10-15 11:19:30 -07:00
Markus Lampert
dae3722d71 Fixed recursive import 2022-10-15 11:19:30 -07:00
Uwe
63cc042299 [FEM] HypothesisPy.cpp: fox compiler warning
- see https://forum.freecadweb.org/viewtopic.php?p=633192#p633192
2022-10-15 19:11:06 +02:00
Roy-043
ee872dbc76 Draft: Escape should not switch off continue mode 2022-10-15 12:14:51 +02:00
Uwe
354cffe559 [Sketch] TaskSketcherGeneral: restore wording of FC 0.20
- see https://forum.freecadweb.org/viewtopic.php?p=633198#p633198
- also fix problem with wrong custom widget definition (kindly automatically fixed by Qt's designer)
2022-10-15 04:50:50 +02:00
Roy-043
b74a1b0708 Draft: Fix path array float math issue 2022-10-14 21:08:29 +02:00
Uwe
459f6bd476 [FEM] commands.py: reformat a string
- just to be consistent with other strings (found by reviewing https://github.com/FreeCAD/FreeCAD-translations/issues/197)
2022-10-14 02:12:00 +02:00
sliptonic
cdc3e5466f Typo in Adaptive test 2022-10-13 14:09:51 -05:00
wmayer
9282fffa07 App: add tests for cell rows and absolute cells 2022-10-13 20:16:48 +02:00
sliptonic
126c8a48db fix codespell warnings 2022-10-12 10:00:33 -05:00
sliptonic
62a4503fa2 Merge pull request #7440 from mlampert/refactor/path-module-naming-cleanup
[PATH]: Refactor/path module naming cleanup
2022-10-12 09:14:39 -05:00
Yorik van Havre
eaff3963bb Merge pull request #7597 from Roy-043/Draft-Point-array-Take-placement-of-point-object-into-account-and-accept-more-point-object-types
Draft: Point array: Take placement of point object into account and accept more point object types
2022-10-12 15:03:46 +02:00
Yorik van Havre
bbae0ec5f1 Merge pull request #7590 from Roy-043/Draft-Fix-alignment-of-angular-dimension-arrows-in-svg.py
Draft: Fix alignment of angular dimension arrows in svg.py
2022-10-12 15:02:15 +02:00
Roy-043
a4a11a42d3 Draft: Point array: Take placement of point object into account and accept more point object types 2022-10-12 11:18:12 +02:00
Markus Lampert
c74a0ad3e5 Skip legacy tools in job templates and emit error msg 2022-10-11 21:43:09 -07:00
Markus Lampert
19473a9391 Added property details if value assignment fails 2022-10-11 21:43:09 -07:00
Markus Lampert
b4bfefbd56 Full recompute on test file 2022-10-11 21:43:09 -07:00
Markus Lampert
917c287e93 Fixed property bag editor to cancel if no name is given and OK is pressed 2022-10-11 21:43:09 -07:00
Markus Lampert
b25d1a2db0 Fixed refactor import issue 2022-10-11 21:43:09 -07:00
Markus Lampert
a9230c1f00 Convert usage of PathStop to Path.Op.Gui.Stop 2022-10-11 21:43:09 -07:00