Commit Graph

32526 Commits

Author SHA1 Message Date
wmayer
c0a0ddf1e0 Gui: by default restore the last visited page in the preferences dialog
See also: https://forum.freecad.org/viewtopic.php?t=77071
2023-03-25 18:23:09 +01:00
Chris Hennes
3d6c9a4cc1 Merge pull request #9047 from chennes/addonManagerFixRepeatedTests
Addon Manager: Fix tests breaking on second run
2023-03-25 11:02:45 -05:00
Chris Hennes
3b6cbc3f67 Merge pull request #8974 from chennes/toponamingMappedElement
App/Toponaming: Add MappedElement
2023-03-25 10:56:55 -05:00
0penBrain
0f8ab2b161 CI: fix bug with codespell returning code being 65 when errors are found 2023-03-25 16:40:00 +01:00
0penBrain
c224882548 CI: limit to strictly needed when bash command is allowed to fail 2023-03-25 16:40:00 +01:00
Chris Hennes
ce50ab5036 Addon Manager: Fix tests breaking on second run 2023-03-25 10:27:51 -05:00
Uwe
f0796014bc [FEM] Elmer: fix transient analyses
- different time results were never output, only the final one
  the reason is that the Output Intervals intervals property was missing
- a second reason was that the result scaling solver must be executed every time an output should be generated
- the BDF Order property is a transient-only property
2023-03-25 12:29:10 +01:00
Uwe
79842733ac [FEM] revert f3cebc81379 2023-03-25 11:38:03 +01:00
marioalexis
fc8cc7e728 Fem: Remove unnecessary type check for active analysis 2023-03-25 08:54:01 +01:00
Uwe
831f001026 [FEM] update transient analysis example file
- get outputs every 25 % and the last one is the final time
2023-03-25 05:48:14 +01:00
Uwe
954fa3f506 [FEM] Elmer: fix transient analyses
- different time results were never output, only the final one
  the reason is that the Output Intervals intervals property was missing
- a second reason was that the result scaling solver must be executed every time an output should be generated
- the BDF Order property is a transient-only property
2023-03-25 05:48:02 +01:00
xtemp09
73929ad90f [Sketcher] Fix segmentation fault in ViewProviderSketch::setEdit
Closes #8979
2023-03-25 00:02:32 +01:00
Kevin Martin
aaec21965a [Import] DXF: correction to documentation
Correction to documentation comment noticed while addressing these issues.
The comment for readDXF did not document its fourth option_source argument.
2023-03-24 23:03:52 +01:00
Uwe
96d1fb6e50 [FEM] only show toolbar button for available solvers
- if there is e.g. no Z88 solver available, there is no need to pollute the toolbar with an icon for it
2023-03-24 22:41:48 +01:00
wmayer
21ded4a4e0 Gui: fix failure of QMetaObject::connectSlotsByName
because in Qt6 QSpinBox::valueChanged(QString) and QComboBox::activated(QString) have been removed
2023-03-24 22:11:24 +01:00
Uwe
5b5431b650 [FEM] fine-tune default solver setting
- if the default solver has not yet been set and there is only one solver available, set this as default
2023-03-24 21:46:26 +01:00
wmayer
cd02704ff1 Gui: fix some lint warnings 2023-03-24 21:19:27 +01:00
Uwe
05d675364c [FEM] improve new default solver setting
- fix bug if no solver should be default
- only provide solvers that are available to be the default
- also add commit opened transactions
- also remove unused include and correct an include
2023-03-24 20:24:02 +01:00
wmayer
9a77379b37 Gui: move built-in Python code of DlgProjectUtility to script file 2023-03-24 19:50:49 +01:00
0penBrain
e2a2f6cec9 Gui: use QActionGroup signal for dimension indicator change handling 2023-03-24 19:31:41 +01:00
0penBrain
be80a217f6 Gui: add live retranslation to dimension indicator 2023-03-24 19:31:41 +01:00
0penBrain
38416d7b80 Gui: dimension indicator moved to custom widget to handle unit schema change in other places 2023-03-24 19:31:41 +01:00
0penBrain
8eee92da99 Gui: change dimension indicator from QToolButton to QPushButton for lighter style
Consistency with navigation style indicator

 Also fix typo in function name and remove comment
2023-03-24 19:31:41 +01:00
Uwe
a0c885829b [FEM] improve recently added addition method
- for the solvers the workflow should be that one can directly after adding a solver child to it via the toolbar
  Therefore select the added solver object
2023-03-24 17:32:53 +01:00
sliptonic
e36561e327 Merge pull request #8941 from chuckwagoncomputing/expression-colors
Path: Don't override style colors
2023-03-24 09:58:46 -06:00
Ajinkya Dahale
453acce2f7 [Sketcher] Fix some coincidence issues in B-spline drawing
See https://github.com/FreeCAD/FreeCAD/pull/8530#issuecomment-1474824366.

When there are already existing points and coincidence auto-constraints are
added in the process of making a B-spline (either by control points or
interpolation), unintended behaviour can happen.

Additionally, when creating B-spline by interpolation, if consecutive points are
coincident (or very close to each other), the OCCT algorithm fails. This is also
prevented in this commit.
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
1ac4800869 [Sketcher] Fix corner-case issue creating periodic b-splines
See: https://github.com/FreeCAD/FreeCAD/pull/8530#issuecomment-1474824366.
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
7446c19c08 [Sketcher] Run clang-format on DrawSketchHandlerBSplineByInterpolation.h 2023-03-24 16:30:48 +01:00
Ajinkya Dahale
c66ed794f9 [Sketcher] Clear out some TODOs and other comments 2023-03-24 16:30:48 +01:00
Ajinkya Dahale
8803404d88 [Sketcher] Fix and support periodic B-spline by interpolation
This commit is part of a project funded by the Open Toolchain Foundation under
the title "Open Toolchain Foundation - Curve drawing tool in Sketcher
Workbench".
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
68d67ecb87 [Sketcher][planegcs] Fix knot position in non-uniform B-spline
The default factors set in `addConstraintInternalAlignmentKnotPoint` does not
work if the knots around a C1 knot are not equally far.
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
5fee6608ea [Sketcher] Disable degree setting in B-spline by interpolation
This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
f340b4104b [Sketcher] Add missing GUI elements for B-spline by knots
Commented out the periodic version for now since they don't work completely well.

This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
357a3c0692 [Sketcher] Add icon for B-Spline by interpolation tool
This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"

[Sketcher] Add better icons for `CreateBSplineByInterpolation`

Courtesy @paddlestroke.
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
4b61edf470 [Sketcher] Support variable multiplicities in B-splines
As a side-effect also prevents a segfault possible by providing just 3 points.

[Sketcher] Clarify that mults might not be followed

Some examples when this may be ignored include:
1. A number higher than 3 is given (because cubic B-splines are created)
2. If the knots just before and just after have multiplicities >=3, the piece
between these two is fully continuous, and this (middles) point will only be
constrained with point-on-object.

This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
d14daed442 [Sketcher] Constrain first pole weight in exposeInternalGeometry
This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
94db5271b3 [Sketcher] [WIP] Add periodic B-spline support for interpolation DSH
This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
69a56bc3fa [Sketcher] Fix typos caused by copying content in new DSH
Some parts of `DrawSketchHandlerBSplineByInterpolation` were taken from
`DrawSketchHandlerBSpline` but not modified to reflect the differences.

This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
d2349f29db [Sketcher] Clarify keyboard input for B-spline DSH
Specifically, when drawing by interpolation, only cubic splines are currently
supported.

Some related "TODO" comments are also removed or modified.

This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Ajinkya Dahale
e83a9804c1 [Sketcher] Create DSH for drawing B-splines by interpolation
Only creates 1-degree splines by describing knots.

This commit is part of a project funded by the Open Toolchain Foundation under the title "Open Toolchain Foundation - Curve drawing tool in Sketcher Workbench"
2023-03-24 16:30:48 +01:00
Chris Hennes
d871779299 App/Toponaming: Add tests to MappedElement 2023-03-24 10:05:09 -05:00
marioalexis
c97de6c038 Fem: Add option to select default solver when creating Analysis 2023-03-24 15:40:54 +01:00
Uwe
7e3d37a5fe [FEM] implement further object addition mode
- for e.g. the solver objects it is important that the added equations are visible in the TreeView
- also improve activation of analyses for documents with multiple analyses: one activates one and can then subsequently add an object to it because the activation will also select
2023-03-24 07:22:27 +01:00
Uwe
26bb8b1666 [TD] GeometryMatcher.cpp: fix compiler warning
about unused variable
2023-03-24 06:16:31 +01:00
Uwe
1bd5739708 [FEM] auto-activate Analyses
- this PR addresses a long-standing annoying issue: You are already in the FEM WB and load a file.
  Then you cannot just start but first have to activate the Analysis. But one is in the FEM WB to work with analyses.
2023-03-24 06:05:54 +01:00
Uwe
b357298e9e [Gui] Application.cpp: fix too long lines
- for better readability (less scrolling in the IDE)
2023-03-24 04:38:45 +01:00
Chris Hennes
59fa7c9205 Addon Manager: Fix wiki macro icon cleanup 2023-03-23 21:49:05 -05:00
Uwe
5a0f8436c2 [FEM] don't add CCX solver by default for new analyses
- if there are other solvers found, we should handle all solvers equally
- also reduce amount of console output on every analysis run
2023-03-24 03:25:02 +01:00
Uwe
ce62cfae95 [FEM] implement new object addition mode
- for e.g. the Elmer equations it is important that one can add several equations subsequently and that the added equations are visible in the TreeView
2023-03-24 02:43:01 +01:00
Uwe
a377a5e490 [FEM] remove unused code
- remove commented-out code that is in Python since years
2023-03-24 02:42:19 +01:00