Commit Graph

1731 Commits

Author SHA1 Message Date
Markus Lampert
6f52808e91 fixed pylint warning for PathOp 2019-07-01 15:29:51 -07:00
Markus Lampert
83581d7047 fixed pylint warning for PathJob 2019-07-01 15:29:51 -07:00
sliptonic
ecc3994337 path: LGTM cleanup post processors 2019-07-01 17:18:15 -05:00
sliptonic
02b68f36fb Path: lgtm cleanup PathAreaOp 2019-07-01 17:18:15 -05:00
Russell Johnson
1ac8f4cfe9 4th-axis update (#2311)
Improve property creation
Improve property setup
Implement PathLog.debug() for troubleshooting.
Improve default property values.
Remove unused and incomplete method
Remove unnecessary comments; fix final depth issue
4th-axis improvements
rotation method improvements
remove extra comment blocks
fix incorrect variable references
fix -0.0 re-introduction after initial filter
negative zero re-introduced causes problems with naming method for temp clones
Update faceRotationAnalaysis() method
update opFeatures()
Commented out call to PathOp.FeatureRotation
This feature not yet implemented.
delete call to removed method - self.reportThis()
Remove unnecessary comments
2019-07-01 09:30:58 -05:00
sliptonic
bf9f6021ab Merge pull request #2303 from Russ4262/path_3d_pocket_upgrade
[Path] 3D Pocket: Upgrade to collective face processing!
2019-06-30 18:54:30 -05:00
Russell Johnson
4fc39dfb36 PathDrilling 4th-axis integration
Initial integration of 4th-axis functionality to the Drilling op in PathWB
2019-06-30 14:14:38 -05:00
Russell Johnson
e67fc4e706 3D Pocket: Upgrade to collective face processing!
New property added: `HandleMultipleFeatures`.
New property and related code allows for improved, and expected, 3D Pocket operations.
Improvement combines faces selected to create one envelope to be processed as the path shape ('collectively' setting).
Old behavior is available with 'Individually' setting.
Enjoy!
2019-06-30 14:06:37 -05:00
sliptonic
a62607505f Merge branch 'master' into bugfix/pocket-shape-extensions 2019-06-30 09:32:07 -05:00
Russell Johnson
3132dfbf54 ProfileFaces: Fix obj.processPerimeter feature (#2306)
https://forum.freecadweb.org/viewtopic.php?f=15&t=37368
if obj.processPerimeter: `else` block re-configured to read new property, `HandleMultipleFeatures`
Removed some excess comments
2019-06-30 09:31:30 -05:00
Markus Lampert
68939608ea Properly deal with deleted objects when cleaning up the extension visualisation. 2019-06-29 19:16:33 -07:00
Markus Lampert
aa15a6cf4a Cover entire hole if pockeet extension is bigger than hole. 2019-06-29 18:16:56 -07:00
Markus Lampert
4fb0b04a39 Fixed extensions for round holes. 2019-06-29 18:16:56 -07:00
Markus Lampert
05249b2123 Removed redundant log message 2019-06-29 18:16:56 -07:00
Markus Lampert
9c5fa124c3 Fixed extension selection 2019-06-29 18:16:56 -07:00
Markus Lampert
70d8be5b3c Fixed document restoration logic. 2019-06-29 18:16:56 -07:00
luz.paz
e0377f8e4f Misc. typo and whitespace fixes
Found via `codespell`
2019-06-28 11:39:36 -03:00
sliptonic
b55c210f39 remove unnecessary imports. normalize debug log levels 2019-06-21 13:01:01 -05:00
sliptonic
4a984de243 Path: normalize proxy stratements
remove bare exceptions
2019-06-21 13:01:01 -05:00
Russell Johnson
332bfb5052 Fixes bug #4008: removes phantom path cause
Job object was base of transformations, rather than Job base(clone).
2019-06-20 00:02:14 -05:00
Russell Johnson
97f42a6193 Fix functionality of manual override of Final Depth
manual Final Depth settings were limited to values greater than the base face for the Op. Manual settings of Final Depth may now proceed below the face (Outside profile ops)
2019-06-20 00:02:14 -05:00
Russell Johnson
2e0861babc proxy to obj.Proxy partial conversion 2019-06-20 00:02:13 -05:00
sliptonic
fbb138653a Path: fix proxy error 2019-06-19 10:21:17 -05:00
sliptonic
d4a311de19 Path: PEP8 and Proxy changes. 2019-06-17 09:17:38 -05:00
Russell Johnson
4296df8c3e Merge branch 'master' into pathpocketshape_fix 2019-06-16 16:38:09 -05:00
luz.paz
9453e68e23 Misc. source comment typo and whitespace fixes
Found via codespell
2019-06-16 20:47:07 +02:00
Russell Johnson
77d1f8968d Delete disabled code blocks
within guiMessage() method
2019-06-15 12:19:17 -05:00
Russell Johnson
4cff627468 added missing self.stockBB instantiation
job boundbox object was missing in opSetDefaultValues()
2019-06-15 12:05:58 -05:00
Russell Johnson
236e1daeb5 Isolate FreeCADGui dependency
Thanks @mlampert and @sliptonic for assisting in tracking down the error via unit test analysis.
FreeCADGui usage has to be behind an 'if FreeCAD.GuiUp:` test
2019-06-13 15:42:56 -05:00
Russell Johnson
c1970aa5e3 Remove unnecessary comment 2019-06-13 12:34:33 -05:00
Russell Johnson
4df89e0e3d Misc. fixes
Clean up code, improve comments, improve user feedback.
Improve temp clone management.
Correct depth issue with self.finDep
Add comment descriptions for new methods
Clean up comments and contribution information
Initiate recognition of type()==SurfaceOfExtrusion
Adopt standard PathGeom.isRoughly() and .Tolerance rather than idependent precision settings
2019-06-13 10:55:32 -05:00
Russell Johnson
a160aab486 Fixes for depths and AttemptInverseAngle
Depth correction to obj.FinalDepth.Value in single feature operations
Fix AttemptInverseAngle to be uni-directional
Clean up debug and other user provided feedback
2019-06-13 10:55:31 -05:00
Russell Johnson
bbfecfb7cf Handle FreeCADGui module with IF: case 2019-06-13 10:55:31 -05:00
Russell Johnson
4c69b48dc6 Improve code structure; correct 4th-axis depth issues 2019-06-13 10:55:30 -05:00
Russell Johnson
338861f2d2 Integration of 4th-axis feature to PathProfileFaces
4th-axis integration should not affect current feature set
2019-06-13 10:55:29 -05:00
Russell Johnson
4ec63d537d Fix for 'reposition of job model' error
Re-structured 4th-axis implementation, completely; new structure will be easier to implement in other PathWB tools.
Changed basis for rotational pockets from job model to temporary per-rotation clones.
2019-06-13 10:55:28 -05:00
Russell Johnson
72dc30c218 Improve 4th-axis integration
Improvements to 4th-axis readiness for other PathAreaOp based tools in PathWB.
Add guiMessage() method for rendering GUI messages to user.
2019-06-13 10:55:27 -05:00
Gauthier Brière
4960cfcd22 [Path] Replace old grbl_post.py with new grbl_G81_post.py. (#2255)
* Replace the old grbl_post.py by grbl_G81_post.py

* Cleaned grbl_G81_post.py replacing old grbl_post.py
2019-06-13 09:14:17 -05:00
sliptonic
eb9d778733 Merge pull request #2251 from realthunder/PathFix
Path: handle PathAreaOp object migration
2019-06-10 16:44:11 -05:00
sliptonic
6717499d34 Merge pull request #2245 from sliptonic/lgtm
Path: lgtm Cleanup
2019-06-10 16:43:38 -05:00
Markus Lampert
0e8487fdac More TC ui import cleanup 2019-06-10 23:21:52 +02:00
brad
b564189f75 Path: remove unnecessary imports 2019-06-10 10:50:06 -05:00
brad
6ccb0cf32c Path: post processor cleanup 2019-06-10 10:50:06 -05:00
brad
795442a85a Path: remove obsolete code 2019-06-10 10:50:06 -05:00
brad
4cbdf78836 Path: lgtm Cleanup 2019-06-10 10:50:06 -05:00
Zheng, Lei
93cbc5250e Path: handle PathAreaOp object migration 2019-06-10 09:29:01 +08:00
brad
f5495502a5 PATH: Inspect editor now preserves last size and position 2019-06-08 08:53:24 -05:00
Markus Lampert
285efa3379 Dressup gui import cleanup 2019-06-02 11:30:18 -07:00
Markus Lampert
71a3690892 More FreeCADGui removal from Path model classes. 2019-06-02 11:03:14 -07:00
Markus Lampert
e472693c8c Removed obsolete gui import 2019-06-02 11:03:14 -07:00