Commit Graph

22572 Commits

Author SHA1 Message Date
Wanderer Fan
02155296ce [TD]fix spelling mistake in comment for CI 2022-03-14 20:03:08 -04:00
Wanderer Fan
8f1bd5340b [TD]fix DetailView alignment 2022-03-14 20:03:08 -04:00
Wanderer Fan
7c6a7aa25b [TD]fix detail highlight on DrawViewDetail 2022-03-14 20:03:08 -04:00
Uwe
ac52b39328 [FEM] fix Results dialog size
- reduce to a sensible size and get rid of unneeded spacer
- further changes automatically done by Qt's Designer
2022-03-14 22:14:06 +01:00
Uwe
075276e215 [FEM] fix Centrif dialog size
- reduce to a sensible size and get git on unneeded spacer
2022-03-14 20:51:27 +01:00
Abdullah Tahiri
89bf7f3d0b Sketcher: DrawSketchHandler draw multiple edit curves
=====================================================

Extension of the framework to draw an arbitrary curve in draw sketch handlers, so that
a plurality of curves can be handled.

DrawSketchHandler is extended to additionally offer drawing several curves:
- void drawEdit(const std::list<std::vector<Base::Vector2d>> &list);
- void drawEdit(const std::vector<Part::Geometry *> &geometries);

A new class, CurveConverter, enables to convert individual Part::Geometry or vectors of them
to appropriate vectors or list of vectors of Vector2d representing the curves. This can be
used in a specific DrawSketchHandler to combine Part::Geometries and arbritary curves.
2022-03-14 16:02:49 +01:00
sliptonic
75fee12d7b Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value
Path: Fix inconsistent float type usage, issue #6170 [Bug]
2022-03-14 09:26:24 -05:00
Yorik van Havre
6efe74a554 Merged crowdin translations 2022-03-14 12:21:01 +01:00
Yorik van Havre
583206d47c Updated master ts files 2022-03-14 12:13:40 +01:00
wmayer
0054cbddaa Fix coverity issue:
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
2022-03-14 11:35:04 +01:00
Chris Hennes
56eab3f08b Addon Manager: Correct parent of modal dialogs 2022-03-13 22:30:14 -05:00
Uwe
4d08cefe0e [Part] Section Cut: respect App::Part placement
if object to be cut are within an App::Part container the container placement needs to be respected

- also fix a performance issue
2022-03-14 03:32:09 +01:00
Chris Hennes
2fc9c93235 App: Improve Metadata error handling
Report XML parse exception details.
2022-03-13 21:01:47 -05:00
Chris Hennes
2ac4e60ab5 App: Fix Metadata Py constructors
Also adds unit tests for the corrected Copy and Default constructors.
2022-03-13 21:01:47 -05:00
Uwe
7a2952abf7 [TD] fix compilation error 2022-03-14 01:13:56 +01:00
Wanderer Fan
244caf39cd [TD]fix unit display to standards 2022-03-13 19:04:42 -04:00
Abdullah Tahiri
2908150282 Sketcher: Some code comments 2022-03-13 19:28:38 +01:00
wmayer
55f8d68b4e PD: Fix coverity issue:
* CID 350645: Uncaught exception
2022-03-13 17:24:07 +01:00
wmayer
0be04bb5e0 Points: Fix several coverity issues:
* CID 350545: Resource leak
* CID 350553: Resource leak
* CID 350559: Resource leak
* CID 350593: Resource leak
* CID 350604: Resource leak
* CID 350625: Resource leak
* CID 350650: Resource leak
* CID 129019: Division or modulo by float zero (false-positive)
* CID 129020: Division or modulo by float zero (false-positive)
* CID 129021: Division or modulo by float zero (false-positive)
2022-03-13 16:48:19 +01:00
wmayer
9ef2470799 PD: Fix several coverity issues:
* CID 350558: Uninitialized pointer field
* CID 350554: Uninitialized pointer field
* CID 350589: Uninitialized pointer field
* CID 350608: Uninitialized pointer field
* CID 350544: Uncaught exception
* CID 350568: Uncaught exception
* CID 350603: Uncaught exception
* CID 350562: Unchecked dynamic_cast
* CID 350591: Unchecked dynamic_cast
* CID 350583: Unchecked dynamic_cast
* CID 350598: Unchecked dynamic_cast
2022-03-13 16:32:19 +01:00
wmayer
edd346cc3d Part: Fix several coverity issues:
* CID 350581: Structurally dead code
* CID 350620: Structurally dead code
* CID 350563: Big parameter passed by value
* CID 350552: Uncaught exception
* CID 305193: Uncaught exception
* CID 350556: Uninitialized scalar field
* CID 350579: Uninitialized pointer read
2022-03-13 16:06:40 +01:00
wmayer
716a27de25 MeshPart: Fix several coverity issues:
* CID 350570: Uninitialized scalar variable
* CID 350628: Uncaught exception
2022-03-13 15:50:39 +01:00
wmayer
68171bd20c TD: Fix several coverity issues:
* CID 316569: Uninitialized scalar variable
* CID 350651: Unchecked dynamic_cast
* CID 350565: Unchecked dynamic_cast
* CID 350595: Unchecked dynamic_cast
* CID 350638: Unchecked dynamic_cast
* CID 350547: Division or modulo by float zero
2022-03-13 15:40:49 +01:00
wmayer
f6f21f4fa6 Mesh: Fix several coverity issues:
* CID 350557: Out-of-bounds read (false-positive)
* CID 316517: Uninitialized scalar variable
* CID 316519: Uninitialized scalar variable
* CID 316547: Uninitialized scalar variable
* CID 316556: Uninitialized scalar variable
* CID 350614: Uncaught exception
* CID 350606: Uncaught exception
* CID 332681: Using invalid iterator
2022-03-13 14:58:14 +01:00
wmayer
76d1180283 Fem: Fix several coverity issues:
* make SelectionChangeModes an enum class
* CID 350596: Uninitialized scalar field
* CID 350572: Uncaught exception
* CID 350647: Uncaught exception
2022-03-13 14:09:04 +01:00
Anders Torger
08552c6e68 Apply multi-thread configuration for Calculix also when started via task panel 2022-03-13 13:32:30 +01:00
wmayer
68b92c504f Fix several coverity issues:
* CID 350617: Dereference after null check
* CID 350585: Out-of-bounds read
* CID 350624: Resource leak
* CID 332701: Uncaught exception
* CID 350642: Uninitialized scalar field
* CID 350590: Uninitialized scalar field
* CID 350629: Uninitialized scalar variable
* CID 350602: Uninitialized scalar variable
* CID 350564: Uninitialized scalar variable
* CID 350548: Uninitialized scalar variable
2022-03-13 12:12:49 +01:00
wmayer
02bd57ac82 PD: Fix several coverity issues:
* CID 350622: Negative array index read
* CID 350613: Negative array index read
* CID 166163: Negative array index read
* refactor Hole::updateDiameterParam()
2022-03-13 12:10:01 +01:00
Abdullah Tahiri
8c35a895eb Sketcher: Redraw constraints on wheel event
===========================================

https://forum.freecadweb.org/viewtopic.php?p=577585#p577585
2022-03-13 11:33:52 +01:00
wmayer
33577a087f Robot: [skip ci] add header with export macros 2022-03-13 08:37:58 +01:00
Ajinkya Dahale
76029a5b2d [Sketcher] Fix "toggle internal geo" on multi-selection
Some deleted GeoIds can stay in selection and GeoIds can change as some objects
are deleted.
2022-03-13 06:58:40 +01:00
Russell Johnson
ac4c7bb954 Path: Fix self.removalshapes declaration [Bug]
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty.  This moves the declaration up in scope to the method level.
2022-03-12 22:34:03 -06:00
Russell Johnson
20e3657125 Path: Fix automatic commitTransaction() calls, issue #6149 [Bug]
This commit removes the automatic committal of transactions when activated with GUI command.  The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
2022-03-12 22:05:04 -06:00
Russell Johnson
1fc468912c Path: Improve value assignment syntax for radius 2022-03-12 20:00:40 -06:00
sliptonic
b0d19d28d7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
2022-03-12 19:05:39 -06:00
Uwe
131a8d038a [Assembly] fox typos in element names
all found by the spellchecker CI
2022-03-13 01:32:27 +01:00
Russell Johnson
a2fb5b66fa Path: Fix radius type inconsistency, issue #6170 [Bug]
Make `self.radius` a float type throughout since other methods and functions treat it as such.
2022-03-12 18:29:21 -06:00
sliptonic
a10fd46b09 Merge pull request #5440 from voneiden/path-array-improvements
Path: Path Array dressup compatibility
2022-03-12 18:21:40 -06:00
mwganson
3e18c76d4f PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Anders Torger
65718f0e51 Add General.NumThreads = CPU core count setting to Gmsh
settings file to enable multi-threaded meshing (much faster
for larger models)
2022-03-12 23:26:55 +01:00
Matti Eiden
af8b6fba07 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Abdullah Tahiri
a5d0de0994 Sketcher: Coverity 332695 - unlikely array indexing with negative value 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
4185b8b849 Sketcher: Coverity 332679 - logically dead code removed 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
d60da72b6e Sketcher: Coverity 332685, 332686, 332696
=========================================

Detected by coverity as unchanged variable (constant intended).

It was actually an unnecessary variable that prevented correct command committing.
2022-03-12 21:14:19 +01:00
Abdullah Tahiri
fb87709193 Sketcher: Coverity 350601 - possible resource leak 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
c7367dc167 Sketcher: Coverity 350637 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
8a20f1a071 Sketcher: Coverity 350641 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Russell Johnson
dd76cabb34 Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug]
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
2022-03-12 12:18:09 -06:00
Abdullah Tahiri
e48d3e355d Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Uwe
a9b510f640 [Assembly] fix typos found by the spellchecker CI 2022-03-12 17:52:33 +01:00