Commit Graph

41753 Commits

Author SHA1 Message Date
tetektoza
c8395f43fc BIM: Avoid traceback if there is no Classification selected
As the title says, if user selects `OK` button and has no Classification
selected (which can happen only if the list is empty I think), then they
get a traceback since we're trying to access list of selections
directly.

So this patch adds a small patch to close the form if user has pressed
`OK` button and did not select anything.
2025-05-19 17:41:24 +02:00
sliptonic
7d5d1c7295 Merge pull request #21129 from jffmichi/fix_active_and_coolant
CAM: fix handling of Active state and CoolantMode with nested dressups
2025-05-19 10:33:45 -05:00
PaddleStroke
782e90b4cc TechDraw: Fix claiming of hatch 2025-05-19 17:33:19 +02:00
sliptonic
7658e255cc Merge pull request #21408 from jffmichi/fix_array_dressup_two
CAM: fix loading Array dressup with unused properties
2025-05-19 09:48:02 -05:00
sliptonic
10c2e8819e Merge pull request #21108 from tarman3/pathshape2
CAM: PathShape with Tool Controller
2025-05-19 09:12:58 -05:00
Ladislav Michl
baad73f0e3 Base: fix conversion to kilometers in Standart unit schema
Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-19 12:15:51 +02:00
Ladislav Michl
d69a143a17 Base: align unit format to Quantity parser expectations
Quantity parser is unable to deal with exponents written in
supersript, so change it back to ^n.

The micro prefix is expected to be U+00B5, not U+03BC, so change
it back as well. Note, that \x escape sequence reads till the
whitespace or the end of string, thus microFarad becomes
  "\xC2\xB5""F

Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-19 12:15:51 +02:00
Ladislav Michl
3e09bf975c Base: fix QuantityPy::getValueAs
Fixes: 77f4515963 ("Base: refactor QuantityPy class")
2025-05-19 12:15:51 +02:00
bofdahof
d4a031583f Base: restore output format of imperial fraction units
Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-19 12:15:51 +02:00
PaddleStroke
e423b1bf23 TechDraw: Lock multiple views 2025-05-19 09:37:37 +02:00
PaddleStroke
39b6a1e3a8 TechDraw: decorateLine fix (#21312)
* TechDraw: decorateLine fix

* Update CommandAnnotate.cpp
2025-05-19 09:36:47 +02:00
Chris Hennes
4cc069eb0a TD: Remove unused variable 2025-05-19 09:36:13 +02:00
Céleste Wouters
68b9129c11 Sketcher: remove "SecondIcon" logs on constraint icon hover
Hovering the cursor over constraint icons sometimes logs "SecondIcon"
messages to the report view, doing so for every cursor move event.
This message isn't useful outside of a development context and in fact
is a leftover from 7ab2b3b690ef6447cfd16842af3008817f8e77f7.

Removes this message.

Fixes #21417
2025-05-18 16:30:22 +02:00
jffmichi
8331a41902 App: Fix exported object dynamic property type identifier (#21415)
Fixes: 9d6f1ad37c ("App: Align Document to best practices")

Co-authored-by: jffmichi <>
2025-05-18 01:38:04 +02:00
Roy-043
0e9c1451c7 Draft: use different color for WPProxy to avoid BIM dependency
Fixes #21390.
2025-05-17 14:30:48 +02:00
jffmichi
86a682883e CAM: fix loading Array dressup with unused properties 2025-05-17 12:42:28 +02:00
dependabot[bot]
4713e4b854 Bump github/codeql-action from 3.28.16 to 3.28.18
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.16 to 3.28.18.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v3.28.16...ff0a06e83cb2de871e5a09832bc6a81e7276941f)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.28.18
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-16 12:15:43 -05:00
Roy-043
7decc3ea55 Draft: avoid redundant constraints in make_sketch.py (#21398)
Forum topic:
https://forum.freecad.org/viewtopic.php?t=97072

The MissingVerticalHorizontal functions from the Sketcher WB do not behave as expected. See #21396.

A check for redundant contraints is required if   `makeMissingVerticalHorizontal()` is used. The argument for the function should be `True`. For consistency the same was done for makeMissingPointOnPointCoincident().
2025-05-16 19:12:32 +02:00
saso badovinac
1c88150ab5 Update codeql.yml 2025-05-16 09:52:44 -05:00
saso badovinac
6c76cc5c89 Update codeql.yml 2025-05-16 09:52:44 -05:00
saso badovinac
ea6ae4769a Update codeql.yml 2025-05-16 09:52:44 -05:00
saso badovinac
b951c8f205 Update codeql.yml
Change the cpp dependencies install to ./package/ubuntu/install-apt-packages.sh (cpp scan is still disabled) and activate the extended security queries
2025-05-16 09:52:44 -05:00
Roy-043
ba961f8d42 Draft: params.py: do not report missing UI files (#21370)
See #21331.
2025-05-16 15:27:33 +02:00
Alfredo Monclus
2e54df073d Gui: fix ElideCheckbox spacing 2025-05-16 09:32:11 +02:00
Alfredo Monclus
46ab345a9f PD: move the base profiles types to the top 2025-05-15 23:31:55 +02:00
Kohei Takahashi
0a78771733 Base: Fixed segfault on destructing cached string (#20563)
* Base: Fixed segfault on destructing cached string

Xerces default memory manager is deleted before destructing static local
variable and segfault.

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2025-05-15 17:23:03 +00:00
Pieter Hijma
005a8f15de Fix a cyclic build dependency
Before this commit, Draft depended on BIM and BIM depended on Draft.
With this commit, BIM depends on Draft.
2025-05-15 18:50:17 +02:00
Chris Hennes
283d68aa2d Sketcher tests: Silence compiler warning with cast 2025-05-15 18:49:08 +02:00
Luz Paz
ee4fa234c9 Fix various typos
Missed by the codespell CI not being functional for a period of time.
2025-05-15 10:59:48 -05:00
pre-commit-ci[bot]
1a27e92bb0 [pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/pre-commit/mirrors-clang-format: 7ec07eeb4135dc6ecf410d24ac4ead986a5d413d → 300fa4c170bf0887bb5585d17ec50901ad2625fb](7ec07eeb41...300fa4c170)
2025-05-15 08:55:15 -05:00
saso badovinac
4cb6a42aec CI: Create codeql.yml (#21300)
Adding CodeQL, starting with a minimal configuration, default queries and python only
2025-05-15 08:14:54 -05:00
Benjamin Bræstrup Sayoc
88dc2048cd TechDraw: fix face color not working
Fixes #20467
2025-05-15 12:16:24 +02:00
Joao Matos
ddde5a9566 Fix warnings in ModelManagercode. 2025-05-15 01:02:55 +02:00
Chris Hennes
f5ab6295ba UI: Remove qPixmapFromMimeSource pixmap function
This function dates back to Qt3, and was removed in Qt4. Modern Qt no
longer uses this ui file entry, and in some circumstances the uic
complains about its presence.
2025-05-15 00:56:30 +02:00
Chris Hennes
3178e13f04 Materials: Clean up unused variables
Updated error messages no longer refer to the exception object, resulting in compiler warnings.
2025-05-15 00:29:19 +02:00
Chris Hennes
b36a21b721 Gui: Eliminate signed-to-unsigned comparison
`std::numeric_limits<int>::max()` can losslessly be cast to an unsigned
int to silence the compiler warning about comparison of signed to
unsigned.
2025-05-15 00:20:35 +02:00
FEA-eng
a20d562da4 FEM: Update TaskPostGlyph.ui 2025-05-15 00:06:43 +02:00
FEA-eng
5b7d5d0a85 FEM: Update post_glyphfilter.py 2025-05-15 00:06:43 +02:00
jffmichi
2c83e612b3 CAM: fix rrf postprocessor always writing to "-" instead of specified file 2025-05-14 22:00:11 +02:00
jffmichi
f0c4205507 CAM: prevent marlin postprocessor from always writing to "-" 2025-05-14 21:55:49 +02:00
jffmichi
c3f491be57 CAM: fix crash in dynapath_4060 postprocessor due to fmt function expecting precision as integer 2025-05-14 21:50:04 +02:00
jffmichi
ffdc9832e0 CAM: fix uccnc postprocessor not checking the Active state of operations 2025-05-14 21:44:48 +02:00
jffmichi
2fd2ec5f5c CAM: fix handling of Active state and CoolantMode with nested dressups for some non-refactored postprocessors 2025-05-14 21:43:31 +02:00
Pieter Hijma
e7f0418966 Fix finding hdf5 on CMake reconfigure 2025-05-14 13:49:09 -05:00
Benjamin Nauck
098faceb66 Merge pull request #21174 from 3x380V/fix_21172
Base: fix Unit scheme management regressions
2025-05-14 19:43:59 +02:00
dependabot[bot]
0257596391 Bump actions/dependency-review-action
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 8805179dc9a63c54224914839d370dd93bd37b2e to da24556b548a50705dd671f47852072ea4c105d9.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](8805179dc9...da24556b54)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-version: da24556b548a50705dd671f47852072ea4c105d9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-14 08:05:56 -05:00
Ladislav Michl
602880ed80 Base: revert to using ASCII chararacters for imperial lengths
The new unit schema management is using U+2032 and U+2033 characters
for feet and inches while parser is expecting only ' and ", while
U+2032 and U+2033 are used for arcminute and arcsecond.

While this is not an ideal solution and parser should deal with both,
revert back to ASCII for now.

Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-14 11:39:09 +02:00
Syres916
67d0345870 Base: fix default unit schema
Fix the transcription error which occured while moving into
single structure. Default schema now uses milimeters again.

Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-14 10:25:47 +02:00
Ladislav Michl
e577bebe56 Base: fix Python interface for Unit schema selection
Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-14 10:20:49 +02:00
Ladislav Michl
2e35afd6e0 Base: sort returned Unit schema description
Return schemas name and description vectors sorted by number, so
index can be used later to select particular schema.

Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-14 10:20:49 +02:00