Commit Graph

20474 Commits

Author SHA1 Message Date
Abdullah Tahiri
0d5e120a2c GCS: SparseQR compilation guards 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
72c2830a52 GCS: reduce input parameters in makeDenseQRDecomposition 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
909adbd93d GCS: Refactor Non-Zero elimination over pivot 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
28f6978a0d GCS: Refactor diagnose identification of conflicting and redundant constraints 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
6e53dd0034 GCS: Refactor dependent parameters identification which is only available for DenseQR 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
083aa1099a GCS: Refactor QR decomposition into separate functions for Sparse and Dense 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
417727754f GCS: Increase documentation of diagnose() routine 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
a4481a327c Sketcher: ViewProviderSketch update of geometry extensions
==========================================================

The order of any operation, including setedit is first solve() and then draw().

This is consistent with geometry addition.

If ViewProviderSketch must insert its own extensions, for example for scaling
weights, then it is its responsibility to set this information wherever needed.
This includes the temporal geometry vector used in draw(true), the solver to
enable dragging operations, and SketchObject Geometry property.
2020-12-19 11:58:54 +01:00
Abdullah Tahiri
4d9fcb0b27 Sketcher: Fix crash when creating an angle constrain on a line segment
======================================================================

Most of these crashes come from previous code not checking for Constraint::GeoUndef.

Most of these crashes come from isBSpline(), any of the two overloads.

isBSpline is made to throw exception when null, which should prevent the crash while
creating a reportable error.
2020-12-19 11:58:54 +01:00
Abdullah Tahiri
533ba5b159 Sketcher: delete internal alignment geometry using new delGeometries function 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
f7be6f5051 Part: Geometry - BSplineCurve - add IsRational member function 2020-12-19 11:58:54 +01:00
Russell Johnson
db93fd13e7 Path: Fix reference to cutting edge angle in OCL_Tool() class
The class variable name was not corrected with previously committed changes.
The correct cutting edge variable name is located in the __init__() constructor method.
2020-12-18 16:04:28 -06:00
Russell Johnson
a02306d6ac Path: Fixes to path generation for certain selections
Fixes path generation for selection of two non-parallel edges.
Fixes path generation for selection of single, bottom face of slot with two non-parallel ends.
Fixes path generation for selection of two parallel, bottom bounding edges of slot.
2020-12-18 16:04:07 -06:00
Russell Johnson
6bf18f93c3 Path: Add docStrings to some methods 2020-12-18 16:04:07 -06:00
Russell Johnson
de8a04ed0e Path: LGTM and spelling correction 2020-12-18 16:04:07 -06:00
sliptonic
194c6e8178 Merge pull request #4157 from sliptonic/bug/4466
fixes 4466  Path Template Saving incorrect attributes
2020-12-18 15:31:47 -06:00
wmayer
ff69f7fba3 PartDesign: [skip ci] fix Hole feature
* by default ThreadDirection must be set read-only since Threaded by default is None
* use suitable values to initialize the class properties
2020-12-18 21:18:41 +01:00
sliptonic
3754ae123a Merge branch 'master' into feature/suppress-warnings-preferences 2020-12-18 11:12:48 -06:00
sliptonic
e80c5bea16 Merge branch 'master' into bug/4466 2020-12-18 11:11:18 -06:00
sliptonic
53a3b6f41f Merge pull request #4160 from mlampert/bugfix/issue-4500-segfault
Path: Bugfix/issue 4500 segfault
2020-12-18 11:03:42 -06:00
wmayer
2db10d8236 PartDesign: [skip ci] fix order of controls so that by pressing TAB always the next control gets focus 2020-12-18 17:04:27 +01:00
M G Berberich
a2b1e6226a cleanup of hole dialog
* replaced widget with radiobuttons by button Group, to improve alignemt
  of DrillPointAngle with grid-layout

* made Thread Pitch/Angle/Cutoffs widgets wider
2020-12-18 16:38:46 +01:00
wmayer
d4bd0098c2 PartDesign: [skip ci] fix layout of Drill point controls 2020-12-18 16:28:35 +01:00
Bryan Bendall
d8ebf1bb30 Path: Added option for the finishing pass of the adaptive op 2020-12-18 08:03:42 -05:00
Aapo
5f497ab37a [TD] Balloon, fix Origin and scale refresh bugs, make Balloon scale change more reasonable per UI click. 2020-12-18 12:45:34 +01:00
Aapo
d81e377546 [TD] Balloon, fix EndTypeScale refresh bug. 2020-12-18 12:45:34 +01:00
Aapo
294136e9bd [TD] Balloon, move property LineVisible to View tab and fix a refresh bug. 2020-12-18 12:45:34 +01:00
Aapo
7d260787b9 [TD] Balloon, change ordering of the data properties to more logical. 2020-12-18 12:45:34 +01:00
Markus Lampert
08f708d2bd Added provision for gcc peculiarities in unit tests 2020-12-17 23:11:02 -08:00
Markus Lampert
1f839e5ea1 Reuse existing QuantitySpinBox'es in order to avoid segfault on focus change. 2020-12-17 23:01:55 -08:00
Markus Lampert
b2dce8c76a Allowing QuantitySpinBox to be reused for different attribute; using properties to get values to work around build differences. 2020-12-17 22:56:42 -08:00
Markus Lampert
be221dd25d Rearranged BitTool shape update so dependent ops don't execute with invalid tool. 2020-12-17 20:27:42 -08:00
Markus Lampert
1a2249387e Make BitShape read/writeable, so the tool can be edited when shared to a different system 2020-12-17 19:59:44 -08:00
Markus Lampert
7e2f088833 Hide document when loading a ToolBit. 2020-12-17 19:55:59 -08:00
Markus Lampert
6b5a99319a Only update the shape if it has changed. 2020-12-17 19:14:44 -08:00
sliptonic
248c69a9db Merge branch 'master' into posttodxf 2020-12-17 16:28:01 -06:00
sliptonic
804b5e590e fixes 4466 2020-12-17 16:21:31 -06:00
Aapo
2077709329 [TD] Make Dimension Tolerances respect the Prefs formatSpec when creating a Dimension. 2020-12-17 17:30:29 +01:00
wmayer
b62aeaf6b7 PartDesign: [skip ci] make the spin box for the angle of the drill point wider 2020-12-17 17:10:42 +01:00
M G Berberich
f5be329c3f make the hole-cut-type dropdown-box wider
This drop-down box contains long names and did not use the space of
the dialog.
2020-12-17 16:59:26 +01:00
sliptonic
90e1ae8bf4 add post to Cmakelists.txt for install 2020-12-16 16:54:55 -06:00
Abdullah Tahiri
ccd8551f2b Sketch: Fix exception on redraw
===============================

Fixes:
https://forum.freecadweb.org/viewtopic.php?p=458293#p458293

Rationale:
In order to fix B-Spline pole dragging, the order was inverted.
This fixed the B-Spline pole dragging issue, but introduced a
draw before solve approach that is not consistent with the rest
of the Sketcher.

In my parallel development I had already identified this inconsistency,
switched the order, and provided a new mechanism to fix the issue with
the B-Spline pole dragging. This will be merged as part of another PR.

In the meantime, this PR restores the intended behaviour, and let us
identify if the particular reported exception also happens in other
situations.
2020-12-16 19:35:42 +01:00
Abdullah Tahiri
b7f9cbaf8b Sketcher: Fix equality constraint command
=========================================

For select constraint then click elements mode.

Fixes:
https://forum.freecadweb.org/viewtopic.php?f=10&t=51716&p=458207#p457974
2020-12-16 15:21:21 +01:00
Abdullah Tahiri
40a2e52bc0 Sketcher: Fix crash on applying angle constraint on arc
=======================================================

The GeoId passed was Constraint::GeoUndef (-2000).

Fixes:
https://forum.freecadweb.org/viewtopic.php?f=10&t=51716&p=458202#p458160
2020-12-16 14:20:02 +01:00
Yorik van Havre
0a60d49953 Merge pull request #4025 from travisapple/master
New WebGL Exporter
2020-12-16 12:07:17 +01:00
wmayer
5b4c61e175 Path: [skip ci] fix TooltablePy::getTools to avoid possible double destruction of a Tool instance 2020-12-16 10:34:24 +01:00
Markus Lampert
bb74714235 Print deburr tool info only once. 2020-12-15 21:55:27 -08:00
Markus Lampert
5049a98748 Changed print to debug msg 2020-12-15 20:16:06 -08:00
Markus Lampert
354af74b61 Disabled path wb dis-/activated msgs 2020-12-15 20:11:40 -08:00
Markus Lampert
6984140584 Disabled '... postprocessor loaded' messages 2020-12-15 20:09:55 -08:00