Commit Graph

62 Commits

Author SHA1 Message Date
wandererfan
842b70654c [TD]fix leader start point on rotated view 2024-07-22 09:14:34 -04:00
WandererFan
50f970efd7 [TD]Cosmetic function overhaul (#14216)
* [TD]Cosmetic geometry and tools update

- all cosmetics to store geometry in same form
- all cosmetics to survive scaling and rotation
- extension functions to survive scaling and rotation

* [TD]overhaul leader point storage and editing

- add py routine makeLeader(points)

* [TD]add leader conversion utility

* [TD]Set Leader RotateWithView default to true

* [TD]fix intersection vertex position

* [TD]add CosmeticEdge::makeLineFromCanonicalPoints

* [TD]fix 2 Extension tools

- positioning in DrawCosmeticCircle
- mishandling of points in execLineParallelPerpendicular

* [TD]Remove duplicate constexpr

* [TD]fix 2x Cosmetic arc tools

* [TD]refactor LineFormat out of Cosmetic

* [TD]move cosmetic appearance settings to LineFormat

* [TD]remove 2 unused methods

* [TD]apply format to blue line & circle tools

* [TD]fix ballon arrowhead does not rotate with view

* [TD]fix CosmeticCircle3Points

* [TD]allow multiple cosmetic object deletions

* [TD]fix extend/shorten centerline
2024-05-23 09:41:42 -04:00
Farley Runkel
9430ea9ee5 TechDraw: Refractor tracker action with proper enum 2024-04-22 18:21:49 +08:00
wandererfan
a8cc561396 [TD]apply translateLabel after all addObject calls 2023-08-17 19:23:29 -04:00
Chris Hennes
ad8177c9fa TD: Translate default labels 2023-08-17 19:23:29 -04:00
luzpaz
1b43baa418 Fix various trailing newlines, typos and grammar 2023-02-04 18:29:07 +01:00
wmayer
25beef481c TD: move to new style connect() 2023-02-01 01:33:34 +01:00
wandererfan
437457e996 [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
Uwe
7e70d28761 [TD] Task*, part 2/2: remove unused includes
- also some sorting
- also take care of PreCompiled.h
2022-12-07 19:49:05 +01:00
Uwe
c8b51fb79c [TD] DrawUtil: remove unused includes
- also sort includes
- also move a definition to it
- also adapt two Gui files accordingly
2022-10-08 03:35:59 +02:00
Uwe
5367aa8ab2 [TD] remove redundant nullptr checks 2022-10-03 04:25:33 +02:00
wmayer
af8421c1fb TD: remove unused member variables to fix -Wunused-private-field 2022-09-08 08:15:19 +02:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
b467cd32f2 [TD]refactor scene/view/mdi
- move scene related functions out of mdiViewPage
  and QGVPage.
- route requests for scene/view/mdi through
  ViewProviderPage
2022-08-18 09:34:32 -04:00
Benjamin Bræstrup Sayoc
71758ecf9b [TechDraw] Clean up precompile in Gui 2022-08-14 09:20:38 -04:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Benjamin Bræstrup Sayoc
f30c30b06f [TechDraw] Simplify code getting default line weights 2022-08-02 16:13:01 -04:00
wmayer
781997984d TD: Use new-style syntax of connect()
When fixing clazy issues -Wclazy-fully-qualified-moc-types then old-style syntax of connect() may fail. Thus, replace it with the new-style syntax
2022-07-26 16:10:45 +02:00
Uwe
b81d7e4864 [TD] remove some more superfluous nullptr checks 2022-07-20 11:54:28 +02:00
Uwe
b514f47c21 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Benjamin Bræstrup Sayoc
664426d394 [TechDraw] Improve readability of TaskLeaderLine.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
04371d3fca [TechDraw] Rename icon filenames for consistency 2022-07-09 14:38:30 -04:00
Wanderer Fan
db89eec8e3 [TD]implement navigation styles 2022-06-24 10:03:02 -04:00
Kuzemko Alexsandr
e08ce2f169 [TD] Fix incorrect using of QT_TRANSLATE_NOOP in setText 2022-06-01 13:41:00 -04:00
Wanderer Fan
61526b83fc [TD]mark literals for translation 2022-05-13 13:41:37 -04:00
Chris Hennes
84ae226ec6 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
Uwe
5757cdf2ad [TD] remove a single-header file 2022-03-25 04:11:53 +01:00
Uwe
175484cf3f [TD] add missing header 2022-03-25 03:04:39 +01:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
wmayer
8f786ea6ef Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Wanderer Fan
d4c5074ee5 [TD]remove redundant edits from 9 Task dialogs 2022-01-22 14:51:20 -05:00
wmayer
5c4fcaef1d TD: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 316559 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value we. Field we.idx is uninitialized when calling push_back

CID 316549 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member pageheight is not initialized in this constructor nor in any functions that it calls.

CID 186161 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member parent is not initialized in this constructor nor in any functions that it calls.

CID 305170 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking this->m_baseFeat suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

CID 186152 (#2 of 2): Uninitialized pointer field (UNINIT_CTOR)
3. uninit_member: Non-static class member m_mdi is not initialized in this constructor nor in any functions that it calls.

CID 192588 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT)
pointless_expression
2021-02-21 16:30:30 +01:00
donovaly
691eaa6e8f [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
donovaly
4bae944950 [TD] make LineGroup selectable
At the moment one has to specify the LineGroup as string. But one doesn't know what groups exist. So one has to check the Wiki, learn there where the groups are defined and then open the definition file with a text editor.

This PR simplifies this by reading the existing groups out of the definition file and fill the combobox accordingly.
It also give the user info what the selected LineGroup defines via the tooltip.

A nice side effect is that no typos can occur since you don't have to enter the LineGroup name as text.
2020-12-03 17:24:49 +01:00
luz paz
89664642fb TD: Issue #0004473: Expose openCommand() to translation
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the TechDraw Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
2020-12-01 14:53:35 +01:00
luz paz
ae71abd1cc TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
2588d0701a Coverity: [skip ci] Dereference before null check 2020-07-21 14:31:09 +02:00
wmayer
983939b32d Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wmayer
0a6929a122 Coverity: Dereference after null check 2020-07-20 17:34:25 +02:00
wandererfan
a3029fec74 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
wandererfan
03d36e3a40 [TD]correct button text 2020-03-24 18:16:23 -04:00
wandererfan
a564c468f0 [TD]fix Leader end type selection 2020-03-23 09:23:08 -04:00
wandererfan
2d404558a7 [TD]fix Leader attach point secondary views 2020-03-23 09:23:08 -04:00
donovaly
baf6dc50e7 [TD] make LeaderLine dialog show changes immediately 2020-03-22 09:37:04 -04:00
donovaly
e16a452c3d [TD] fix order of arrow heads
see https://forum.freecadweb.org/viewtopic.php?f=35&t=44334#p378675
2020-03-21 09:44:07 -04:00
wandererfan
b493b3841d [TD]harmonize Arrow enums 2020-03-11 09:33:54 -04:00
donovaly
47def896a1 [TD] LeadlerLine dialog beautifications
(add tooltips, use a display widget)

see https://forum.freecadweb.org/viewtopic.php?f=35&t=43360&p=369885#p369885
2020-02-18 07:36:59 -05:00
wandererfan
9e6d1ad077 [TD]fix LL edit when no MDI 2020-02-16 14:24:14 -05:00
WandererFan
06357db88d [TD]sync icon names and menu entries
- contributed by @uwe
2020-02-03 07:20:52 -05:00
wandererfan
c4394eadc6 [TD]Default color and weight for markup lines 2020-01-29 15:26:06 -05:00