Commit Graph

20158 Commits

Author SHA1 Message Date
Russell Johnson
9da9bf0f93 Path: Fix outside extension of circular faces with inner holes
Fix bug identified by MLampert.  This fix addresses extensions for circular faces that have non-extended holes in the face.
.
Unlike polygon extensions that only need one wire to define the extension shape, some circular extensions require two wires (a face would be better) to define the extension area.
.
Restructure to accommodate future `Extensions` improvements
2021-04-10 14:09:22 -05:00
Stephen Early
c617b252ff Improve WebGL export javascript template
Several improvements to the javascript in the template:

 * Render on demand rather than continuously
 * Support high-DPI displays
 * Fix the frustum depth for both cameras
 * Deal correctly with the browser window being resized
 * Only show controls for objects with geometry

Also some changes made for code clarity:

 * Use 'const' and 'let' instead of 'var', as appropriate
 * Use for...of and .map() instead of iterating over arrays
   using a loop counter
2021-04-10 18:03:09 +01:00
wmayer
8c4b2506bd Import: [skip ci] for glTF export set scale factor of 0.001 because lengths are measured in meters 2021-04-10 18:37:56 +02:00
Chris Hennes
2751398ec0 [OpenSCAD] Fix twist angle to not limit to 360 deg 2021-04-09 12:09:24 -05:00
wmayer
14e3c91158 Py: fix memory leak 2021-04-09 16:59:33 +02:00
Syres916
c30433c041 [Techdraw] Fix minor bug changing Image Crop...
... from True to False does not fill image view box only approx three quarters.
This was found testing reported issue https://forum.freecadweb.org/viewtopic.php?f=35&t=57537 (otherwise it works as @wandererfan expected)
2021-04-09 10:23:29 +01:00
Russell Johnson
79cfcc0ff6 Path: Improve horizontal-planar and curved face handling
These changes allow for better identification of horizontally planar faces, and also improve handling of circular arc faces that failed previously for use with ball-end bits.
This fix also improves slot creation based on selection of two arc edges for ball-end slot creation.
2021-04-08 22:43:33 -05:00
Russell Johnson
8f2864acd8 Path: Fix comment syntax 2021-04-08 22:43:33 -05:00
Russell Johnson
b76b1fae97 Path: Fix variable naming to use lowercase 2021-04-08 22:43:33 -05:00
Russell Johnson
ccba37af3e Path: Fix error when no obj.Base features selected 2021-04-08 22:43:32 -05:00
Russell Johnson
b372cc7549 Path: Add check for CustomPoint input
If custom points are same, the user has not entered acceptable values for path generation with custom points.
2021-04-08 22:43:32 -05:00
Russell Johnson
de866634e2 Path: Set CustomPoint2 and CustomPoint1 defaults equal
Setting these two default values equal will aid in code execution and error detection.  Subsequent fixes will rely on this condition.
2021-04-08 22:43:32 -05:00
Russell Johnson
55453bd69d Path: Fix update of Extensions Default Length GUI spin box
Fix the bug hindering update of the Default Length spin box in the Extensions tab after editing and change of focus. 
With the fix, the spin box updates after change of focus, as do other spin boxes in the Path workbench.
Used method found in PathDrillingGui module.
2021-04-08 22:27:02 -05:00
donovaly
58b0dd38c2 [FEM] proper support for Gmsh HighOrder optimization
There are 4 optimizers available while we only supported 1. This PR adds support for all.
2021-04-08 13:29:50 +02:00
marioalexis
2f81ca40be Draft: Sync input fields in task panel 2021-04-07 18:36:56 -03:00
marioalexis
5cc042379a Draft: Add functions to transform Cartesian coordinates to spherical and vice versa 2021-04-07 18:36:56 -03:00
donovaly
e8668e9e45 fix bug that property "SprocketReference" is not an enum 2021-04-07 17:07:01 +02:00
donovaly
62a86deff0 [PD] sort entries in sprocket feature
as the title says.

(The other UI file changes were made by Qt's designer.)
2021-04-07 17:07:01 +02:00
Yorik van Havre
e91d58e295 Merge pull request #4712 from tomate44/wirestring
Draft.ShapeString : add option to choose wires or faces output
2021-04-07 13:06:22 +02:00
Abdullah Tahiri
a6cae70e94 Sketcher: Adapt fillet to moving addConstraint 2021-04-07 08:05:04 +02:00
Syres916
c2c2058c9f [0.20][PartDesign] Sprocket - Correct camelCase 2021-04-06 16:40:44 +02:00
Syres916
3295ec035a [0.20][PartDesign] Sprocket UI - Allow multiple...
... standard reference sprockets rather than just ANSI as well as capturing the thickness as stated in the particular standard. The user is not bound by this but it saves them looking it up manually.
See recent posts in discussion : https://forum.freecadweb.org/viewtopic.php?f=22&t=44525
2021-04-06 16:40:44 +02:00
Syres916
aee3e86e61 [0.20][PartDesign] Sprocket - Allow multiple...
... standard reference sprockets rather than just ANSI as well as capturing the thickness as stated in the particular standard. The user is not bound by this but it saves them looking it up manually.
See recent posts in discussion : https://forum.freecadweb.org/viewtopic.php?f=22&t=44525
2021-04-06 16:40:44 +02:00
donovaly
f1ab972234 [PD] UI file fixes
the rotation angle settings of primitives had a different layout than the other parameters, this things like shown in the image below happened.

- The PR uniforms all layouts to grid and for the PD layout
- it sets for the cylinder page a minimum width
- the PD UI file is now also sorted using David's file sorter
- fix the mess with stdset="0"> I accidentally introduced with the merges from yesterday (I simply forgot to install to Qt designer the FreeCAD widgets and then designer pollutes the file with these tags for all FC-specific widgets since it doesn't know them
2021-04-06 13:17:43 +02:00
donovaly
c3264a7cfa [Part] [skip ci] add a word in description
since we have now 3 angles for cylinders, make clear the angle property is for the rotation
2021-04-06 11:39:51 +02:00
wmayer
6197243fa7 Base: Vector3::GetAngle() uses a smaller epsilon 2021-04-06 11:37:35 +02:00
luz paz
751399892a [TD] icon uniformity for ActiveView and FaceCenterLine commands
Renamed SVGs, saved as plain svg, updated appropriate areas in the source code
2021-04-05 14:41:30 +02:00
donovaly
0369bc0853 [PartDesign] add direction to cylinder primitive
We already have the possibility to create skewed prisms. I recently stumbled upon that I would need this feature for cylinders too.

This PR takes the existing prism extrude direction feature and use it for cylinders too
2021-04-05 14:35:50 +02:00
donovaly
1f0e0f3e21 [Part] add direction to cylinder primitive
We already have the possibility to create skewed prisms. I recently stumbled upon that I would need this feature for cylinders too.

This PR takes the existing prism extrude direction feature and use it for cylinders too
2021-04-05 13:59:03 +02:00
wmayer
021f42f828 PartDesign: for Prism feature use PrismExtension 2021-04-05 13:25:36 +02:00
wmayer
2b09a3ebec Part: for Prism feature use PrismExtension 2021-04-05 13:25:19 +02:00
wmayer
fd7d4c91e8 Part: implement Prism as extension 2021-04-05 13:05:59 +02:00
tomate44
c48ec7cff2 Draft.ShapeString : add option to choose wires or faces output 2021-04-05 12:20:04 +02:00
Mateusz Skowroński
252d30e40f QPainter::HighQualityAntialiasing is deprecated. Use QPainter::Antialiasing instead. 2021-04-04 11:33:51 +02:00
Mateusz Skowroński
5032a8e31f Qt::MidButton is deprecated. Use Qt::MiddleButton instead. 2021-04-04 11:33:51 +02:00
bitacovir
2f0232c5f0 [UI] Replace SVG icon of TechDraw RedrawPage 2021-04-03 17:58:05 +02:00
wmayer
f4e0abc9d2 Spreadsheet: [skip ci] fix gcc warnings about unused variables 2021-04-03 12:21:42 +02:00
Benjamin Nauck
4e4a8df724 Spreadsheet: Fix UI issues when trying to insert rows/cols
* Add support for better translations (using pluralizations)
* Add support for inserting rows/columns after the selection
* Informs the user that it will insert rows/cols above/under/left/right of the selection
* Informs the user how many rows/cols that will be inserted
2021-04-02 19:33:06 +02:00
wmayer
8de66e134f Web: remove obsolete function setTextSizeMultiplier because QtWebEngine already supports HiDPI monitors 2021-04-02 14:10:02 +02:00
Chris Hennes
8e6c5946cd [Web] Remove deprecated Qt < 5.9 code 2021-04-02 13:46:43 +02:00
wmayer
0177f9b9f8 TD: [skip ci] fix DrawingView::print/MDIViewPage::print 2021-04-02 12:06:24 +02:00
Chris Hennes
bd86b4dcfe [TD] Remove deprecated Qt < 5.9 code 2021-04-02 12:02:54 +02:00
Benjamin Nauck
67bbb61103 Tux: Add "_light" suffix to light navigation icons 2021-04-01 19:48:18 +02:00
Benjamin Nauck
c7212d9c21 Tux: Add "_dark" suffix to dark navigation icons 2021-04-01 19:48:18 +02:00
Chris Hennes
cbf9b72bb3 [Sketcher] Remove deprecated Qt < 5.9 code 2021-04-01 19:38:23 +02:00
Chris Hennes
e0b9f28198 [Part] Remove deprecated Qt < 5.9 code 2021-04-01 19:36:40 +02:00
Chris Hennes
ee2d7651b8 [Spreadsheet] Remove deprecated Qt < 5.9 code 2021-04-01 19:31:22 +02:00
Chris Hennes
93f2166d2b [Test] Remove deprecated Qt < 5.9 code 2021-04-01 19:30:30 +02:00
wmayer
136a402b7e Import: if in a dxf file control points and fit points are given then use the former to create the B-Spline 2021-04-01 13:27:03 +02:00
wmayer
f95aeb7144 smesh: [skip ci] build FEM & MeshPart with C++14 when using external smesh because it doesn't support C++17 yet 2021-03-31 15:35:28 +02:00