Commit Graph

29619 Commits

Author SHA1 Message Date
Uwe
ce86b03e0a [Spreadsheet] remove superfluous nullptr checks 2022-07-18 01:49:41 +02:00
Uwe
fc548a4b34 [FEM] remove superfluous nullptr checks 2022-07-18 01:45:19 +02:00
Uwe
5f8e0c46ee [Part] remove more superfluous nullptr checks 2022-07-18 01:36:27 +02:00
Uwe
697e88aed6 [PD] remove more superfluous nullptr checks 2022-07-18 01:33:28 +02:00
Uwe
5048f14d60 .clang-format: change a style
as discussed here: https://github.com/FreeCAD/FreeCAD/pull/6918#issuecomment-1186529217
2022-07-18 00:48:46 +02:00
Uwe
a8d01fa6c6 [PD] add parameter enabling logic for pad/pocket
- currently all parameters are always enabled and thus can lead to errors like the one reported here:
https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
2022-07-18 00:26:15 +02:00
Uwe
e4dfc42f33 [PD] improve face selection for Pad/Pocket
- this PR extends PR #7191 as described in this forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=70327
2022-07-17 18:35:34 +02:00
Uwe
35f75064a0 [PD] remove superfluous nullptr checks 2022-07-17 18:12:41 +02:00
Uwe
07ddfc88de [PD] App: remove superfluous nullptr checks
- also Body: get rid of some nasty single-letter variables
2022-07-17 18:07:00 +02:00
Uwe
e491ba8d12 [Part] remove superfluous nullptr checks 2022-07-17 18:06:21 +02:00
sliptonic
ef04487cd1 Merge pull request #7168 from sliptonic/feature/camoticstooltable
[Path] export a camotics tooltable
2022-07-17 08:42:43 -05:00
wmayer
5820618091 Import: do not export the entire class but only its public methods.
This fixes the warning C4251 for the template classes std::string or std::vector
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=70317
2022-07-17 13:49:27 +02:00
wmayer
b548d3b1ef Partially revert "Remove unused code into GUI" 2022-07-17 12:32:03 +02:00
andrea
3018985f80 Remove unused code into GUI 2022-07-17 03:53:11 +02:00
Uwe
094ae93678 [PD] fix Pad/Pocket logic issue
- fixes the bug reported in https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
  as Method #2
  -> When switching to two dimensions, symmetric must be unchecked if it is checked
2022-07-17 02:03:35 +02:00
Uwe
faa1f96f08 [FEM] check if Gmsh, CCX and Mystran solver binaries exist
- adds the check like we have already for Z88 and Elmer
- also remove an unnecessary return statement
2022-07-17 01:43:58 +02:00
Uwe
da104f63b7 [FEM] fix CCX (new framework) binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message to the status info so that user gets feedback also when report view console is not shown
2022-07-17 01:28:54 +02:00
Uwe
3a993abfb4 [FEM] fix Z88 binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message for Elmer and Z88 to the status info so that user gets feedback also when report view console is not shown
- uniform wording to 'binary'
- avoid unnecessary console output
2022-07-17 01:18:21 +02:00
Uwe
a4ec6d4f83 [TD] fix compilation on MSVC
- CLMODE was used before its declaration, therefore it did not compile
forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=70316
2022-07-17 00:26:13 +02:00
Benjamin Bræstrup Sayoc
e80e8bf731 [TechDraw] Improve readability of DrawUtil.cpp 2022-07-16 16:00:43 -04:00
Benjamin Bræstrup Sayoc
0421d7cc5d [TechDraw] Gather rotation calculations in a single function 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
137a4e0ee6 [TechDraw] Improve readability of Cosmetic.cpp 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
568cc79186 [TechDraw] Refactor CosmeticEdge constructors
Use constructor delegation and default parameters for CosmeticEdge
2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
fac4e72ea4 [TechDraw] Use constructor delegation for CosmeticEdge 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
eb3a04f30e [TechDraw] Use default parameters for LineFormat constructor 2022-07-16 16:00:10 -04:00
Uwe
4a5bf895ed [FEM] [skip CI] inform user about used CPU cores for Elmer
Since the number of used cores can for Elmer have the impact that a solver run converges or not, output this info prominently
2022-07-16 19:46:46 +02:00
Uwe
3542c73966 [FEM] [skip CI] tell user when Elmer write succeeded
At the moment the user gets no feedback, while for Z88 and CCX he gets a result
2022-07-16 19:41:43 +02:00
Uwe
146e5508aa [FEM] [skip CI] fix wording
Calculix will not be broken, but stopped. After clicking the button your will also get a message that it has been 'stopped'
2022-07-16 19:33:02 +02:00
wmayer
2a41f359f7 Gui: implement mechanism to set a custom icon name or tooltip of a preferences group 2022-07-16 19:27:22 +02:00
Uwe
2782d09dee [FEM] [skip CI] fix a typo 2022-07-16 19:21:25 +02:00
sliptonic
fa49c07840 Update src/Mod/Path/PathScripts/PathToolBitLibraryGui.py
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2022-07-16 12:16:14 -05:00
sliptonic
1a8a7959e5 Merge pull request #7127 from sliptonic/feature/chipbreak
[Path] Feature/chipbreak
2022-07-16 12:02:38 -05:00
Uwe
32ac6fa9fd [FEM] [skip CI] fix a string 2022-07-16 18:54:11 +02:00
sliptonic
9f7c699fb8 GUI panel for chipbreaking 2022-07-16 11:30:16 -05:00
sliptonic
6d81f31f11 Additional changes to support G73 2022-07-16 11:30:16 -05:00
sliptonic
ff1e995f30 Generator can produce G73 (chipbreak) commands instead of G83.
Add tests
2022-07-16 11:30:16 -05:00
wmayer
2dd9d69112 Gui: fix crash in ExpressionCompleter::slotUpdate
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=69931
2022-07-16 18:23:42 +02:00
Wanderer Fan
3137a81604 [TD]check for spline on linear Dims 2022-07-16 11:28:38 -04:00
Wanderer Fan
5d93fbe0bb [TD]fix ext line gap preference 2022-07-16 11:28:38 -04:00
Uwe
6d54ca4df4 [Gui] preferences: clarify Part/PD page
- users are confused that we have a preferences page named "Part design" that also defines things for the Part WB. The Wiki is clear that the preferences page is for both, Part and PD, however the UI is not.
This PR makes this clear.
2022-07-16 16:20:36 +02:00
wmayer
656408615a PD: fix ProfileBased::getSupportFace() to also handle the case where a support face is selected 2022-07-16 16:08:09 +02:00
Uwe
fcd5394864 [Gui] preferences: add button to switch gradient colors
- when finding a suitable background color gradient, it is annoying that there is no button to switch the begin/end color of the gradient. With the button one can quickly see the the changes and find a suitable gradient much quicker
2022-07-16 16:05:54 +02:00
Uwe
10301e7f75 [FEM] [skip CI] fix a typo 2022-07-16 16:01:38 +02:00
wmayer
882125c1c6 PD: rename getUpToFaceFromLinkSub to getFaceFromLinkSub 2022-07-16 15:59:54 +02:00
Uwe
6625281986 [FEM] enable to run Elmer multi-threaded
- this needs proper testing, especially on a non-Windows system

- note that for some tasks multi-threading requires non-standard additional solvers like MUMPS. Ideally the user should be informed about this, depending on the equations he uses. But this should not block this PR, meaning to use multi-threading in general.
2022-07-16 14:59:25 +02:00
wmayer
f34a814ead Part: replace PyObject_Not with Base::asBoolean 2022-07-16 14:10:34 +02:00
wmayer
201f4c9a5a Core: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 14:04:05 +02:00
wmayer
d1ef818f39 Fem: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:37:55 +02:00
wmayer
76330db700 Import: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:37:12 +02:00
wmayer
aea58ace37 Mesh: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:33:18 +02:00