Commit Graph

26394 Commits

Author SHA1 Message Date
wmayer
99121b75c9 LGTM: [skip ci] fix: Local variable hides global variable
A local variable or parameter that hides a global variable of the same name.
This may be confusing. Consider renaming one of the variables.
2020-07-26 19:30:24 +02:00
donovaly
7a5be2d42e [TD] add 2 shortcuts for dimensions
as discussed here: https://forum.freecadweb.org/viewtopic.php?f=35&t=48980
2020-07-26 11:22:06 -04:00
wmayer
e9ce75d544 LGTM: [skip ci] fix: Empty branch of conditional
An empty block after a conditional can be a sign of an omission and can decrease maintainability of the code.
Such blocks should contain an explanatory comment to aid future maintainers.
2020-07-26 15:49:14 +02:00
wandererfan
41380359a8 [TD]fix misaligned PAT hatch on section 2020-07-25 10:30:13 -04:00
wmayer
83f1c667d4 LGTM: [skip ci] fix: Resource not released in destructor 2020-07-25 14:48:59 +02:00
wmayer
a128272364 LGTM: [skip ci] fix: Accidental rethrow 2020-07-24 20:57:14 +02:00
wmayer
2f0951c03b LGTM: [skip ci] fix: Function declared in block 2020-07-24 20:37:17 +02:00
wmayer
a8d1f2dca1 LGTM: [skip ci] fix: Duplicate include guard 2020-07-24 20:22:00 +02:00
wmayer
57d23463b1 LGTM: [skip ci] fix: Wrong type of arguments to formatting function 2020-07-24 19:58:48 +02:00
wmayer
e079e7a7bb LGTM: [skip ci] fix: Non-virtual destructor in base class 2020-07-24 19:30:12 +02:00
wmayer
c162037476 LGTM: [skip ci] fix: Large object passed by value 2020-07-24 18:32:31 +02:00
SurajDadral
0988e570c2 Add Mark property to ArchRebar object
As discussed here:
https://forum.freecadweb.org/viewtopic.php?f=23&t=44580&p=418377#p418630
And required for reinforcement drawing/dimensioning.
2020-07-24 13:50:29 +02:00
luz paz
3ba2a7507c Crowdin: Edits based on feedback from translators [skip-ci]
https://crowdin.com/translate/freecad/27911/en-en#6581566  
https://crowdin.com/translate/freecad/6766/en-en#6584432  
https://crowdin.com/translate/freecad/549/en-en#6578092
2020-07-24 13:49:59 +02:00
vocx-fc
444e8528b0 Arch: improve import and export IFC preferences pages
Some tooltips are made more readable by adding newlines.

For `IFC import`, better tooltip for the `Number of cores` option;
also the `Replace 'Project'...` option.

For `IFC export`, better tooltip for the `Export type`;
also `IFC file units`.
Also add `General options` in case other options are added.
2020-07-24 13:48:44 +02:00
wmayer
2f5d8085bf smesh: [skip ci] port Netgen plugin to v6.2 2020-07-23 16:22:54 +02:00
Yorik van Havre
e85d0cd65c Merge branch 'master' of github.com:FreeCAD/FreeCAD 2020-07-23 14:16:47 +02:00
Mark Ganson TheMarkster
f0ea5d9de9 coverity cid 192591 (fix typo) 2020-07-23 13:55:58 +02:00
Mark Ganson TheMarkster
181eaa1b7a coverity issue cid 305102 2020-07-23 13:55:32 +02:00
carlopav
6731ade086 Arch: touch Axis when key property change
This allow experimental wall to auto align to the new axis position.
2020-07-23 13:54:18 +02:00
luz paz
e82f7f74f4 Fix Crowdin typos + trim superfluous whitespace [skip-ci]
Some issues that this PR fixes (but not all listed):  
https://crowdin.com/translate/freecad/27911/en-en#6581578  
https://crowdin.com/translate/freecad/27911/en-en#6579080  
https://crowdin.com/translate/freecad/27911/en-en#6581580  
https://crowdin.com/translate/freecad/27911/en-en#6579086
2020-07-23 13:52:44 +02:00
Jean-Marie Verdun
6152728c39 Remove unnecessary pre-processor directive
Signed-off-by: Jean-Marie Verdun <jmverdun3@gmail.com>
2020-07-23 13:47:21 +02:00
Jean-Marie Verdun
7883aad3ab Add App::Link support to Cloud module
ONLY enabled if the Cloud Module is compiled into FreeCAD
    ALL files must be saved into a Cloud Based storage
    Add a Signal to the PropertyLink to enable support of external storage
    Put the Assembly Document as active document

Signed-off-by: Jean-Marie Verdun <jmverdun3@gmail.com>
2020-07-23 13:47:21 +02:00
wmayer
b05fb4dceb Part: optimize ViewProviderPartExt::getNormals 2020-07-22 20:33:17 +02:00
wmayer
68715af145 smesh: [skip ci] port Netgen plugin to v6.2 2020-07-22 20:32:34 +02:00
wmayer
73b900386c smesh: [skip ci] port Netgen plugin to v6.2 2020-07-22 17:35:55 +02:00
Gabriel Wicke
670f3b6098 Path: Area based unified projection implementation
Generalize the `extractFaceOffset` method to `getOffsetArea`, which can
handle both face offsetting and projection. Another difference is that
the new method exposes Area's ability to preserve internal holes,
defaulting to preserving. The method is moved to the PathUtils module,
reflecting its generality and fairly wide used across Path.

This method is then used to provide a drop-in alternative to
`FindUnifiedRegions` via a small wrapper in PathSurfaceSupport. The Area
implementation is generally quick, but can fail (throw) in some cases,
so the wrapper is trying the Area method as an optimization first, and
falls back to the full `FindUnifiedRegions` logic if that fails.
2020-07-21 18:34:09 -07:00
Bernd Hahnebach
c61a1d2dbf FEM: solver frame work, beside dir fix 2020-07-21 22:12:16 +02:00
Bernd Hahnebach
0518db90b6 FEM: unit tests, fix z88 for installed FC 2020-07-21 20:54:30 +02:00
sliptonic
43f4ae927d Merge pull request #3709 from etrombly/3dSurface
[Path] fix two never ending while loops in PathSurfaceSupport
2020-07-21 10:58:48 -05:00
Bernd Hahnebach
933c90c74a Arch: import ifc, use the new layer make command since the dereciated one does not create layers on import 2020-07-21 15:18:41 +02:00
wmayer
0eb7967c40 Coverity: [skip ci] Dereference before null check
Remove logically dead code because 'pcActiveBody' cannot be null at this stage
2020-07-21 14:33:54 +02:00
wmayer
2588d0701a Coverity: [skip ci] Dereference before null check 2020-07-21 14:31:09 +02:00
wmayer
b3d292865f Coverity: [skip ci] Bad use of null-like value 2020-07-21 12:23:10 +02:00
Bernd Hahnebach
a3de62c8f1 FEM: calculix solver, fix result mesh purging on multiple result obj. 2020-07-21 07:27:42 +02:00
Sudhanshu Dubey
94509e8c18 FEM: unit tests, add tests for cantilever examples 2020-07-21 00:06:08 +02:00
Sudhanshu Dubey
36b00c0e91 FEM: unit tests, add test for node load example 2020-07-20 23:52:28 +02:00
Sudhanshu Dubey
be6ce20a48 FEM: unit tests, add test for edge load calculation example 2020-07-20 23:52:13 +02:00
Sudhanshu Dubey
f4980e73cb FEM: examples, add node load calculation example 2020-07-20 23:52:05 +02:00
Sudhanshu Dubey
5681af9206 FEM: examples, add edge load calculation on twisted hollow profile 2020-07-20 23:51:58 +02:00
Bernd Hahnebach
2f4c0bc5a8 FEM: fix unit test after coverity test 2020-07-20 23:11:18 +02:00
Bernd Hahnebach
6c47bb5b9e FEM: coverity, some left outs 2020-07-20 23:10:47 +02:00
Bernd Hahnebach
af4a520716 FEM: coverity, control flow issues 2020-07-20 22:34:04 +02:00
Bernd Hahnebach
8a6eaed01f FEM: coverity, Null pointer dereferences 2020-07-20 22:33:54 +02:00
Bernd Hahnebach
93a00dc4b2 FEM: elmer and z88 writer, add input files directory print 2020-07-20 19:37:34 +02:00
Bernd Hahnebach
cbf48af184 FEM: elmer tasks, better handling of not available elmer env variables 2020-07-20 19:37:25 +02:00
Bernd Hahnebach
1db461837d FEM: examples, selfweight elmer, change solver attribute 2020-07-20 19:37:17 +02:00
wmayer
983939b32d Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wmayer
560e13c5f2 Coverity: Unchecked return value 2020-07-20 17:34:30 +02:00
wmayer
9b2a6edeb0 Coverity: Uncaught exception 2020-07-20 17:34:29 +02:00
wmayer
c5c8b21cc4 Gui: Optimize ViewProviderDocumentObject::getDocument() 2020-07-20 17:34:29 +02:00