Commit Graph

18686 Commits

Author SHA1 Message Date
Yorik van Havre
d02a0d558e Merge pull request #4331 from chennes/openSCADFix
[Draft] OpenSCAD/DXF error: fix DXF import with no layers
2021-02-02 14:01:43 +01:00
Yorik van Havre
253ef2a99a Merge pull request #4346 from chennes/validateStartHTMLWithW3C
[Start] Modify generated HTML to comply with W3C Validator Recommendations
2021-02-02 13:59:09 +01:00
Chris Hennes
612eba1b1a Fix Surface task panel shortcut use to use Widget context
The Delete key shortcut of the three different panels in the
Surface Workbench TaskFilling sidebar conflicted between
the panels if multiple were showing. This is resolved by
making the QAction's context the widget, rather than the window.
2021-02-01 19:40:33 -06:00
Chris Hennes
1958e30f84 Modify Start HTML to be valid HTML
Using the W3C validator, a number of minor issues were found with the Start page
HTML. Those items were:
* Missing language setting on the body of the document
* Deprecated attributes set for the style and script tags
* Image tags require alt text
* List tags can only contain list items
* All file:/// URLs must not contain backslashes, even on Windows
2021-01-31 22:13:47 -06:00
Chris Hennes
7b9c9d4f5e Add tests for Start Page HTML validity
This test is in two parts: first the generated HTML is sanitized to remove any
potentially sensitive information (e.g. filenames, authors, document info, etc.)
and is then sent to the W3C Validator service at https://validator.w3.org/nu.
The results are interrogated and if any errors or warnings are returned, the
test fails. If the site cannot be reached this is NOT treated as a test failure.

Second, the actual (unsanitized) filenames are checked for validity: the HTML
standard prohibits backslashes in URLs, even if the URL refers to a local file
on a system that uses backslashes as a path separator (e.g. Windows). This
would have been caught by the W3C Validator if we had not sanitized the filenames.
2021-01-31 21:49:17 -06:00
wmayer
93a956e70d [PD] [skip ci] fix alignment in pad dialog
just a minor UI issue: when you decrease the width of the pad dialog (e.g. because you have a small screen), the alignment of the widgets is lost. This fixes it by grouping the widgets in a grid.
2021-01-31 16:26:22 +01:00
donovaly
b50838c7a5 [PD] fix alignment in pocket dialog
just a minor UI issue: when you decrease the width of the pocket dialog (e.g. because you have a small screen), the alignment of the widgets is lost. This PR fixes this by grouping the widgets in a grid.
2021-01-31 16:03:57 +01:00
Aapo
4ea0784341 [TD] Dimensions: donovaly's minor fixes for TheoreticalExact dimensions. 2021-01-31 15:17:46 +01:00
Aapo
e802179cf4 [TD] Improve arbitrary tolerance and unit handling for Equal Tolerances. 2021-01-31 15:17:46 +01:00
Aapo
660710c26e [TD] Add under- and overtolerances for Dimension Task layout, fixes for Dimension tolerance refresh and behavior. 2021-01-31 15:17:46 +01:00
Aapo
a2f060e36e [TD] Fix degree sign processing for equilateral angular plusminus dimensions. 2021-01-31 15:17:46 +01:00
Aapo
d26b6542ca [TD] Fix regression in Dimensions: Setting arbitrary under tolerance was somehow lost. 2021-01-31 15:17:46 +01:00
donovaly
4ab3c95552 [PD] correct hole cut definitions
I was able to get the norms and could update the definitions accordingly.
For example in the ISO 10462, sizes smaller than M3 are not defined and your definition files should only contain what is really defined.
2021-01-31 13:45:57 +01:00
wmayer
b896bb4f2a Part: [skip ci] fix path of attachment icon 2021-01-30 17:22:54 +01:00
Stefan Tröger
446ce21517 Remove ExtensionProxy and rely on default Python proxy for extensions. fixes #0004534 2021-01-30 16:00:48 +01:00
Benjamin Nauck
37952a5949 Spreadsheet: Add test for undo alias issue 2021-01-30 14:04:57 +01:00
Benjamin Nauck
f4c2539765 Spreadsheet: Allow alias removed by undo to be reused
Fixes issue descripted in the forum post:
https://forum.freecadweb.org/viewtopic.php?f=3&t=54009
2021-01-30 14:04:57 +01:00
Kurt Kremitzki
497ecbe0eb Merge pull request #4134 from donovaly/PD-Hole-DrillPoint
[PD] improve blind hole depth handling
2021-01-30 05:14:52 -06:00
Benjamin Nauck
1f77dc2af8 [MeshPart] Fix copy-paste error
It doesn't make sense to check minLen and then call SetMinSize to maxLen
so this must be a copy-paste error.

Introduced in f681b86abd

Found with Coverity.
2021-01-30 11:47:06 +01:00
Kurt Kremitzki
046aa8a287 Merge branch 'master' into PD-Hole-DrillPoint 2021-01-29 19:02:34 -06:00
Chris Hennes
77d666a48b Fix DXF import with no layers
As discussed in https://forum.freecadweb.org/viewtopic.php?f=3&t=54842, if OpenSCAD creates a DXF with no layers in it, the code that is supposed to handle that in FreeCAD has a minor type error in it that prevents the import from working.
2021-01-29 17:01:22 -06:00
sliptonic
4db83a41ca Merge pull request #4325 from machste/fix_simple_copy
Path: Fix creating simple copy
2021-01-28 14:14:02 -06:00
Stefan Brüns
569817d87a Fix ODR violation, correct Ui_TaskSketcherGeneral namespace
The generated ui_TaskSketcherGeneral.h defines the class in the
SketcherGui namespace.

Fixes #4529
2021-01-28 17:43:10 +01:00
Zheng, Lei
1dddcd0b18 Part: fix ViewProviderExt::updateVisual() on incomplete mesh 2021-01-28 17:38:49 +01:00
vosk
4bd5c2669d [Part] - Fix memory leaks 2021-01-28 15:45:00 +01:00
Aapo
92846ad0f1 [TD] Avoid changing default open/save dir to templateDir when opening a Page template. 2021-01-28 14:54:59 +01:00
Yorik van Havre
0f3cdfea33 Merge pull request #4317 from Roy-043/fix_gui_snapper_center_face
[Draft] Fix snap to center of faces of solids
2021-01-28 14:36:15 +01:00
Yorik van Havre
8396c34d61 Merge pull request #4318 from bitacovir/Surface_WB_icons
[UI] Replace SVG icons for Surface WB commands
2021-01-28 14:33:45 +01:00
Yorik van Havre
09b4dbd8e8 Merge pull request #4320 from chennes/cleanStartWithLGTM
[Start] Minor tweaks recommended by LGTM
2021-01-28 14:31:28 +01:00
Stefan Mächler
fd2f2d83d0 Path: Fix creating simple copy
This commit fixes the issue discussed on the FreeCAD forum:

https://forum.freecadweb.org/viewtopic.php?f=15&t=54769
2021-01-28 09:32:17 +01:00
sliptonic
f70f9572fe Merge pull request #4297 from shadowbane1000/fanuc-1st-pass
[PATH] First pass at a post processor for Fanuc
2021-01-27 13:05:26 -06:00
sliptonic
ef2e209b14 Merge pull request #4140 from gauna85/PathStock
Path: Fix #3914: Adding stock label prefix to name comparison in orde…
2021-01-27 11:09:31 -06:00
sliptonic
9f5acaa2bb Merge pull request #4286 from kbickar/master
[Path] Fix AttributeError on deleting corrupt dressup
2021-01-27 11:04:40 -06:00
sliptonic
1596f1581f Merge pull request #4321 from ci4ic4/patch-1
[PATH] Update philips_post.py
2021-01-27 11:00:33 -06:00
sliptonic
4dd4783702 fix index bug in toolbit directory creation 2021-01-27 10:27:12 -06:00
sliptonic
2bd94ca7f3 Merge pull request #4294 from mlampert/feature/toolbit-free-properties
[Path] - Feature/toolbit free properties
2021-01-27 10:03:46 -06:00
ci4ic4
cbb0a8a11c Update philips_post.py
You can't compare dict with an integer.
2021-01-27 11:51:42 +00:00
Abdullah Tahiri
43aef8616d ViewProvider: make partial redundant color blue 2021-01-27 07:53:25 +01:00
Markus Lampert
0d9863849b Updated toolbit-attributes.py script and cleaned up shapes. 2021-01-26 20:04:46 -08:00
Markus Lampert
75e65dd09d Added support for deleting empty groups from the property bag's group tracking. 2021-01-26 19:46:06 -08:00
Chris Hennes
ba8e0aa863 Minor tweaks to Start recommended by LGTM
Using the results of the vulnerability scan at lgtm.com, some minor
changes were made. First, all Python exception handling now explicitly
catches Exception, rather than BaseException (which would include SystemExit
and KeyboardInterrupt). Second, unused imports were removed. Third, a
couple of unnecessary or unused assignments were addressed. Finally, the
JavaScript was modified to explicitly declare the local ddiv variable when
needed.
2021-01-26 20:38:51 -06:00
Markus Lampert
a4890e51f5 Disable library name edit 2021-01-26 18:17:09 -08:00
Markus Lampert
8d7543cc98 Add toolbit test files to list to maybe get windows build to pass 2021-01-26 18:14:09 -08:00
sliptonic
8d44fcdb06 fixed slitting saw shape and bit 2021-01-26 18:14:09 -08:00
sliptonic
86b5738433 tool bugs 2021-01-26 18:14:09 -08:00
sliptonic
231ad8f969 fix bug when declining the creation of workdir subdirectories. 2021-01-26 18:14:09 -08:00
Markus Lampert
571be1faf2 Added commit to explain the purpose of dumping the directory tree 2021-01-26 18:14:09 -08:00
Markus Lampert
26ba120aaf Added Tools directory for recursive test file copy 2021-01-26 18:14:09 -08:00
Markus Lampert
4f0f9e78f1 Added test case to determine directory layout. 2021-01-26 18:14:09 -08:00
sliptonic
f26e631ab6 make initial path defaults slightly more intuitive 2021-01-26 18:14:09 -08:00