kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
39,895 Commits 41 Branches 6 Tags
d1625cd70381a97752d0b1819a67f0b788eb83c0
Commit Graph

39895 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hennes
d1625cd703 Merge pull request #18665 from AjinkyaDahale/sk-refactor-stage-2 
[Sketcher] Round 2 of refactors
 2025-01-17 10:41:52 -06:00
Roy-043
25570d60f3 Merge pull request #19089 from Roy-043/Draft-Clone-avoid-B-spline-faces-in-more-cases 
Draft: Clone: avoid B-spline faces in more cases
 2025-01-16 19:57:08 +01:00
Roy-043
0e1af6f076 Merge pull request #19067 from Roy-043/Draft-Save-fillet-settings 
Draft: Save fillet settings
 2025-01-16 19:52:31 +01:00
Roy-043
31d8120d2e Draft: Clone: avoid B-spline faces in more cases 
B-spline faces can be avoided if the absolute values of the scaling factors are the same. The `transformShape` method can handle this if two additional arguments are provided.
 2025-01-16 13:39:11 +01:00
Roy-043
225241e673 Clean up 
The recompute and the `try` structure are no longer required.
 2025-01-16 11:53:55 +01:00
Roy-043
88a6eecdbb BIM: ArchWall use moveGeometry to move sketch point 
The movePoint function is no longer available in V1.1.
 2025-01-16 11:53:55 +01:00
Ajinkya Dahale
af9b577621 [Sketcher] Refactor and fix an issue in transferConstraints 2025-01-16 15:56:22 +05:30
Ajinkya Dahale
60b610c8dc [Sketcher] Fix issues in knot operations 
For some reason this is not caught in the tests.
 2025-01-16 15:56:22 +05:30
Ajinkya Dahale
e5eda8e437 [Sketcher] Make replaceGeometries protected 
This should be a `protected` or `private` operation since it doesn't handle
constraints. However, this is intended to be used by external classes that
modify a `SketchObject` (instead of these modifications like `split`, `trim`,
`join` etc. being methods of `SketchObject`). In that case, it may be best to
use the `friend` keyword.
 2025-01-16 15:56:22 +05:30
Ajinkya Dahale
edbe6a54d7 [Sketcher] Fix "used" B-spline poles being deleted 2025-01-16 15:56:22 +05:30
Ajinkya Dahale
d06349e3ac [Sketcher][test] Add new test for internal geometry deletion 
...when some are "used"
 2025-01-16 15:56:21 +05:30
Ajinkya Dahale
8bc51aa5ee [Sketcher] Incorporate review of #18665 by kadet 
1. Replace `find_if` with `any_of` when the iterator is not used.
2. Use PascalCase for templated class.
 2025-01-16 15:56:19 +05:30
Ajinkya Dahale
e71b25d942 [Sketcher] Refactor SketchObject::split 
1. Now uses `Part::Geometry::createArc`.
2. Removed type-specific codes. It can be generalized now.
 2025-01-16 15:55:14 +05:30
Ajinkya Dahale
a04b30deda [Sketcher] Further refactor modifyBSplineKnotMultiplicity 2025-01-16 15:55:14 +05:30
Ajinkya Dahale
8b6d5728e7 [Sketcher] Incorporate review of #18665 
...by hyarion on December 29.
 2025-01-16 15:55:14 +05:30
Ajinkya Dahale
0c2e621141 [Sketcher] Fix some issues in trim 
Fixes fails at cases where one (or both) of the remaining segments is (are)
degenerate. This existed pre-refactor.

Fixes cases where there are some constraints on internal geometry that do not
get deleted cleanly.

Also fixes a memory leak.
 2025-01-16 15:55:14 +05:30
Ajinkya Dahale
e38e3f17d1 [Sketcher] Refactor SketchObject::trim 
Cognitive complexity down to 57.
 2025-01-16 15:55:14 +05:30
Ajinkya Dahale
8cb30c3c53 [Sketcher] Refactor SketchObject::modifyBSplineKnotMultiplicity 2025-01-16 15:55:14 +05:30
Ajinkya Dahale
da71365ff3 [Sketcher] Refactor SketchObject::insertBSplineKnot() 2025-01-16 15:55:14 +05:30
Ajinkya Dahale
10f4fb866e [Sketcher][test] Add tests for B-spline operations 2025-01-16 15:55:14 +05:30
Ajinkya Dahale
6b5bc1f277 [Sketcher] Refactor SketchObject::trim() 
1. Use `Part::GeomCurve::createArc()`
2. Refactor constraint logic in `trim`
 2025-01-16 15:55:14 +05:30
Ajinkya Dahale
6df0b167e3 [Sketcher] Refactor internal geometry operations 
* Use range-for and rearrange for understandability.
* Break down into individual functions by geomtype.
* Also refactor `exposeInternalGeometryForType<Part::GeomBSplineCurve>`
* Use `Constraint::involves...()` in delete internal

Suppress clang-tidy/clazy warnings by using `[[maybe_unused]]`.

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2025-01-16 15:54:47 +05:30
Ajinkya Dahale
6e48d338b7 [Sketcher][test] Tests for expose/delete internal geometry 2025-01-16 15:52:03 +05:30
Ajinkya Dahale
a25c897343 [planegcs] Refactor pointer vector freeing 
Remove the type-checks in `free(std::vector<Constraint*>& constrvec)` as well as
checks for `nullptr` before deleting.
 2025-01-16 15:52:03 +05:30
Ajinkya Dahale
e0b4d95482 [planegcs] Refactor conditions & loops in GCS.cpp for readability 2025-01-16 15:52:03 +05:30
Ajinkya Dahale
e4a9baf9cf [planegcs] Refactor identifyConflictingRedundantConstraints() 2025-01-16 15:52:03 +05:30
Ajinkya Dahale
d71c3be2b1 [planegcs] Refactor GCS::System::initSolution() 2025-01-16 15:52:02 +05:30
Ajinkya Dahale
ff10a6db36 [Sketcher] Helper functions for deleting geometry 
Some tests probably needed
 2025-01-16 15:52:02 +05:30
Ajinkya Dahale
a4f74f6d97 [Sketcher] Write SketchObject::replaceGeometries() 2025-01-16 15:52:02 +05:30
Ajinkya Dahale
2422566faa [Sketcher] Refactor SketchObject::join() (expected trivial) 
No tests are added since this commit only adjusts if-then statements.
 2025-01-16 15:52:02 +05:30
Ajinkya Dahale
c9fc8270aa [Sketcher] Some trivial for loop changes in SketchObject 
No tests added since this should be no more different than existing code.
 2025-01-16 15:52:02 +05:30
Ajinkya Dahale
bb11cb52f5 [Sketcher][test] Create test for getConstraintAfterDeletingGeo+ 
[Sketcher] Add null case to constraint change on deletion checks
 2025-01-16 15:52:02 +05:30
Tim
4477e644dc Addon Manager: Improve proxy URL parsing & enhanced the error messaging (#19078) 2025-01-15 13:39:04 -06:00
Boots
e87459904e File export: generate a default filename if the selected object chang… (#18907) 
* File export: generate a default filename if the selected object changed since the last export

* Renamed variable to be more clear as per PR review feedback
 2025-01-14 16:20:09 -06:00
Chris Hennes
8c3bb779fb Merge pull request #19019 from hyarion/refactor/countObjectsOfType 
Refactor countObjectsOfType in selection and document
 2025-01-14 16:05:12 -06:00
tritao
b064827bea CMake: Issue a non-fatal error when module dependency is not found. 2025-01-14 15:45:21 -06:00
tritao
a2e9b52726 Gui: Bind NavigationStyle to Python. 2025-01-14 15:11:09 -06:00
Roy-043
499bd12d13 Draft: Save fillet settings 
Fixes #16248.
 2025-01-14 21:48:16 +01:00
Chris Hennes
46b9bcffef Merge pull request #19024 from hyarion/fix-macro-execute-window 
Fix missing user macros in macro execute window
 2025-01-14 13:50:17 -06:00
tritao
f75263cd19 Gui: Rename View3DInventorPy::getView3DIventorPtr() due to typo. 2025-01-14 13:37:33 -06:00
wmayer
28dcc54f0b Fix several compiler warnings 2025-01-14 13:34:18 -06:00
mosfet80
4fb4ceee4d Update sub_buildPixi.yml 2025-01-14 08:43:08 -06:00
Benjamin Nauck
9acb8a48ab Make old type countObjectsOfType functions protected 2025-01-14 14:23:46 +01:00
Benjamin Nauck
085c5e67cd Modernizing countObjectsOfType functions 2025-01-14 14:23:46 +01:00
Benjamin Nauck
08fe94ef25 Add template based Document::countObjectsOfType 
Also convert code to use this new method
 2025-01-14 14:23:46 +01:00
Yorik van Havre
42f3af4d6a BIM: Fixed late global declaration - fixes #19049 2025-01-14 13:32:23 +01:00
tritao
e1d4743a5b BIM: Only import TechDraw when its actually needed. 
Allows FreeCAD BIM module to load without TechDraw module compiled.
 2025-01-14 11:14:16 +01:00
Chris Hennes
0e3ac7462f MSVC: Add missing PreCompiled.h includes 2025-01-14 09:28:47 +01:00
João Matos
23a05bb250 Gui: Scene inspector improvements (#18781) 
* Improve naming for root scene graph switch/separator nodes.

* Improve scene graph inspector.

This commit improves the scene graph inspector by improving the UI
layout and displaying information in a more human-readable way.

Instead of having a main generic string column for all node-specific
data, introduce specific columns for node name, memory address and data.

Better visualization was also added for `SoDrawStyle`, `SoPickStyle`
and `SoCoordinate3` node types.
 2025-01-13 21:38:41 -06:00
Yorik van Havre
0213b4fc6c Translations (#18923) 
* Updated ts files

* Merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2025-01-13 21:30:30 -06:00