Commit Graph

25004 Commits

Author SHA1 Message Date
carlopav
d2d570f875 Draft: Edit, moved resetTrackers for context menu actions to main module
The wrapper allows to call resetTrackers in the main module after the callback to the GuiTools is executed.

This is the last commit, many thanks to @matthijskooijman for having menthored me :)

I think it's helpful to have @matthijskooijman explanation on this use of the wrapper:

This defines a new wrapper function, that calls the original callback and then calls resetTrackers. Note that this creates a new function for every loop iteration, so each of these wrapper functions captures potentially different callback, self and obj values so things work as expected. Note I did something weird with the callback value there: Since functions like these capture a variable, not its value at the time of function definition, and loop variables like label and callback are a single variable shared between all loop iterations, capturing callback directly ends up with all wrappers calling the last callback (i.e. they all capture the same variable and by the time the wrappers are called, that variable will contain the last of the callbacks). This is commonly solved by using a default value in the function definition, since such a default value uses the value of the (in this case) callback variable, not capturing the variable.
2021-06-01 23:20:41 +02:00
carlopav
4db4d1c34f Draft: Edit, Added reverse wire option to context menu
Now Draft Edit can reverse the order of the points of a Draft_Wire
2021-06-01 22:53:24 +02:00
carlopav
d3b524704f Draft: Edit, rewriting context menu system
get_edit_point_context_menu(self, edit_command, obj, node_idx)
get_edit_obj_context_menu(self, edit_command, obj, position)
that are called depending if the user is over an editpoint or over another part of the object.
2021-06-01 22:53:01 +02:00
carlopav
50a596f687 Draft: Edit, Split out addPoint in multiple methods in the GuiTools
Now Draft_Wire, Draft_BSpline, Draft_Bezcurve have their own methods to add points.
2021-06-01 21:57:38 +02:00
carlopav
2e36f8a832 Draft: Edit, change startEditing method to accept (obj, node_idx)
This enable to start editing also without an user click event, by just calling the method and specifying the object and the edit point index.
It is used for alternative edit mode (alt_edit_mode) by arc context menu
2021-06-01 21:47:37 +02:00
carlopav
aa7dddeecc Draft: Edit, Remove all the empty pass functions
Remove unused functions. Since GuiTools objects inherit from the GuiTools class, they do not need those placeholders.
2021-06-01 21:47:37 +02:00
sliptonic
4050f3ff69 Merge pull request #4826 from sliptonic/master
Path cleanup PathGuiInit
2021-06-01 13:19:10 -05:00
sliptonic
3a1c0c6076 Path cleanup PathGuiInit 2021-06-01 13:15:59 -05:00
sliptonic
35f64d5334 Merge pull request #4825 from FreeCAD/revert-4817-fix/camotics_import
Revert "[Path] Handle unavailability of Camotics library/module"
2021-06-01 12:56:23 -05:00
sliptonic
8f16d82272 Revert "[Path] Handle unavailability of Camotics library/module" 2021-06-01 12:55:48 -05:00
Yorik van Havre
b51e321011 Merge pull request #4822 from marioalexis84/draft-fillet
Draft: Add shortcut to fillet command
2021-06-01 17:01:53 +02:00
Yorik van Havre
e2dd61119c Draft: Added ExclusionPoints property to shape2dview object 2021-06-01 11:30:04 +02:00
donovaly
135d809dfb [Sketch] fix too long tooltips
- they were too long for smaller screens
- the other UI file changes were automatically make by Qt Designer
2021-06-01 08:12:52 +02:00
sliptonic
679bf1024c Merge pull request #4821 from FreeCAD/revert-4672-feature/camotics2
Revert "[PATH]  CAMotics simulation.  First Draft"
2021-05-31 16:30:28 -05:00
marioalexis
86d5cd0cfe Draft: Add shortcut to fillet command 2021-05-31 16:18:36 -03:00
sliptonic
17b18f20d6 Revert "[PATH] CAMotics simulation. First Draft" 2021-05-31 12:49:25 -05:00
Yorik van Havre
8ca7be83c8 Merge pull request #4820 from Roy-043/Draft_Fix_make_text
Draft: make_text fixed 3 small issues
2021-05-31 19:44:13 +02:00
Yorik van Havre
84b270b3c2 OpenSCAD: Fixed typo 2021-05-31 14:54:48 +02:00
Yorik van Havre
74a46e6b95 Arch: Added arrow and bar bubble modes to Arch Axis object 2021-05-31 14:14:46 +02:00
Yorik van Havre
9800f22292 Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-05-31 10:54:49 +02:00
Roy-043
5f77a5df89 Draft: make_text fixed 3 small issues
Fixed 3 small issues in make_text that came up while working on make_label (pull request #4801).
2021-05-30 19:53:02 +02:00
sliptonic
be1d1238a0 Merge pull request #4819 from sliptonic/bug/postcancel
[path] fix minor bug when cancelling post process
2021-05-30 10:51:28 -05:00
sliptonic
c307b0ce7e fix cancel bug 2021-05-30 10:49:16 -05:00
sliptonic
6b200846f1 Merge pull request #4817 from Russ4262/fix/camotics_import
[Path] Handle unavailability of Camotics library/module
2021-05-30 10:44:47 -05:00
Russell Johnson
7373c4dfa8 Path: Handle unavailability of Camotics library/module 2021-05-29 13:52:00 -05:00
Russell Johnson
c2cfba638f Path: Alphabetize import list and remove comments therein 2021-05-29 13:50:06 -05:00
sliptonic
06e7c75939 Merge pull request #4673 from sliptonic/bug/proxyerror
[PATH]  Fix proxy error bug that occurs when postprocessing
2021-05-28 13:04:44 -05:00
sliptonic
21a830a816 removed PathUtils import from all post-processors to avoid the deleted proxy error
I removed or commented out code using this import.  In all cases,
the import was used to get descriptive information from the Job
2021-05-28 13:04:16 -05:00
sliptonic
abe36a088d Merge pull request #4672 from sliptonic/feature/camotics2
[PATH]  CAMotics simulation.  First Draft
2021-05-28 13:03:13 -05:00
sliptonic
3f17e4cedd Merge pull request #4812 from jimzim111/patharray_multibase
Path: PathArray based on multiple bases, and choice of direction
2021-05-28 10:38:55 -05:00
sliptonic
aae0392d2e add missing reference in cmakelists 2021-05-28 10:29:06 -05:00
sliptonic
3f9ca68c5e Initial Commit 2021-05-28 10:25:46 -05:00
Yorik van Havre
077a4868bf Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-05-28 14:11:51 +02:00
Yorik van Havre
2ee8e4fdbb Merge pull request #4801 from Roy-043/draft_make_label_text_input
Draft: Fixed make_label to accept list of strings for custom_text
2021-05-28 13:46:10 +02:00
Yorik van Havre
2a630e531d Merge pull request #4814 from Syres916/patch-18
[Material] Change Graphite File encoding to UTF-8
2021-05-28 13:40:26 +02:00
sliptonic
a1aa7e1c64 Merge pull request #4798 from Russ4262/refactor/remove_rotation
[Path] Remove rotational code from Path modules
2021-05-27 13:47:12 -05:00
Russell Johnson
03cce806f3 Path: Remove first-draft rotational code Path
Remove all first-draft rotational-related code from Path workbench to make way for more stable, long-term integration of a rotational indexing capability.
2021-05-27 10:04:31 -05:00
Yorik van Havre
dd1220b345 Merged crowdin translations 2021-05-27 14:51:33 +02:00
Yorik van Havre
4b7a5d2e98 Updated translation files 2021-05-27 14:44:40 +02:00
Roy-043
5121104a46 Merge branch 'master' into draft_make_label_text_input 2021-05-26 16:23:22 +02:00
jim
e4d706e985 Merge branch 'patharray_multibase' of https://github.com/jimzim111/FreeCAD into patharray_multibase 2021-05-25 18:37:05 -07:00
jim
631e166472 fix whitespace 2021-05-25 18:36:51 -07:00
jimzim111
a68d4fe227 Merge branch 'master' into patharray_multibase 2021-05-25 18:34:49 -07:00
jim
a62e015427 Clean up logic that tests whether there any base Paths to process 2021-05-25 18:34:19 -07:00
jim
592dba1610 Hide ToolController property. TC can be chosen by the first operation in the PathArray Base property. 2021-05-25 18:24:50 -07:00
jim
837f2c00f3 Wrap strings in QT_TRANSLATE_NOOP 2021-05-25 18:11:15 -07:00
Syres916
9f9520adef [Material] Change File encoding to UTF-8
See discussion https://forum.freecadweb.org/viewtopic.php?f=3&t=58892
2021-05-25 15:02:22 +01:00
Yorik van Havre
3ec5b13194 Merge pull request #4802 from meapeteze/TD_Spreadsheet_merged_cells
TechDraw: Fix View Spreadsheet with merged cells.
2021-05-25 15:09:51 +02:00
Yorik van Havre
997df8c152 Merge branch 'master' into TD_Spreadsheet_merged_cells 2021-05-25 15:09:42 +02:00
Yorik van Havre
262bb4fc19 Merge pull request #4806 from meapeteze/TD_Spreadsheet_merged_cells_optimal
Fix TechDraw View Spreadsheet with merged cells, 2
2021-05-25 15:07:54 +02:00