Commit Graph

24857 Commits

Author SHA1 Message Date
Yorik van Havre
da97cddb14 Merge pull request #4780 from matthijskooijman/fix-flat-groups-section-view
Arch: Fix section view duplicate rendering of items in groups with only flat objects
2021-05-11 12:13:09 +02:00
Yorik van Havre
d66bfb680b Merge pull request #4782 from heewa/fix-startpage-dir-bug
Start: fix bug when custom folder doesn't exist
2021-05-11 12:10:59 +02:00
Yorik van Havre
d8c488e3c8 Merge pull request #4783 from donovaly/Addon-SVG-fix
[Addons] fix an icon
2021-05-11 12:09:50 +02:00
donovaly
ff2a8c23da [Addons] fix an icon
I got a warning from Git that the SVG has a missing linebreak at the end. Fixed by saving the file as plain SVG using Inkscape
2021-05-11 02:11:10 +02:00
Heewa Barfchin
0b1daf7fba Start: fix bug when custom dir missing 2021-05-10 13:24:17 -04:00
kinagaki
ef1b509e91 Addon Manager: Added FEM_FrontISTR Workbench icon 2021-05-10 00:55:35 +02:00
Bernd Hahnebach
778479c2cd FEM: pep8 2021-05-09 23:42:32 +02:00
Matthijs Kooijman
ffbac23432 Draft: Improve docs for get_group_contents spaces parameter
The documentation suggested subtly different semantics from what the
code implements.
2021-05-09 17:33:46 +02:00
Matthijs Kooijman
2a60d81c7d Arch: Do not draw draft-like groups twice in section view
When drawing a section view, first a list of objects to draw is made.
Starting with the objects selected by the section plane, any groups or
group-like objects are recursively expanded. The resulting list contains
all contained objects, but also the expanded groups themselves (due to
Draft.get_group_contents with addgroups set).

This list of objects is then further categorized and processed. In this
categorization, there was already an exception for DocumentObjectGroup
instances, which were omitted from the resulting `nonspaces` list
(presumably since there is no point in drawing the groups themselves
when their contents are already in the list).

However, any groups that only contain flat objects would be caught by
`looksLikeDraf()` and added to the `drafts` list, before this exception
could ignore them.

This causes these groups to be processed by Draft.get_svg, which does so
by calling itself recursively on the group contents. Effectively, this
means that the contents of such groups is drawn on the section view
twice. Even more, since Draft.get_svg does not do a visibility check
like Arch.getSVG does, this causes invisible objects to show up when not
intended.

This commit fixes this by moving the DocumentObjectGroup exception a bit
further up, so all these objects should be dropped.

An alternative fix might be to pass addgroups=False to
Draft.get_group_contents (in getSectionData), but that also prevents
group-like objects (Building, BuildingPart, Space, Site) from being
returned, but those likely need to be returned so they can be sectioned
if needed (though if just spaces are needed, then
Draft.get_group_contents also have a spaces argument to return just
those).
2021-05-09 17:19:05 +02:00
wmayer
aba9ef731c Make smesh compile with vtk9 2021-05-09 10:53:13 +02:00
Bernd Waibel
97a9571892 [Fem] fix femtest failure with yaml.load
Solves an issue with using an outdated call to yaml.load
as described in
https://forum.freecadweb.org/viewtopic.php?f=10&t=57617

Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
2021-05-06 19:52:20 +02:00
UR-0
38adcc0a24 [FEM] patch LGTM alerts 2021-05-06 19:51:27 +02:00
Yorik van Havre
6e9c157cd5 Draft: Fixed last commit (stroke endcap -> stroke-linecap) 2021-05-06 18:49:55 +02:00
Yorik van Havre
e37e8eddfb Draft: Using square endcaps for lines in SVG output 2021-05-06 18:38:32 +02:00
Yorik van Havre
5705bb8aa8 Arch: Small translation fix 2021-05-06 18:37:40 +02:00
Yorik van Havre
dd3f723465 Draft: Added load/save functionality to SetStyle dialog 2021-05-06 18:36:41 +02:00
Yorik van Havre
a0dea60f71 Added OpeningDesign to contributors list 2021-05-06 13:14:12 +02:00
Yorik van Havre
966906da96 Merge pull request #4557 from luzpaz/crowdin/whitespaces-substituted-into-code
Crowdin: represent whitespace in code instead of in string
2021-05-05 17:18:35 +02:00
Yorik van Havre
4ff9b768dd Draft: Changed shapestring FillLetters property to MakeFace 2021-05-05 15:41:28 +02:00
Yorik van Havre
fe92e39e8a Merge pull request #4769 from Roy-043/Draft_make_ellipse
Draft: Fixed make_ellipse.py: the face argument was not used
2021-05-05 15:31:13 +02:00
Yorik van Havre
308d292bb9 Merge pull request #4768 from Roy-043/Draft-Gui-addModule-issue
Draft: Fixed 3 gui_*.py files that did not execute Gui.addModule("Draft") if UsePartPrimitives is True
2021-05-05 14:11:33 +02:00
Yorik van Havre
2a72f30531 Merge pull request #4775 from amrit3701/arch/rebar-allow_negative_offset
[Arch]: allow Rebar OffsetStart and OffsetEnd in negative also
2021-05-03 22:08:02 +02:00
Amritpal Singh
feb8746563 Arch: allow Rebar OffsetStart and OffsetEnd in negative also 2021-05-03 23:06:05 +05:30
wmayer
a6e7bdf849 allow to enable PCH for gcc and clang 2021-05-03 17:37:58 +02:00
Yorik van Havre
a5bab10ff7 Draft: Added a 'solid faces' projection mode to shape2dviews to treat individual faces 2021-04-30 16:44:20 +02:00
Roy-043
86f3c4021a Update make_ellipse.py
Draft: Fixed make_ellipse.py: the face argument was not used and therefore "filled mode" did not work in the GUI.
2021-04-29 21:23:26 +02:00
Roy-043
e13bf0fac7 Update gui_points.py
Gui.addModule("Draft") should be executed before committing _cmd_list irrespective of the UsePartPrimitives setting.
2021-04-29 21:07:07 +02:00
Roy-043
a3778eacd4 Update gui_arcs.py
Gui.addModule("Draft") should be executed before committing _cmd_list irrespective of the UsePartPrimitives setting.
2021-04-29 21:05:52 +02:00
Roy-043
7fa3869116 Update gui_ellipses.py
Gui.addModule("Draft") should be executed before committing _cmd_list irrespective of the UsePartPrimitives setting.
2021-04-29 21:03:44 +02:00
Yorik van Havre
e605b2f930 Draft: Allow to set 'arch' unit override on dimensions 2021-04-29 19:51:34 +02:00
Yorik van Havre
117ec1b918 Merge pull request #4766 from waebbl/module-test-issue
[Test] fix failing test in Test module
2021-04-29 12:47:15 +02:00
Yorik van Havre
e66b51946b Merge pull request #4688 from marioalexis84/draft-feature_name
Draft: Make featureName attribute translation-independent
2021-04-29 12:40:38 +02:00
Yorik van Havre
c0c49ebffc Merge branch 'master' into draft-feature_name 2021-04-29 12:40:27 +02:00
Bernd Waibel
203d408429 [Test] fix failing test
Solves an issue with the test module when running test-suite
as described in
https://forum.freecadweb.org/viewtopic.php?f=10&t=58099

Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
2021-04-28 22:09:55 +02:00
Yorik van Havre
d5393bb1e1 Merge pull request #4764 from KeithSloan/addElement
OpenSCAD - Add element ( Load | Save | Refresh )
2021-04-28 12:37:45 +02:00
wmayer
545d055766 Gui: [skip ci] fix crash in SequencerBar::setProgress or SequencerDialog::setProgress when used in worker threads 2021-04-28 12:02:52 +02:00
wmayer
0909fa76aa Base: allow to use the classes XUTF8Str and StrXUTF8 outside FreeCADBase 2021-04-28 10:56:17 +02:00
luz paz
63cd79538e Misc: remove py2 code 2021-04-27 18:52:01 +02:00
Keith Sloan
985cbad2fa Add Load/Save/Refresh to add OpenSCAD Elements 2021-04-27 17:42:06 +01:00
wmayer
56c92d1198 Fix generation and build of python classes for 3.8 2021-04-27 14:35:34 +02:00
wmayer
f439e62639 Path: [skip ci] fix memory leaks 2021-04-27 14:32:35 +02:00
wmayer
0e7d9171db Path: [skip ci] fix memory leaks 2021-04-27 13:02:57 +02:00
markus
d6fa0b1d18 Fix generation and build of python classes for 3.9 2021-04-27 00:41:53 +02:00
wmayer
0ff70c61ed Sketcher: [skip ci] fix memory leak in GeometryFacade 2021-04-27 00:20:57 +02:00
wmayer
5e2abd4f80 Sketcher: [skip ci] remove superfluous semicolons 2021-04-26 23:05:18 +02:00
wmayer
3347c5e632 Base: [skip ci] do not make PyBaseProxy class declaration dependent on ATTR_TRACKING 2021-04-26 15:57:17 +02:00
Yorik van Havre
3a3fe0c778 Added KiCAD Corp to the credits 2021-04-26 12:55:57 +02:00
wmayer
01d621406f Sketcher: [skip ci] fix memory leak in GeometryFacadePy 2021-04-26 12:30:02 +02:00
wmayer
8371162427 Base: remove obsolete swig source files 2021-04-26 11:20:13 +02:00
wmayer
58f72ccc80 Part: remove some more deprecated Py2 code 2021-04-26 11:13:22 +02:00