Commit Graph

31593 Commits

Author SHA1 Message Date
Chris Hennes
dc14285a4f CI: Don't encourage docstring on trivial functions
If a function is three or fewer lines long, it should be assumed to be self-explanatory (hopefully it has a good name!).
2023-01-13 14:06:03 -06:00
wmayer
7ccee344c7 Sketcher: move to new style connect() 2023-01-13 20:17:53 +01:00
wmayer
3818dec66a Spreadsheet: move to new style connect() 2023-01-13 20:02:46 +01:00
Chris Hennes
d6b3efc7a8 Addon Manager: Fix GUI unit tests
Eliminate all calls to terminate() when dealing with QThread.
2023-01-13 12:13:17 -06:00
Chris Hennes
b933d46dcd Addon Manager: Set parent for most modals 2023-01-13 12:13:17 -06:00
wandererfan
e1dc7bd94b [TD]reset sceneRect on Template change 2023-01-13 12:15:33 -05:00
wandererfan
271e3c6b8a [TD]Allow balloons to be attached to non-part views 2023-01-13 12:15:33 -05:00
wandererfan
12db3618df [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
wmayer
b57e5646f6 Part: move to new style connect() 2023-01-13 17:14:07 +01:00
wmayer
880d05cf3c Mesh: move to new style connect() 2023-01-13 16:30:58 +01:00
wmayer
7d65afdf59 Image: move to new style connect() 2023-01-13 16:03:16 +01:00
wmayer
2ff9ff02d7 Import: move to new style connect() 2023-01-13 15:58:56 +01:00
wmayer
70061abf77 Inspection: move to new style connect() 2023-01-13 15:57:18 +01:00
wmayer
a621ad81f4 Robot: move to new style connect() 2023-01-13 15:46:45 +01:00
wmayer
9b5505fb34 Surface: move to new style connect() 2023-01-13 15:21:37 +01:00
wmayer
507a1f82bc Web: move to new style connect() 2023-01-13 15:14:29 +01:00
Ajinkya Dahale
e47147ea37 [Sketcher] Prevent dereferencing nullptr in ConstraintView
Fixes #8104.

As described in that issue, a crash happens under the following
conditions:
1. A `DrawSketchHandler` is active.
2. No constraint is selected.
3. Context menu on the `ConstraintView` is triggered.
2023-01-13 15:06:39 +01:00
wmayer
8466b68400 Arch: [skip ci] fix typos 2023-01-13 13:30:59 +01:00
Yorik van Havre
ca4d093f4c Merge pull request #8122 from Roy-043/Arch-improve-context-menus
Arch: improve context menus
2023-01-13 11:48:57 +01:00
Yorik van Havre
e49d30a327 Merge pull request #8081 from Roy-043/Draft-Fix-inconsistent-properties-of-Draft-annotations
Draft: Fix inconsistent properties of Draft annotations
2023-01-13 11:47:00 +01:00
Yorik van Havre
a653108bba [Draft] Add Units Selector to Status Bar 2023-01-13 11:41:55 +01:00
Roy-043
117b53d6ea Arch: improve context menus (rebase 2) 2023-01-12 23:10:43 +01:00
Roy-043
42a74daa19 Arch: improve context menus (rebase) 2023-01-12 22:54:09 +01:00
Roy-043
3388854cbc Arch: ArchSectionPlane should update SVG in execute (#8175) 2023-01-12 20:23:54 +01:00
wmayer
ac81fad372 Gui: refactor TreeWidget::dropEvent 2023-01-12 19:40:59 +01:00
wmayer
5b1c781b8d Gui: [skip ci] fix some warnings reported by GH actions 2023-01-12 17:51:50 +01:00
wmayer
ac94fb4a33 Gui: move to new style connect() 2023-01-12 17:40:20 +01:00
0penBrain
ee00271d83 AddonMgr: switch pref entry/path to const string 2023-01-12 09:24:03 -07:00
wmayer
103de43a4e Gui: fix possible problems with new style connect
* In UIntSpinBox rename the signal to not overwrite the signal of the base class
* In UIntSpinBox use the (ambiguous) signal 'valueChanged' of the base class QSpinBox
* To avoid that connect() fails use the function pointer of the Qt class where the signal is defined
2023-01-12 17:02:59 +01:00
Roy-043
19d624396f Draft: housekeeping: indentation gui_snapper.py
As mentioned here: #8172
2023-01-12 16:04:31 +01:00
Roy-043
dec88420bf Draft: Properly remove Snap toolbar when switching workbenches (#8172) 2023-01-12 15:29:21 +01:00
Roy-043
d9144213c2 Arch: fix ArchSectionPlane getSceneGraph problem (#8171) 2023-01-12 15:28:00 +01:00
Uwe
ed995b5a15 [Gui] modernize some connect() settings
- addresses #6166
2023-01-12 15:13:16 +01:00
luzpaz
92398f94e3 Spreadsheet: [skip ci] convert tabs to spaces
Minor housekeeping fix
2023-01-12 14:08:33 +01:00
Roy-043
69efdc016f Draft: improve wires.isReallyClosed (#8167) 2023-01-12 10:25:48 +01:00
Roy-043
fb1ed8f5e4 Draft: improve offsets.offsetWire (#8166) 2023-01-12 10:25:11 +01:00
Uwe
4091db4739 [skip ci] [Gui] ExpressionCompleter: fix a typo
- found by the CI
2023-01-12 04:20:40 +01:00
wmayer
079bdc64b1 Gui: change custom message handler to show Qt warnings and errors also in Release mode 2023-01-11 17:48:13 +01:00
wmayer
28c757bc12 Gui: [skip ci] print warning in getViewProviderByPath, getViewProviderByPathFromTail, getViewProvidersOfType if for View3DInventorViewer no document is set
This gives the client programmer a clue if one of the mentioned methods fails
2023-01-10 17:46:05 +01:00
wmayer
406034f3ca Gui: add method setDocumentOfViewers and set documents of viewers in constructor of SplitView3DInventor 2023-01-10 17:23:48 +01:00
sliptonic
5284d9c886 Merge pull request #8146 from sliptonic/bug/threadmilling
[Path] fix bug with threadmilling collision
2023-01-10 08:05:42 -06:00
Jakub Świerk
a334206ca7 Updated ts files 2023-01-10 13:46:33 +01:00
Jakub Świerk
09c00c5155 Gui: Removed unused method. 2023-01-10 13:46:33 +01:00
Jakub Świerk
d3300d1fc0 GUI: Removed Std_ArrangeIcons command. 2023-01-10 13:46:33 +01:00
luzpaz
2d6a768a6b README: update bugtracker related links and info
Link to github instead of mantis.  
Update links on how to submit bugs + feature requests  
Add link to CONTRIBUTING.md
2023-01-10 13:08:54 +01:00
Chris Hennes
8e38c47d7a Addon Manager: Fix bug in ZIP isntallation 2023-01-09 19:35:18 -06:00
sliptonic
eb4bf66425 Remove check for internal as well 2023-01-09 10:46:55 -06:00
sliptonic
297389acae Merge pull request #8145 from sliptonic/bug/7600
[Path] use correct widgets in task panel Fix #7600
2023-01-09 10:28:50 -06:00
Abdullah Tahiri
7fcee31c07 Part/Sketcher: Geometry/Geometry facade pass by const-reference instead of by value 2023-01-09 17:13:26 +01:00
Abdullah Tahiri
b7945b6a15 Sketcher: Do not mark as fully constrained sketches that do not converge
=======================================================================

In uncommon situations, the analysis of QR decomposition leads to full rank, but the result does not converge.

We avoid marking a sketch as fully constrained when no convergence is achieved.
2023-01-09 17:11:14 +01:00