Commit Graph

34872 Commits

Author SHA1 Message Date
Paddle
dc2da5aba1 Offset fix isActive function. 2023-11-04 08:58:50 +01:00
Paddle
b4a54abed5 Polygon DSH : Small syntax improvements. 2023-11-04 08:58:50 +01:00
Paddle
785ec817c8 Line DSH : syntax and remove potential issues. For example in width+length mode, if user input 0 and 0, instead of validating it will unset the spinboxes. Preventing creation of null lines. 2023-11-04 08:58:50 +01:00
Paddle
3242144128 Rectangle DSH : Fix a bug where 3p rectangle with radius, radius would not apply. Also fix various edge cases. Improve syntax. 2023-11-04 08:58:50 +01:00
Paddle
b72da63139 Offset DSH : Add pointer SVG. Some remove unecessary member initialization 2023-11-04 08:58:50 +01:00
Paddle
5fc39a5add DSDWC : typo 2023-11-04 08:58:50 +01:00
Paddle
aa4a158e0c Prevent passing the focus to a spinbox when it shouldn't.
In some DSH some mode (seekSecond for example) don't have onViewParameter. In this case it would wrongly try to give focus to the previous spinbox with focus.
2023-11-04 08:58:50 +01:00
Paddle
336691cd5a Redraw on construction method changed. Avoid a small issue where you had to move mouse first before being able to rechange the methode by the M key. 2023-11-04 08:58:50 +01:00
Paddle
8788bcc0f4 SketcherToolDefaultWidget : Add a blockParameterFocusPassing bool that let us set parameters without passing focus. To fix undue passing of focus when using shortcuts U/J. For example in Polygon. 2023-11-04 08:58:50 +01:00
wmayer
2645242bc7 Material: fix Python bindings
* fix reference counting of Python objects
* fix crashes in several methods
2023-11-03 16:41:11 +01:00
wmayer
6eb95ca73c Material: fix compiler warning with Qt6
QVariant::Type is deprecated since Qt 6.0 and shouldn't be used in new code
2023-11-03 16:41:11 +01:00
wmayer
b55aca0501 Material: fix compiler warnings
* unused parameter 'parent' [-Wunused-parameter]
* reference cannot be bound to dereferenced null pointer in well-defined C++ code; comparison may be assumed to always evaluate to false [-Wtautological-undefined-compare]
2023-11-03 16:41:11 +01:00
wmayer
d48ae99424 Material: fix 'explicitly defaulted copy constructor is implicitly deleted [-Wdefaulted-function-deleted]' 2023-11-03 16:41:11 +01:00
wmayer
015c84066d Material: single-argument constructors must be marked as explicit 2023-11-03 16:41:11 +01:00
wmayer
5accd11c62 Fem: remove re-inserted CMake definitions 2023-11-03 16:41:11 +01:00
wmayer
d8d6783152 Material: fix diagnostic errors with the clang code model 2023-11-03 16:41:11 +01:00
wmayer
2e017ac45a Material: remove several unreferenced variables 2023-11-03 16:41:11 +01:00
wmayer
0f31b1f29b Material: use get_filename_component() instead of cmake_path() to support older CMake versions 2023-11-03 16:41:11 +01:00
wmayer
7173463ae6 Material: QMetaType::type(const char*) is deprecatred and shouldn't be used in new code
And it looks like that QMetaType::type("Base::Quantity") neither works with Qt5 nor with Qt6 because it returns 0 as id that means the type is unknown.
2023-11-03 16:41:11 +01:00
wmayer
d99658b3da Material: fix build failure with Qt6
setCodec() has been removed from QTextStream
2023-11-03 16:41:11 +01:00
wmayer
54c4ee4b78 Material: fix -Winconsistent-missing-override 2023-11-03 16:41:11 +01:00
Paddle
aef013473b DrawSketchController and DrawSketchDefaultWidgetController : fix lint warnings 2023-11-03 14:02:25 +01:00
Paddle
a0609b1a28 Sketcher: Polygon DSH 2023-11-03 14:02:25 +01:00
Paddle
b65b1ff8de Sketcher: Offset DSH 2023-11-03 14:02:25 +01:00
Paddle
c9f6639810 Sketcher: Rectangle DSH 2023-11-03 14:02:25 +01:00
Paddle
6769166bf4 Sketcher: Line DSH 2023-11-03 14:02:25 +01:00
Paddle
c5de96fbd6 Sketcher: Point DSH 2023-11-03 14:02:25 +01:00
Paddle
3483090279 DSDH : add canGoToNextMode() methode in onButtonPressed. So that we can prevent going to the next mode on certain conditions. 2023-11-03 14:02:25 +01:00
Abdullah Tahiri
3f1f1047b2 Sketcher: Make GeometryConstructionMode an enum class
=====================================================

Enforce strong typing to avoid all kinds of abusive implicit conversionsm, the corresponding associated bugs and make code more readable.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
82fed5bbfc Sketcher: New flexible DSH Architecture
=======================================

Rewrite of the architecture to accomodate on-view parameters and to enable code reuse
between the default widget and custom widgets.
2023-11-03 14:02:25 +01:00
Paddle
a5b5d01c22 DSH architecture: On-view spinboxes 2023-11-03 14:02:25 +01:00
Abdullah Tahiri
677694b0ba Sketcher: New DSH architecture to support multiple input
========================================================

Architecture to support multiple input from a widget and a mouse.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
3ad624236b Sketcher: DrawSketchHandler - refactor functions to draw/clear edit curve and markers 2023-11-03 14:02:25 +01:00
bgbsww
8baf75af84 Fix #11032 flickering when switching to Part Design
* Remove unneeded timer on taskview updates to fix #11032

* Remove obsoleted class member
2023-11-02 16:32:32 +01:00
wmayer
bec1302fcf Part: refactor SectionCut 2023-11-02 08:17:06 +01:00
wmayer
25689aa9eb Part: fix crash in SectionCut 2023-11-02 08:17:06 +01:00
pavltom
862eef57eb [TechDraw] Checkable menu item for Turn View Frames On/Off - segfault fix 2023-11-01 13:55:38 -04:00
pavltom
0083799ac1 [TechDraw] - Checkable menu item for Turn View Frames On/Off 2023-11-01 13:55:38 -04:00
wmayer
d07441a0dd Part: refactor SectionCut::startCutting() 2023-11-01 16:58:35 +01:00
wmayer
474d5cc037 Part: refactor SectionCut::collectObjects() 2023-11-01 16:58:35 +01:00
wmayer
7f87b917e8 Part: fix manual formatting of SectionCut::setupConnections() 2023-11-01 16:58:35 +01:00
Chris Hennes
2c7638b7aa Merge pull request #11138 from davesrocketshop/material_editor_pr
Material: Material editor enhancements
2023-11-01 09:42:43 -05:00
Roy-043
e4d6c328fc Draft: clone IfcType and Subvolume properties
Fixes #11186.
2023-10-31 15:43:33 +01:00
Roy-043
951059d192 Arch: fix Placement multiplication for subvolumes
Fixes #11185.

Same problem as in #6617.
2023-10-31 15:42:46 +01:00
Roy-043
a2e85a4ae1 Draft: Updates related to the PlaneGui class (step 4)
Related issue:
#5603.

For gui_snapper.py and gui_trackers.py an intermediate solution has been adopted. They still rely on App.DraftWorkingPlane, but now use a small function to retreive it.

Simply switching to the PlaneGui class is problematic for the trackers as this results in an endless recursion (wp->grid->wp->...). Using the old App.DraftWorkingPlane (which is kept up-to-date by PlaneGui) solves this for now. I will try to return to this later (which may be after the next release though).
2023-10-31 15:41:21 +01:00
wandererfan
9a7163f533 [TD]fix 2 tidy warnings 2023-10-31 09:12:50 -04:00
Ed Williams
792af641db Base: set sys.last_vars to enable post mortem debugging after exception
* Update Interpreter.cpp to enable stack trace

This enables python debuggers to stack trace after an exception.
See https://forum.freecad.org/viewtopic.php?p=714349#p714349

Co-authored-by: bdieterm <119257544+bdieterm@users.noreply.github.com>
2023-10-31 09:40:57 +01:00
wmayer
a1ecc2b543 Part: refactor constructor of SectionCut 2023-10-30 14:36:18 +01:00
wmayer
85f45c9956 Part: refactor onFlipXclicked, onFlipYclicked and onFlipZclicked of SectionCut 2023-10-30 14:36:18 +01:00
wmayer
c3cd1a1191 Part: Fix Move enum to class with static members, fix & suppress some other lint warnnigs 2023-10-30 14:36:18 +01:00