Commit Graph

41710 Commits

Author SHA1 Message Date
Joao Matos
ddde5a9566 Fix warnings in ModelManagercode. 2025-05-15 01:02:55 +02:00
Chris Hennes
f5ab6295ba UI: Remove qPixmapFromMimeSource pixmap function
This function dates back to Qt3, and was removed in Qt4. Modern Qt no
longer uses this ui file entry, and in some circumstances the uic
complains about its presence.
2025-05-15 00:56:30 +02:00
Chris Hennes
3178e13f04 Materials: Clean up unused variables
Updated error messages no longer refer to the exception object, resulting in compiler warnings.
2025-05-15 00:29:19 +02:00
Chris Hennes
b36a21b721 Gui: Eliminate signed-to-unsigned comparison
`std::numeric_limits<int>::max()` can losslessly be cast to an unsigned
int to silence the compiler warning about comparison of signed to
unsigned.
2025-05-15 00:20:35 +02:00
FEA-eng
a20d562da4 FEM: Update TaskPostGlyph.ui 2025-05-15 00:06:43 +02:00
FEA-eng
5b7d5d0a85 FEM: Update post_glyphfilter.py 2025-05-15 00:06:43 +02:00
Pieter Hijma
e7f0418966 Fix finding hdf5 on CMake reconfigure 2025-05-14 13:49:09 -05:00
Benjamin Nauck
098faceb66 Merge pull request #21174 from 3x380V/fix_21172
Base: fix Unit scheme management regressions
2025-05-14 19:43:59 +02:00
dependabot[bot]
0257596391 Bump actions/dependency-review-action
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 8805179dc9a63c54224914839d370dd93bd37b2e to da24556b548a50705dd671f47852072ea4c105d9.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](8805179dc9...da24556b54)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-version: da24556b548a50705dd671f47852072ea4c105d9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-14 08:05:56 -05:00
Ladislav Michl
602880ed80 Base: revert to using ASCII chararacters for imperial lengths
The new unit schema management is using U+2032 and U+2033 characters
for feet and inches while parser is expecting only ' and ", while
U+2032 and U+2033 are used for arcminute and arcsecond.

While this is not an ideal solution and parser should deal with both,
revert back to ASCII for now.

Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-14 11:39:09 +02:00
Syres916
67d0345870 Base: fix default unit schema
Fix the transcription error which occured while moving into
single structure. Default schema now uses milimeters again.

Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-14 10:25:47 +02:00
Ladislav Michl
e577bebe56 Base: fix Python interface for Unit schema selection
Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-14 10:20:49 +02:00
Ladislav Michl
2e35afd6e0 Base: sort returned Unit schema description
Return schemas name and description vectors sorted by number, so
index can be used later to select particular schema.

Fixes: 1155f0d752 ("Base: simplify UnitsSchemas management")
2025-05-14 10:20:49 +02:00
3x380V
fc2a2cedbe App: Align Document to best practices (#21059)
* use static cast

* join declaration and definition

* don't hide previous declaration

* initialize in declaration

* redundant else

* reserved identifier

* endl

* implicit conversion

* narrowing

* always false

* replace define with constexpr

* return and continue

* avoid copy

* multiple declarations in line

* use auto

* member initialize

* uninitialized

* range based loop

* move to inner scope

* redundant

* const, mainly

* function parameter descriptions

* misc

---------

Co-authored-by: bofdahof <172177156+bofdahof@users.noreply.github.com>
2025-05-14 09:36:42 +02:00
FilippoR
670eeca2a9 fedora rpm packaging: use standard macro to package sources with submodules (#20953) 2025-05-13 22:03:28 -03:00
tritao
6517ebcdff Fix regressions in CI linting generic checks.
This got broken due to applying some review suggestions without proper
testing.

This fixes commit 5e72c0afe5.

Closes https://github.com/FreeCAD/FreeCAD/issues/21231.
2025-05-14 00:20:10 +02:00
marioalexis
58fb7d45c1 Fem: Add CalculiX writers for electrostatic constraints 2025-05-13 14:46:54 +02:00
marioalexis
06540e8563 Fem: Search elements for electrostatic constraints 2025-05-13 14:46:54 +02:00
marioalexis
30e75dc74a Fem: Improve CalculiXTools 2025-05-13 14:46:54 +02:00
marioalexis
0e0f956d6a Fem: Change CalculiX time and frequency properties to quantites 2025-05-13 14:46:54 +02:00
tetektoza
c91a0384de Draft: Finish command if user deselected Chained Mode
As the title says - currently, if user deselects Chained Mode, they
can't exit it without using ESC key for example, as the old behavior
of ContinueMode is kept under it.

So, this patch finishes the command if user has deselected it, at
the same time finishing previous chain.
2025-05-13 11:39:01 +02:00
Paul Lee
fec569f017 [ArchStairs] ArchSketch Support and Refactoring Phase 3 + Regression
Phase 2 Subsequent to #21025 + Regression Fix

FC Forum Discussion:-
https://forum.freecad.org/viewtopic.php?p=814274#p814274

ArchSketch Support, PropertySet, and Refactoring to enable more complex Stairs shape.
2025-05-13 11:31:09 +02:00
Paul Lee
9da5eae6f0 [BimWindow] Interactive Creation Tool: Check if SketchArch is Enabled (ArchSketchLock)
Improvement to User Interactive Experience:
- The Window Interactive Tool would check if SketchArch-addon is enabled by user, i.e. if ArchSketckLock is checked.
- If not, the conventional creation behaviour is used, SketchArch properties would not be added to Window object.
- It also check if Base of Wall is ArchSketch or not.

Github Discussion:
- https://github.com/paullee0/FreeCAD_SketchArch/issues/27#issuecomment-2837652351
2025-05-13 11:29:09 +02:00
tetektoza
01f3fcb343 BIM: Allow changing Sill parameter in Properties for Window
User has no possibility to change Sill parameter upon adding Window, it
is only possible while creating Window for the first time.

So this patch adds this parameter, and changing it moves the *BASE*
coordinate of the object in Z direction.
2025-05-13 11:25:31 +02:00
tetektoza
8002693157 BIM: Switch Visibility of ViewObj on/off to restore it in all objs 2025-05-13 11:03:05 +02:00
tetektoza
1fef7dff94 BIM: Do not hide children of Building if Building has been isolated 2025-05-13 11:03:05 +02:00
tetektoza
69ad218f5c BIM: Remove additional recompute at the end of isolate 2025-05-13 11:03:05 +02:00
tetektoza
b7718efd5c BIM: Exclude viewtree from cached items and add a sanity check 2025-05-13 11:03:05 +02:00
tetektoza
10d476a35b BIM: Cache the tree elements beforehand and hide only necessary ones 2025-05-13 11:03:05 +02:00
tetektoza
8c3439e992 BIM: Hide all objects that aren't selected during Isolate
Currently if user selects an item and does `Isolate` operation on it in
BIM, everything is being hidden if the item was inside another container
(like Building).

This is because we are prioritizing on hiding parents of current object
if they are not the selected ones, which is causing the child of the
parent to be hidden as well (duh).

So, this patch fixes isolate method to hide all other parents and their
childs. If they are not a parent of our child under selection -> hide
them and proceed further. If we are processing parent of our selection,
just hide anything on current level that is not our selection while
leaving parent intact.
2025-05-13 11:03:05 +02:00
Slawomir Gonet
1b0a3639a0 CAM: Fix Existing Stock from resetting
Due to a Qt signal setup, the clone object for Existing Stock stock type
was recreated every time the Job properties dialog was opened (during the
stock candidates list population).

This fix blocks the Qt signal from being emitted during the dropdown
population.
2025-05-13 09:35:04 +02:00
tarman3
dc9644d6e4 CAM: Simulator - Improve camera limits 2025-05-13 08:43:59 +02:00
Jacob Oursland
22c9364823 CI: fix weekly builds. 2025-05-13 08:38:29 +02:00
Chris Hennes
cfb6368026 Gui: Eliminate double->float truncations
Our GUI code uses a mix of floats and doubles to represent floating
point numbers, and in a few places interchanges them in a way that
causes an invisible loss of precision. Change the double precision
"default" values to float defaults, and use the appropriate value for
pi.
2025-05-13 08:37:06 +02:00
Jacob Oursland
127a30c8b2 CI: checkout source prior to installing pixi on weekly builds. 2025-05-12 23:12:47 -05:00
Jackson Oursland
2f6491d31f Update sub_weeklyBuild.yml
Fix `sub_weeklyBuild.yml`
2025-05-12 22:20:43 -05:00
Furgo
808773b15e BIM: change Snapping menu order for workplane commands 2025-05-12 22:32:26 +02:00
Furgo
79cb161537 Draft: add more context to select plane command message 2025-05-12 21:27:30 +02:00
Furgo
a5848ef578 BIM: Add working plane selection command 2025-05-12 21:27:30 +02:00
Jackson Oursland
493fea4e8d macOS: Remove duplicate RPATHs (#21244)
* Package: fix formatting.

* Package: correct printing of directory being processed.

* Package: remove duplicate RPATHs for macOS builds.

* Package: note the additional issue affecting RPATHs in the bundle script.
2025-05-12 11:21:14 -05:00
Chris Hennes
63de22e622 Gui: Manually specify correct QVariant conversion
There are multiple possible conversion paths for a QPixmap to QVariant,
which results in a compiler warning. Explicitly specify the path we
intend to silence the warning.
2025-05-12 18:17:48 +02:00
Chris Hennes
0b0f3aaa1e Gui: Make variable more local
Eliminate a compiler warning about an unused variable by making the
variable more local to the point-of-use.
2025-05-12 18:16:56 +02:00
Chris Hennes
c0ddaf4820 Gui: Remove default init of shared_ptr
`std::shared_ptr` default-initializes to `nullptr`, so there is no need
to do it manually, and in the current code the initialization is in the
wrong order (so generates a compiler warning).
2025-05-12 18:16:32 +02:00
Chris Hennes
f9dbaac7aa TD: Fix hatch size constraint
Commit 1155f0d7 changed `UnitsApi::getDecimals()` from `int` to
`size_t`, which changes the meaning of the negation since it is now
unsigned. Cast it to an integer before the negation to restore the old
behavior.
2025-05-12 18:11:15 +02:00
FEA-eng
ff4620ace2 FEM: Update DlgSettingsFemCcx.ui 2025-05-12 11:09:59 -05:00
sliptonic
349b879979 Merge pull request #21193 from davidgilkaufman/adaptive_helix_fixes
[CAM] Adaptive helix fixes
2025-05-12 11:09:16 -05:00
saso badovinac
21dd2f50ac Update sub_weeklyBuild.yml (#21249)
Run harden-runner first
2025-05-12 11:03:39 -05:00
tetektoza
03f41eb11f BIM: Update tooltip for Activate button 2025-05-12 18:00:52 +02:00
tetektoza
3dfa5926d2 BIM: Introduce Activate for BIM Views
Currently there's no option for selecting active working plane other
than selecting `DoubleClickActivates` property on a BIM Level.

So, this patch adds an additional button for the submenu that BIM Views
provides - to activate working plane of the selected item.
2025-05-12 18:00:52 +02:00
tetektoza
e13d0787d3 BIM: Fix missing IFC attributes for certain BIM objects
Some of the objects, like Column, or Beam do not contain `IFC
Attributes` if they are initially created.

As it turns out, they are not being created as we are checking for
`onDocRestoredDone` attribute, which is assigned in `onDocumentRestored`
function. Since users can usually just not restore a document, but just
play on a newly created document, this attribute won't be available,
thus we won't be going through whole `onChanged` logic which populates
`IFC Attributes`.

To preserve current functionality of this additional parameter and not
cause the previous errors to happen, this patch just changes from the
custom flag to globally available `Restoring` flag which tracks document
being restored more reliably.
2025-05-12 17:50:11 +02:00