wmayer
585bcb8708
lgtm: [skip ci] FIXME comment
...
Change FIXME or remove it
2022-03-20 16:51:23 +01:00
sliptonic
e5d7bc8c0c
Merge pull request #6616 from FreeCAD/Path/LGTM-pas
...
Path: remove superfluous 'pass' per LGTM
2022-03-20 10:41:40 -05:00
wmayer
b09135fca7
Mesh: [skip ci] lgtm: Multiplication result converted to larger type
...
Multiplication result may overflow 'float' before it is converted to 'double'.
2022-03-20 15:53:04 +01:00
Matthijs Kooijman
199c35ca46
Arch: When inverting hinge position, keep opening direction
...
Previously, just the hinge position was changed, with the rotation
direction kept unchanged, which would make the door open towards the
other side of the wall. This also inverts the rotation direction, so the
door still opens toward the same side of the wall, which is more
intuitively what you would expect.
2022-03-20 14:46:13 +01:00
Matthijs Kooijman
2f05f86f6c
Draft: Fix incorrect use of in operator
...
Looking at the surrounding code, this should be `==` rather than `in`.
The code does work as intended, because a string is always a substring
of itself, but better to fix it anyway.
Seems this was broken since this code was first introduced in commit
193339991f (Draft: clean up ViewProviderLabel class)
2022-03-20 14:45:52 +01:00
Uwe
3e1dbde0cf
[Part] remove Python.h from headers
...
seems not to be necessary anymore
2022-03-20 14:16:55 +01:00
Uwe
3d26a81b36
[PD] remove Python.h from headers
...
seems not to be necessary anymore
2022-03-20 14:16:41 +01:00
wmayer
4b2850528b
MeshPart: suppress incorrect warning with clang/MSYS
2022-03-20 13:45:43 +01:00
wmayer
fd8ce30575
Fem: [skip ci] change include order to fix compiler warning due to a re-defition of a macro in a Python header
2022-03-20 13:44:55 +01:00
Uwe
d594118855
[Part] fix TaskFaceColors dialog
...
fixes these issues:
- the actual or chosen color is never displayed in the dialog's color button (it was there but with zero transparency)
- after a color has been set one does not see it (because the changed faces were still highlighted and got the highlight color)
2022-03-20 05:41:34 +01:00
luz paz
773bd041e9
Path: remove superfluous 'pass' per LGTM
...
ref: https://lgtm.com/rules/910088/
2022-03-19 20:06:48 -04:00
wmayer
e28f2a0c47
Qt: remove some more leftovers of Qt4
2022-03-19 23:27:28 +01:00
andrea reale
83d3a916c0
remove QT4 references
2022-03-19 23:07:38 +01:00
sliptonic
b25eaec2e5
Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui
...
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
2022-03-19 15:44:28 -05:00
Chris Hennes
202de96afe
Addon Manager: Add py-slvs to allowed packages
...
Used by ASM3, and maintained by @realthunder.
2022-03-19 12:32:59 -05:00
Uwe
be99144c91
[FEM] adapt a test to previous commit
...
(I run of course all tests using the Test Framework WB but did not get an error.)
2022-03-19 18:09:14 +01:00
Uwe
842b781a41
[FEM] proper Elmer input file write solution
...
- assure that independent on the used unit scheme, SI units are written to the Elmer input file
- reverts commits https://github.com/FreeCAD/FreeCAD/commit/9db165b24b and https://github.com/FreeCAD/FreeCAD/commit/c707d192e
2022-03-19 17:48:11 +01:00
wmayer
dd28df0a69
Fem: replace raw pointer with WeakPtrT to check if the object has been deleted, fix crash in destructor of TaskFemConstraintOnBoundary
2022-03-19 15:37:31 +01:00
Uwe
31645fc5bc
[FEM] change example to fit with Elmer's tutorial
...
- this example is the Elmer tutorial number 13: https://www.nic.funet.fi/pub/sci/physics/elmer/doc/ElmerTutorials.pdf and they use a potential of 1.0, since Elmer uses SI units, it is 1.0 V
2022-03-19 15:29:55 +01:00
Uwe
12a90b69d3
[Part] TaskFaceColors: remove unused includes
...
- also some code style fixes by MSVC and sorting
2022-03-19 15:16:09 +01:00
wmayer
723cd53cd6
Sketcher: [skip ci] close directory in unit test
2022-03-19 13:54:59 +01:00
Uwe
2f9b432fdd
[FEM] electrostatic dialog revision
...
- use a quantity spinbox and do simple signal/slot handling in the UI file
2022-03-19 05:01:23 +01:00
Uwe
f05fa48922
[FEM] forgot this test case in previous commit
2022-03-19 03:51:06 +01:00
Uwe
fa39e0929c
[FEM] update test files to previous Elmer fixes
2022-03-19 03:34:18 +01:00
Uwe
6b1b473104
[FEM] fix vacuum permittivity for the Elmer solver
...
also a missing fix for the density
2022-03-19 03:06:27 +01:00
Uwe
12a07760e9
[FEM] fix the Elmer solver writer
...
- fixes #6604
as it was, Elmer was almost unusable because most values were input with wrong units to Elmer.
Elmer uses pure SI units
ToDo: fix the still wrong Vacuum permittivity
2022-03-19 01:53:26 +01:00
Uwe
512c46d75e
[FEM] [skip CI] improve electrostatic dialog
...
- to gain more horizontal space
2022-03-19 01:50:37 +01:00
Uwe
2ef424bda8
[Part] Section cut: add missing color handling for the cut faces
...
- the color was not handled at all and thus was often criticized
2022-03-18 17:05:47 +01:00
sliptonic
892891f0c4
Merge pull request #6590 from sliptonic/feature/warnlegacy
...
[Path] Warn user if enabling legacy tools
2022-03-18 10:46:42 -05:00
Wanderer Fan
218f58b4f9
[TD]fix default scale
2022-03-18 08:21:21 -04:00
Uwe
b6f985c861
[Part] Section Cut: add missing handling of valueChanged
...
- when the user changed the value without moving the slider (e.g. by clicking), nothing happened
2022-03-18 06:26:12 +01:00
Chris Hennes
a7699eadc6
Test: Change Metadata exception tests to use assertRaises
2022-03-17 19:09:01 -05:00
Uwe
fea1e816cb
[skip CI] [FEM] cleanup SVG code of new icon
2022-03-18 00:45:08 +01:00
Uwe
d1c582191a
[FEM] add icon for the new supported MYSTRAN solver
2022-03-18 00:18:25 +01:00
Uwe
ba01b19432
[skip CI] [FEM] save an icon as plain SVG
2022-03-18 00:16:57 +01:00
Uwe
7ccfe10af4
[FEM] task dialogs: remove unused includes
...
- also some code style fixes from MSVC
2022-03-17 23:31:17 +01:00
Uwe
b7e1dd9ee9
[FEM] save new icon as plain SVG
2022-03-17 22:38:09 +01:00
Uwe
2769387d68
[FEM] add missing preferences settings
...
- since 0.19 we support to check meshes
- since 0.20 we support buckling
- also revise dialog to get rid of arbitrary limits etc.
2022-03-17 22:33:56 +01:00
Uwe
ac8fdfcad1
[FEM] settings dialogs: uniform width
...
- some minor changes automatically done by Qt Designer
2022-03-17 21:47:58 +01:00
Uwe
74482e9319
[FEM] settings dialogs: remove unused includes
2022-03-17 21:27:46 +01:00
Uwe
ebff4fddcc
[FEM] remove unused headers from WBs main files
...
- also some code style fixes by MSVC
2022-03-17 20:33:33 +01:00
wmayer
40ba077f85
Part: [skip ci] print warning only if eof bit is not set, i.e. ignore it for empty files
2022-03-17 20:24:06 +01:00
Uwe
4f0fd30371
[FEM] remove some unused includes for some dialogs
...
- also some style fixes made by MSVC
2022-03-17 19:53:12 +01:00
Yorik van Havre
9f4844e70a
Merge branch 'master' of github.com:FreeCAD/FreeCAD
2022-03-17 16:11:30 +01:00
Yorik van Havre
74016d1f74
Merge pull request #6544 from Roy-043/Draft-Fix-Angle-Lock-for-non-XY-workingplane
...
Draft: Fix Angle Lock for non-XY workingplane
2022-03-17 15:46:52 +01:00
Yorik van Havre
eea99d8e13
Arch: Fixed export of texts and dimensions to IFC
2022-03-17 15:46:18 +01:00
Stefan Brüns
5b419b6b27
[Test] Fix tkinter module name for python 3
...
The module name changed from uppercase Tkinter to tkinter.
2022-03-17 15:20:42 +01:00
wmayer
e4d1ed8366
Base: rename BaseExceptionFreeCADError to PyExc_FC_GeneralError
2022-03-17 14:45:48 +01:00
wmayer
1f12dca2b4
Py: replace BaseExceptionFreeCADError with more suitable exception types
2022-03-17 13:54:23 +01:00
Yorik van Havre
18847444d4
Merge pull request #6594 from FlachyJoe/draft_grid_FitAll
...
[Draft] Don't take grid into account when View_FitAll
2022-03-17 12:04:41 +01:00