kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
28,444 Commits 41 Branches 6 Tags
dfd91f3ea2673e33bcdd2ed330c3af58af456969
Commit Graph

22142 Commits

Author SHA1 Message Date
Ajinkya Dahale
9007662425 [Sketcher] Fix "toggle internal geo" on multi-selection 
Some deleted GeoIds can stay in selection and GeoIds can change as some objects
are deleted.
 2022-03-13 06:58:40 +01:00
Russell Johnson
4e9f7b0b62 Path: Fix self.removalshapes declaration [Bug] 
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty.  This moves the declaration up in scope to the method level.
 2022-03-12 22:34:03 -06:00
Russell Johnson
2bc14f84aa Path: Fix automatic commitTransaction() calls, issue #6149 [Bug] 
This commit removes the automatic committal of transactions when activated with GUI command.  The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
 2022-03-12 22:05:04 -06:00
Russell Johnson
68d20e7e90 Path: Improve value assignment syntax for radius 2022-03-12 20:00:40 -06:00
sliptonic
73e995a0f7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction 
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
 2022-03-12 19:05:39 -06:00
Uwe
25137db5ca [Assembly] fox typos in element names 
all found by the spellchecker CI
 2022-03-13 01:32:27 +01:00
Russell Johnson
ba4611a260 Path: Fix radius type inconsistency, issue #6170 [Bug] 
Make `self.radius` a float type throughout since other methods and functions treat it as such.
 2022-03-12 18:29:21 -06:00
sliptonic
217174d548 Merge pull request #5440 from voneiden/path-array-improvements 
Path: Path Array dressup compatibility
 2022-03-12 18:21:40 -06:00
mwganson
eaf36231eb PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Anders Torger
7d628a6e03 Add General.NumThreads = CPU core count setting to Gmsh 
settings file to enable multi-threaded meshing (much faster
for larger models)
 2022-03-12 23:26:55 +01:00
Matti Eiden
34ed7bc123 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Abdullah Tahiri
bba7c89c2a Sketcher: Coverity 332695 - unlikely array indexing with negative value 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bcfa246943 Sketcher: Coverity 332679 - logically dead code removed 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
341cf32369 Sketcher: Coverity 332685, 332686, 332696 
=========================================

Detected by coverity as unchanged variable (constant intended).

It was actually an unnecessary variable that prevented correct command committing.
 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
c8a57fb9b4 Sketcher: Coverity 350601 - possible resource leak 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
963cae4a0b Sketcher: Coverity 350637 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bd84e883cf Sketcher: Coverity 350641 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Russell Johnson
4ae4e7be1a Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug] 
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
 2022-03-12 12:18:09 -06:00
Abdullah Tahiri
7294d4d7a3 Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Uwe
c50f2e980c [Assembly] fix typos found by the spellchecker CI 2022-03-12 17:52:33 +01:00
Uwe
931e2a3c17 [Robot] fix some typos found by the spellchecker CI 2022-03-12 17:46:48 +01:00
Abdullah Tahiri
5e88ee99f5 Sketcher: BSpline code review and fix 
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
 2022-03-12 15:47:50 +01:00
Uwe
e4777d16f8 [Part] remove unused variable 
MSVC complained about it
 2022-03-12 15:44:27 +01:00
Wanderer Fan
7bef267503 [TD]fix 2 edge angle Dim special case 2022-03-12 08:55:35 -05:00
Chris Hennes
589f074e7d Test: Add first tests for Metadata 2022-03-11 20:15:44 -06:00
Chris Hennes
e7d50f0b13 Addon Manager: Fix window focus issues 2022-03-11 20:07:20 -06:00
mwganson
fc617e1524 Part: 2doffset fix crash by chacking for null shape before adding with builder.Add() 2022-03-12 02:48:22 +01:00
Zheng, Lei
2a28ad5cef PD: add SubShapeBinder 'Refine' property 
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
 2022-03-12 02:45:13 +01:00
Zheng, Lei
8d6b06bc86 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00
Uwe
5d798e26cf [Path] fix a typo 2022-03-12 02:24:44 +01:00
Uwe
5dba742beb [Path] 2nd part of the Git fix attempt 
renaming it back
 2022-03-12 02:01:29 +01:00
Uwe
99a0a67867 [Path] next attempt to fix Git error by renaming 
use lowercase letters fro file ending like it is also in the CMake file
 2022-03-12 02:00:40 +01:00
Uwe
76e601a712 [Path] try to silence a git error with a file 
Git has issues with this file telling me it is corrupted and its file ending is wrong (in Git lowercase, in the file uppercase).

The attempt is to just to save save it with FC 0.20.
 2022-03-12 01:55:37 +01:00
wmayer
ec8353ba99 Part: refactor PropertyPartShape::SaveDocFile and PropertyPartShape::RestoreDocFile 
Set exception mask of std::istream::failbit | std::istream::badbit to istream to make sure it raises an exception for corrupted input files.
See: https://forum.freecadweb.org/viewtopic.php?p=536747
 2022-03-11 22:06:38 +01:00
Wanderer Fan
cb5334a98c [TD]fix getScale should be Scale.getValue 2022-03-11 11:59:31 -05:00
sliptonic
da2dcaa7f4 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation 
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
 2022-03-11 10:06:42 -06:00
sliptonic
14949faf06 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup 
Path: Fix enumeration dictionary error [Bug]
 2022-03-11 10:04:53 -06:00
sliptonic
f8fa9c047e Merge pull request #6530 from sliptonic/bug/6114 
[Path] Fix minor non-modal bug.  Fixes 6114
 2022-03-11 10:03:53 -06:00
sliptonic
f82951a6bc Merge pull request #6536 from J-Dunn/master 
PATH: Fix tool shapes for zero dimension bugs
 2022-03-11 09:56:52 -06:00
Wanderer Fan
53a105c397 [TD]fix Dim text on wrong side 2022-03-11 08:10:58 -05:00
wmayer
490dd63e77 Test: fix unit test 'Menu' 2022-03-11 13:57:56 +01:00
Civil Guy
3c2c38fd1a Minor spelling fixes 2022-03-11 13:57:03 +01:00
Yorik van Havre
82d93293b1 Arch: Fixed auto-height of child walls & structures - fixes #5732 2022-03-11 11:52:33 +01:00
Chris Hennes
dc113efa17 Addon Manager: Fix bug in macro button 
Don't offer to install a toolbar button if it already exists.
 2022-03-10 21:50:34 -06:00
Russell Johnson
a52e63b934 Path: Fix Leadin-Leadout dressup simulation related to arcs 
Add missing "Z" and "K" parameters for arc commands to appease Path simulator.
 2022-03-10 20:05:52 -06:00
luz paz
44bb1674b6 AddonManager: fix typos 
Fixed via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,strack,substraction,te,technic,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
 2022-03-10 18:28:10 -05:00
Roy-043
b830f77215 Draft: Fix Angle Lock for non-XY workingplane 2022-03-10 17:44:38 +01:00
Wanderer Fan
7903904f13 [TD]add missing ScaleType to Section dlg 2022-03-10 09:25:52 -05:00
Wanderer Fan
d9afcaa807 [TD]handle ScaleType in old documents 2022-03-10 09:25:52 -05:00
Yorik van Havre
419594a5dc Draft: Fixed error in SVG rendering of LinkedArrays - fixes #6516 2022-03-10 13:34:18 +01:00