Commit Graph

59 Commits

Author SHA1 Message Date
wandererfan
414e06d54d [TD]apply translateLabel after all addObject calls 2023-08-17 19:23:29 -04:00
Chris Hennes
94426e1f54 TD: Translate default labels 2023-08-17 19:23:29 -04:00
luzpaz
a38b2ffbf7 Fix various trailing newlines, typos and grammar 2023-02-04 18:29:07 +01:00
wmayer
25a63f8750 TD: move to new style connect() 2023-02-01 01:33:34 +01:00
wandererfan
12db3618df [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
Uwe
cbd0140dcd [TD] Task*, part 2/2: remove unused includes
- also some sorting
- also take care of PreCompiled.h
2022-12-07 19:49:05 +01:00
Uwe
16abb8d548 [TD] DrawUtil: remove unused includes
- also sort includes
- also move a definition to it
- also adapt two Gui files accordingly
2022-10-08 03:35:59 +02:00
Uwe
e3bf7027a6 [TD] remove redundant nullptr checks 2022-10-03 04:25:33 +02:00
wmayer
6d7d154c0e TD: remove unused member variables to fix -Wunused-private-field 2022-09-08 08:15:19 +02:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
bdf4cea14e [TD]refactor scene/view/mdi
- move scene related functions out of mdiViewPage
  and QGVPage.
- route requests for scene/view/mdi through
  ViewProviderPage
2022-08-18 09:34:32 -04:00
Benjamin Bræstrup Sayoc
aa9a667506 [TechDraw] Clean up precompile in Gui 2022-08-14 09:20:38 -04:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Benjamin Bræstrup Sayoc
86dfd0a862 [TechDraw] Simplify code getting default line weights 2022-08-02 16:13:01 -04:00
wmayer
c4e4b5cf02 TD: Use new-style syntax of connect()
When fixing clazy issues -Wclazy-fully-qualified-moc-types then old-style syntax of connect() may fail. Thus, replace it with the new-style syntax
2022-07-26 16:10:45 +02:00
Uwe
40d8ebb372 [TD] remove some more superfluous nullptr checks 2022-07-20 11:54:28 +02:00
Uwe
2e5e4dced8 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Benjamin Bræstrup Sayoc
9976280027 [TechDraw] Improve readability of TaskLeaderLine.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
43f6c17942 [TechDraw] Rename icon filenames for consistency 2022-07-09 14:38:30 -04:00
Wanderer Fan
9894964eb6 [TD]implement navigation styles 2022-06-24 10:03:02 -04:00
Kuzemko Alexsandr
477eed10a4 [TD] Fix incorrect using of QT_TRANSLATE_NOOP in setText 2022-06-01 13:41:00 -04:00
Wanderer Fan
3e56f88404 [TD]mark literals for translation 2022-05-13 13:41:37 -04:00
Chris Hennes
c44ccc0ff2 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
Uwe
2e7cb2c3fb [TD] remove a single-header file 2022-03-25 04:11:53 +01:00
Uwe
bf04eabb2d [TD] add missing header 2022-03-25 03:04:39 +01:00
wmayer
a99be14233 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
wmayer
1ca7429705 Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Wanderer Fan
cb280afbc4 [TD]remove redundant edits from 9 Task dialogs 2022-01-22 14:51:20 -05:00
wmayer
e728c3590e TD: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 316559 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value we. Field we.idx is uninitialized when calling push_back

CID 316549 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member pageheight is not initialized in this constructor nor in any functions that it calls.

CID 186161 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member parent is not initialized in this constructor nor in any functions that it calls.

CID 305170 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking this->m_baseFeat suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

CID 186152 (#2 of 2): Uninitialized pointer field (UNINIT_CTOR)
3. uninit_member: Non-static class member m_mdi is not initialized in this constructor nor in any functions that it calls.

CID 192588 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT)
pointless_expression
2021-02-21 16:30:30 +01:00
donovaly
b5f57ed2f0 [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
donovaly
a1915d313a [TD] make LineGroup selectable
At the moment one has to specify the LineGroup as string. But one doesn't know what groups exist. So one has to check the Wiki, learn there where the groups are defined and then open the definition file with a text editor.

This PR simplifies this by reading the existing groups out of the definition file and fill the combobox accordingly.
It also give the user info what the selected LineGroup defines via the tooltip.

A nice side effect is that no typos can occur since you don't have to enter the LineGroup name as text.
2020-12-03 17:24:49 +01:00
luz paz
2befcd9502 TD: Issue #0004473: Expose openCommand() to translation
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the TechDraw Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
2020-12-01 14:53:35 +01:00
luz paz
a3cb87b117 TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
5584c36c1b Coverity: [skip ci] Dereference before null check 2020-07-21 14:31:09 +02:00
wmayer
b25dee58d5 Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wmayer
421f6c52cb Coverity: Dereference after null check 2020-07-20 17:34:25 +02:00
wandererfan
e80c576241 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
wandererfan
83cb709893 [TD]correct button text 2020-03-24 18:16:23 -04:00
wandererfan
779ebb7715 [TD]fix Leader end type selection 2020-03-23 09:23:08 -04:00
wandererfan
3e00de25f4 [TD]fix Leader attach point secondary views 2020-03-23 09:23:08 -04:00
donovaly
47fda412bb [TD] make LeaderLine dialog show changes immediately 2020-03-22 09:37:04 -04:00
donovaly
6fa80d8cbf [TD] fix order of arrow heads
see https://forum.freecadweb.org/viewtopic.php?f=35&t=44334#p378675
2020-03-21 09:44:07 -04:00
wandererfan
dcef41782e [TD]harmonize Arrow enums 2020-03-11 09:33:54 -04:00
donovaly
bf9e646ebe [TD] LeadlerLine dialog beautifications
(add tooltips, use a display widget)

see https://forum.freecadweb.org/viewtopic.php?f=35&t=43360&p=369885#p369885
2020-02-18 07:36:59 -05:00
wandererfan
e8417c6268 [TD]fix LL edit when no MDI 2020-02-16 14:24:14 -05:00
WandererFan
a92e157a9d [TD]sync icon names and menu entries
- contributed by @uwe
2020-02-03 07:20:52 -05:00
wandererfan
ebf0f9da0d [TD]Default color and weight for markup lines 2020-01-29 15:26:06 -05:00
donovaly
b758b22171 [TD] fix regression with line width I introduced today 2020-01-28 21:07:49 -05:00
donovaly
42e6aeb14e [TD] improve RichAnno and LeaderLine dialog
see: https://forum.freecadweb.org/viewtopic.php?f=35&t=42746&p=364126#p364126
2020-01-28 12:40:56 -05:00
donovaly
a3622ee49f [TD] rename some Draw* elements - try 2
as discussed here: https://forum.freecadweb.org/viewtopic.php?p=360042#p360042
2020-01-18 06:57:29 -05:00