kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
41,619 Commits 39 Branches 6 Tags
e56979e76e4e10cdaa9133ef153c06b824a225a8
Commit Graph

165 Commits

Author SHA1 Message Date
theo-vt
e56979e76e PartDesign: Fix no longer possible to make a hole from one selected circle in a sketch (#21030) 
* Search for profile shape subelements without simplifying compounds for hole center detection

* Simpler solution
 2025-05-08 16:47:26 +00:00
theo-vt
774ec2cc93 PartDesign: Center holes on sketch points as well as circles and arcs (#20583) 
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-04-21 23:30:57 +02:00
Kacper Donat
b300c80b90 Base: Use explicit pointer syntax for freecad_cast (#20694) 
* Base: Use explicit pointer syntax for freecad_cast

This aligns our custom cast with other casts

* All: Use explicit pointer syntax for freecad_cast
 2025-04-11 14:11:33 +00:00
Kacper Donat
35a9673a75 Base: Rename Base::freecad_dynamic_cast into freecad_cast 
This is to make it shorter and easier to use. QT does the same thing
with their qobject_cast.
 2025-04-07 10:32:28 -05:00
Benjamin Nauck
dd6aa9f3c7 Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's 
Regex based changes, manually verified
 2025-01-27 16:08:18 +01:00
wmayer
b3a1fd9676 App: Add methods to get base and direction of datum element 
Add the methods DatumElement::getBasePoint() and DatumElement::getDirection() to hide implementation details and guarantee consistent behaviour.

Using the methods fixes several regressions in:
* Constraint::getDirection
* PolarPattern::getTransformations
 2025-01-02 13:24:57 +01:00
PaddleStroke
fc56730648 Core: Datums: Fix axis placement and add migration script. 2024-12-13 18:04:10 +01:00
PaddleStroke
3c1358da10 Core: Rename 'OriginFeature' file to 'Datums' 2024-11-26 15:36:48 +01:00
Florian Foinant-Willig
490d6c5abc [PD] Fix Pad uptoface with custom direction (#16539) 
* [PD] Fix Pad uptoface with custom direction

* Add unit test
 2024-09-24 11:30:01 -05:00
Florian Foinant-Willig
8b9f5bdc4f [PD] fix pad uptoface and uptoshape (#16030) 
* [PD] fix Pad UpToFace and UpToShape
* specify struct pointers for Win
* Rename variables for MSVC compatibility - windows.h defines 'near' and 'far' as macros
* Add unit test

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2024-09-19 08:51:18 -05:00
bgbsww
2a541c9536 Toponaming: Remove remaining FC_USE_TNP_FIX defines 2024-08-31 13:21:10 -05:00
bgbsww
ecf7e51ab3 Toponaming: Remove all FC_USE_TNP_FIX protected old code 2024-08-26 11:12:48 -05:00
bgbsww
8c08549f5a Update to Toposhape versions and fix shapebinder references with test (#16036) 
* Update to Toposhape versions and fix shapebinder references with test

* Update src/Mod/PartDesign/PartDesignTests/TestShapeBinder.py

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2024-08-26 10:50:18 -05:00
Florian Foinant-Willig
309dd6e30d PD Extrude up to multiple faces or shape 2024-06-03 11:26:19 -05:00
bgbsww
958d83ed06 Toponaming: Restore use of AttachmentSupport 2024-06-01 11:49:58 -05:00
bgbsww
040502280f Toponaming: Cleanup verified face calls 2024-05-20 17:48:01 -05:00
bgbsww
b72a8c4222 Toponaming: Bring in Chamfer, Fillet code and add tests (#14035) 
* Toponaming: bring in missing code fragments in Sketcher

* Toponaming: Fix infinite recursion, remove debug cruft, rough in fillet test

* Bring in missing code; fix chamfers

* Toponaming: Add code for fillets and test
 2024-05-15 19:43:30 -04:00
bgbsww
f304b0123c Toponaming: bring in missing code fragments in PartDesign 2024-05-13 08:45:26 -05:00
wmayer
56f84c8042 Fix various compiler warnings: 
* fix -Wunused-parameter
* fix -Wunused-function
* fix -Wunused-private-field
* fix -Wunused-variable
* fix -Winconsistent-missing-override
 2024-04-30 16:59:31 +02:00
wmayer
ed77603af9 PD: Fixes crash if sub-element name of reference axis is empty 
This fixes #13656
 2024-04-27 07:43:40 +02:00
bgbsww
fa8f29aed4 Toponaming/Part: Fix all getBaseTopoShape calls. Tests and missing code. 2024-04-26 21:15:11 -05:00
bgbsww
c9d8bdf13d Toponaming/Part: Add deprecation comments, clean up code 2024-04-09 21:17:08 -04:00
Zheng, Lei
82c3e107d7 TopoShape/Part: Bring in PartDesign dependencies 2024-04-09 21:17:08 -04:00
Josh Coalson
a8ae56e06a Part: Rename AttachExtension::Support property to AttachmentSupport, to avoid name conflict with base features. Fixes #7052 2024-03-04 18:22:43 +01:00
Florian Foinant-Willig
6adc675a12 PartDesign: modernize type checking 2023-10-23 18:08:16 +02:00
wmayer
9a1f8a11d6 PD: modernize C++: use range-based for loop 2023-08-16 21:54:56 -05:00
Florian Foinant-Willig
761e807cd5 PartDesign: UpToFace check isnull 
The next line crash if upToFace is null.
 2023-07-24 14:40:15 +00:00
Uwe
94787e8afa [PD] enable padding to touching planes 
- this patch is from @@FlachyJoe
- as reported here: https://forum.freecadweb.org/viewtopic.php?p=646231#p646231
it was impossible to pad to a face which is touching the sketch despite is is no parallel to the extrusion Direction
 2022-12-12 13:04:05 +01:00
wmayer
69aba3abe1 PD: remove parameter 'supportface' from ProfileBased::getUpToFace as it's not used any more 2022-12-05 12:46:52 +01:00
Uwe
59c1741559 [PD] Pad/pocket: fix wrong error message 
- the error can also occur when the mode it not UpToFace (ToFirst or ToLast)
- also add note when Reversed checkbox is enabled since this is no obvious (as discussed in the forum)
- also some whitespace unification and include sorting
 2022-12-04 05:37:11 +01:00
Uwe
3ded221646 [PD] FeatureSketchBased: fix orthogonal check 
- same fix as #7879
- also fix wording on an error message and improve a variable name
 2022-12-04 05:31:51 +01:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
b796a0d376 Mod: use empty 2022-08-06 19:30:13 +02:00
Uwe
5d76afe0a5 re-add some nullptr 
to be safe since their removal within assert() or bools might have some impact I don't know
 2022-07-18 02:32:36 +02:00
Uwe
697e88aed6 [PD] remove more superfluous nullptr checks 2022-07-18 01:33:28 +02:00
Uwe
07ddfc88de [PD] App: remove superfluous nullptr checks 
- also Body: get rid of some nasty single-letter variables
 2022-07-17 18:07:00 +02:00
wmayer
656408615a PD: fix ProfileBased::getSupportFace() to also handle the case where a support face is selected 2022-07-16 16:08:09 +02:00
wmayer
882125c1c6 PD: rename getUpToFaceFromLinkSub to getFaceFromLinkSub 2022-07-16 15:59:54 +02:00
andrea
93525ff7eb removed references to OCC<7 2022-06-25 14:29:24 +02:00
Uwe
66e4c37a25 fix some occurrences where size() is misused as Boolean 
- as suggested by @wwmayer: 4d51d1d0b1 (r69648152)
 2022-03-27 21:38:15 +02:00
wmayer
3608ee7f51 PD: modernize C++11 
* use nullptr
 2022-03-23 19:26:14 +01:00
wmayer
5e0789e2f1 PD: fix const correctness in ProfileBased 2022-02-28 18:10:58 +01:00
Uwe
fd19d1a7b0 [PD] more work to remove unused includes 2022-02-21 02:18:17 +01:00
Uwe
7c44008e2d [PD] App: remove unused includes 2022-02-20 20:41:46 +01:00
wmayer
95f583a677 Part: fix typos in make* functions 2022-02-16 12:48:02 +01:00
Uwe
7786e24fcd [PD] change default FaceMaker to Bullseye 
Part does already use this FaceMaker since it can also handle islands.

The PR therefore
- uniforms the behavior of PD and Part
- fixes #6366
- enables to use nested sketches for the various PD features like Revolve
 2022-02-16 11:20:02 +01:00
Uwe
dc332a5ca0 [PD] moves Extrude code to FeatureExtrude 
* [PD] moves Extrude code to FeatureExtrude

- since the Extrude code is only used by Pocket/pad, it should better in FeatureExtrude
 2022-02-12 19:37:53 +01:00
wmayer
5c9bffb73d PD: fix 'stack-use-after-scope' crash 2022-02-08 17:16:59 +01:00
Uwe
cfdf334b7f [PD] add option to create tapered Pad / Pocket 
This PR adds the same functionality as provided by Part Extrude.
The used code parts are sorted out to a new helper function that is used by Part and PartDesign.
 2022-02-02 01:04:06 +01:00
wmayer
59c470dedf PD: fix bad formatting 2022-01-23 11:07:59 +01:00