Commit Graph

31897 Commits

Author SHA1 Message Date
wmayer
e71386d20d App: define an enum to be used as the retType argument of DocumentObject.getSubObject()
This is to avoid to use magic numbers in client code
2023-02-14 12:02:33 +01:00
luzpaz
d54efb42b3 Arch: fix incorrect indentation in ArchStairs.py (#8475) 2023-02-14 11:22:04 +01:00
Chris Hennes
f83abbab4c Addon Manager: Refactor Macro parser 2023-02-13 23:46:57 -06:00
Chris Hennes
2603cd6b16 Test(Metadata): Remove catch from Setup()
If an exception occurs while setting up Xerces-C, make the test framework handle it.
Also add a copyright header, and try to quiet down the clang-tidy linter.
2023-02-13 23:46:37 -06:00
VM4Dim
68da9cd64a [Gui] Sort Add Property Types 2023-02-14 02:40:08 +01:00
Roy-043
5e0a8dd4ac [Arch] fix Arch_Stairs recompute issue (#8444)
* [Arch] fix Arch_Stairs recompute issue

* Fixed the tooltips for the updated properties.

* Added warnings to the functions that updated the properties.

* Fixed a typo makeCurvedStairsWithLandings -> makeCurvedStairsWithLanding
2023-02-13 21:11:52 +01:00
edi271
bf108be321 [TD] solve reported issues 2023-02-13 14:45:04 -05:00
edi271
cfc5d0bb53 Changed files 2023-02-13 14:45:04 -05:00
edi271
ca910312bf Combo View dialog source hole / shaft fit 2023-02-13 14:45:04 -05:00
edi271
818255f416 [TD] Command source hole /shaft fit 2023-02-13 14:45:04 -05:00
edi271
a25233b526 [TD] ui file hole /shaft fit 2023-02-13 14:45:04 -05:00
edi271
598acfd88e [TD] Icon file hole/shaft fit 2023-02-13 14:45:04 -05:00
Uwe
50763df45b [FEM] sort code of result filters
- sort the functions alphabetically to know where to scroll to - eases the reading at least a bit
- some automatic reformatting according to our current clang file
- split too long lines
2023-02-13 19:52:54 +01:00
Uwe
eea83ae37e [FEM] improve messages in mesh generation
- no longer output an error on mesh from a BooleanFragments. There are cases when this fails, but other cases where one must use a BoopleanFragments compound and this works well, see https://forum.freecad.org/viewtopic.php?t=71070. Therefore a warning is sufficient.
- disable log messages not important for the average users.
- avoid code duplication
2023-02-13 16:55:00 +01:00
Uwe
3c94e3d87e [FEM] add new filter to display iso contours
- very valuable to display for example electromagnetic field lines
2023-02-13 16:53:21 +01:00
Chris Hennes
6774c6002e CI: Tweaks to pylintrc 2023-02-13 15:46:28 +01:00
Yorik van Havre
0566d90cc5 merged crowdin translations 2023-02-13 15:45:26 +01:00
Yorik van Havre
63e4a36000 updated ts files 2023-02-13 15:45:26 +01:00
luzpaz
d844255685 FEM: fix trailing newlines 2023-02-13 15:41:31 +01:00
Yorik van Havre
7aa9ccde77 Merge pull request #8409 from Roy-043/Arch-fix-Arch_Site
[Arch] fix Arch_Site
2023-02-13 14:40:23 +01:00
Uwe
09c920cb7c [FEM] fix wrong name in cut filter
- it is the cut, not the clip filter, was probably a copy/paste mistake
- also some automatic code-reformatting according to our current clang file
2023-02-13 14:13:09 +01:00
Uwe
4013c12b60 [FEM] add missing registration of magnetodynamics equation 2023-02-13 14:12:43 +01:00
0penBrain
96f82821ba CI: improve logging for configure, build and install steps
* Line buffering for stdout and stderr to better preserve log order
 * Full log now contains both stdout and stderr to keep errors in context
2023-02-13 11:27:26 +01:00
0penBrain
e49677b6b5 CI: factorize CMake install step in Linux builds 2023-02-13 11:27:26 +01:00
0penBrain
5d2e3af349 CI: factorize CMake build step in Linux builds 2023-02-13 11:27:26 +01:00
0penBrain
5b426d74a8 CI: factorize CMake configuration in Linux builds 2023-02-13 11:27:26 +01:00
0penBrain
304b88b84e CI: fix typo in runTests action name 2023-02-13 11:27:26 +01:00
0penBrain
590e7a84d3 CI: spell checker silently fails 2023-02-13 11:27:26 +01:00
0penBrain
3a7f8c70ca CI: deleting used artifacts in wrapup is allowed to silently fail 2023-02-13 11:27:26 +01:00
0penBrain
1b2795cd2a CI: rename Ubuntu jobs in master workflow to clarify 2023-02-13 11:27:26 +01:00
Uwe
3c30c389bb [FEM] register new result values to DataAtPoint filter
- also sorting to keep the overview
2023-02-13 02:50:34 +01:00
Jonas Bähr
dc1130bf28 PD: Improve InvoluteGear's fillet generatrion
Previously, the fillet started at a fixed value, tailored at 20° pressure
angle, a fillet radius of 0.375 and a dedendum of 1.25. With PR #8184
those values became user-adjustable and thus the assumptions of the
original code are not fullfilled any more. This resulted in significant
artefacts, especially for higher pressure angles or smaller dedendums as
commonly found in splines.

This commit actually calculates the junction between fillet and involute
so that the tangents of the both curves match.
The mathematical approach is described in source code comments.

The change in the fillet calculation also affects compatibility with
files generated by earlier versions of FreeCAD. Those changes are way
below 0.1% per tooth, however the earlier test required absolute equality
down to the micron. This was relaxed and also changed to a relative, per
tooth, tolerance.

There is one particular case where the new algorithm performs slightly
worse, though. That is when the fillet radius is too large to the
dedendum, i.e. resulting in a single arc instead of two fillets, and
effectively cannibalizes some of the clearance. This happens with internal
gears having less than 25 teeth. At about 15 teeth it becomes visible
that the fillet is not 100% tanget any more. However, as such a low
number of teeth is highly unusual for internal gears and the effect,
although noticeable, is minor, the overall benefits of the new algorithm
outweighs the drawbacks. And now with the fillet radius being adjustable
it is easy to fix, too.
The technical reason is that the tangency is calculated correctly, but
the fillet circle is displaced aferwards to avoid an overlap of the two
fillets. For the new fillet position, the tangents do not align any more.
2023-02-13 02:31:28 +01:00
Jonas Bähr
b053c58308 PD: Expose new gear properties to the SVG generator
This little script has proven to be a vauable debugging aid, so it got
some love. All the new properties from #8184 can now be set, together
with the option to generate internal gears.
2023-02-13 02:31:28 +01:00
Uwe
f7df219b7b [Part] extend SectionCutting feature for intersecting objects
- it is a well-known and often feed-backed missing feature that SectionCuttings fails for intersecting objects.
To resolve this, the objects must be put int a BooleanFragments object.
- this PR adds this functionality as option.
- since a BooleanFragments objects has a specific color, the different colors of the objects cannot be preserved. Because of this disadvantage, the BooleanFragments option will not be the default.

- this PR also modernize all for loops
2023-02-13 00:46:37 +01:00
Roy-043
9c8da9a14e [Arch] fix Arch_Site: fix transform issue 2023-02-12 22:21:03 +01:00
Uwe
a4b4bc99e0 [App] License.cpp: add missing include
- does otherwise not compile on Windows
2023-02-12 21:25:08 +01:00
wmayer
3abeb547b9 App: support of method unsetupObject in Python feature classes 2023-02-12 20:01:09 +01:00
wmayer
19420ed747 tests: add unit tests for License 2023-02-12 19:57:41 +01:00
wmayer
1a1f814a71 App: refactor license handling to reduce code duplication 2023-02-12 19:57:41 +01:00
wmayer
d6208d9b9a Part: fixes to create a NURBS for the arc of a conic
See forum: https://forum.freecad.org/viewtopic.php?t=75846
2023-02-12 19:45:00 +01:00
0penBrain
ebc5cb16a9 [Core] Add possibility to set color with tuple of integers, fixes #8344 2023-02-12 18:16:59 +01:00
wandererfan
e9e68c5bf3 [TD]fix face hatch location inSvg export 2023-02-12 11:50:20 -05:00
Roy-043
d4e76f9c07 [Draft] fix #8433 regression (#8452) 2023-02-12 14:22:52 +01:00
Adrien GUICHARD
5cb420048b Add TaackPLM_workbench_icon.svg in resources 2023-02-12 10:38:47 +01:00
alexneufeld
e9d4583f7c Gui: Add CERN OHL to default licenses list 2023-02-12 10:31:59 +01:00
ieternalleo
f5c2149fe8 Mesh: Update error message to inform of missing mesh file format upon export 2023-02-12 10:29:35 +01:00
marioalexis
7e0d84ff0b App: Fix warnings -Wignored-qualifiers 2023-02-11 14:16:46 -08:00
luzpaz
5f487cadce Draft: [skip ci] fix typo in source comment (#8434)
Fixed typo in `draftutils/gui_utils.py`
2023-02-11 21:02:27 +01:00
paul
646ceaede2 [Arch Component] Fix placement multiplication problem (re-PR) (#6617)
* [Arch Component] Fix placement multiplication problem (re-PR)

- see forum discussion : https://forum.freecadweb.org/viewtopic.php?f=23&t=67008

* Update ArchComponent.py

Manual edit to avoid merge conflicts.

---------

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>
2023-02-11 20:43:28 +01:00
wandererfan
76ffee77bc [TD]fix validation of hybrid dimension 2023-02-11 13:30:15 -05:00