kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
26,453 Commits 41 Branches 6 Tags
ea10dfd85dcff2c3e286ecbf1ab7700cb0d0f3e9
Commit Graph

1207 Commits

Author SHA1 Message Date
mwganson
faed39ded2 [PartDesign Hole] Add reversed checkbox to dialog 2020-08-22 15:32:42 +02:00
wmayer
50aa73da9d PD: [skip ci] add missing forward declaration 2020-08-10 14:10:43 +02:00
donovaly
a8ea844e0b [PD] [skip ci] add Sketch top level menu 2020-08-10 14:00:06 +02:00
donovaly
acecdd8c57 [PD] allow expression for pocket offset 
- also disable KeyboardTracking for some fields to avoid unnecessary and often time consuming recomputes while typing in
 2020-08-10 13:39:50 +02:00
donovaly
940c27288b [PD] [skip ci] disable keyboardTracking for primitives and attachment 
When modifying primitives in complex geometries having a recompute for every keystroke can be annoying. Disabling keyboardTracking fixes this but keeps the immediate preview when using the spin buttons.
 2020-08-10 10:14:17 +02:00
donovaly
81a98a4476 [PD] bind expression to pad offset 
It is strangely not possible to use an expression for a pad offset, but this works fine, see the forum for an example.

Thus allow this.
 2020-08-08 13:04:34 +02:00
luz paz
59e3ea096e Crowdin: Merge new translations [skip-ci] 2020-08-07 17:17:35 +02:00
donovaly
4ce85d39d3 [PD] patterning UI: avoid whitespace 
- also have a uniform list height in all patterning dialogs
 2020-08-06 17:05:48 +02:00
wmayer
c516bb06d3 PartDesign: [skip ci] add text of sub-menus to translation system 2020-08-06 12:22:56 +02:00
donovaly
80a88470b6 [PD] rework menu 
The menu was too long for smaller screens. Therefore pack some of its items to subitems.
 2020-08-06 12:14:27 +02:00
wmayer
a9af418698 PartDesign: [skip ci] move indexesMoved() to base class TaskTransformedParameters to avoid code duplication 2020-07-31 13:16:44 +02:00
donovaly
d5787f9bda [PD] allow to change feature order in patterns 
As discussed here: https://forum.freecadweb.org/viewtopic.php?f=27&t=48998#p420352
The pattern dialogs need a feature to change the order of the features to be patterned
 2020-07-31 11:47:31 +02:00
wmayer
94ca4388e4 PartDesign: [skip ci] set dragDropMode of list widgets of Transform panels to 'InternalMove' 2020-07-30 14:54:43 +02:00
donovaly
c5e2aba15e [PD] allow multiselection on creation of pattern 
- Since realthunder's contributions some months ago, the 4 pattern features (mirror, linear, polar, mulitransform) can handle several features at once.
This PR allows to select multiple features when creating a pattern.
(This speeds up the workflow because at the moment one has to create the pattern with one feature and subsequently add more.)

- fix dialog issue that Add and Remove button could be active the same time

- use the keyboardTracking feature to avoid unnecessary recomputes (e.g. currently 3 recomputes when inserting "12.5" to the length field of linear pattern)

- fix wrong <extends> statement in .ui files (automatically spotted and fixed by Qt's Designer)
 2020-07-30 10:56:24 +02:00
wmayer
44f42a8e2c LGTM: [skip ci] fix: Declaration hides parameter 
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
 2020-07-27 10:57:34 +02:00
luz paz
f20ab1765f Fix Crowdin typos + trim superfluous whitespace [skip-ci] 
Some issues that this PR fixes (but not all listed):  
https://crowdin.com/translate/freecad/27911/en-en#6581578  
https://crowdin.com/translate/freecad/27911/en-en#6579080  
https://crowdin.com/translate/freecad/27911/en-en#6581580  
https://crowdin.com/translate/freecad/27911/en-en#6579086
 2020-07-23 13:52:44 +02:00
wmayer
f32248997e Coverity: [skip ci] Dereference before null check 
Remove logically dead code because 'pcActiveBody' cannot be null at this stage
 2020-07-21 14:33:54 +02:00
wmayer
b480a207c0 Coverity: Uncaught exception 2020-07-20 17:34:29 +02:00
wmayer
1a16cde1f5 Coverity: Structurally/Logically dead code 2020-07-20 17:34:28 +02:00
wmayer
4a494fec69 Coverity: Dereference null return value 2020-07-20 17:34:26 +02:00
luz paz
3dfae3ba46 Merged crowdin translations 2020-07-13 14:49:45 +02:00
Zheng, Lei
5666598a6b PartDesign: change SubShapeBinder make command 
Allows making binder to another binder.
 2020-07-12 19:43:23 +02:00
Zheng, Lei
010a14a6b5 PartGui: avoid code duplication for handing TaskAttacher 
A better fix for #0004188

Delay calling setPreviewDisplayMode() in ViewProviderPrimitive::setEdit
also fixed issue of not turning off preview mode if the user cancels
editing because there is already a task dialog active.
 2020-07-12 16:03:42 +02:00
Zheng, Lei
37caf53dfd Part: fix TaskAttacher::visibilityAutomation() 
Rename Python variable 'tv' to avoid potential conflict with others
(PS. I can't reproduce error caused by this. But there is no harm doing
it either).

Handle editing attachment through an App::Link.
 2020-07-12 16:03:42 +02:00
Zheng, Lei
7fadfd0439 PartDesign: change feature DressUp behavior when used for pattern 
Repurpose DressUp.SupportTransform property to define the following
behavior,

* When disabled (default), only the dressing will be used for patterning.

* When enabled, the additive/subtractive shape of the dressed base
  feature will be used for patterning. Any dressing that is not applied
  to the based feature will be ignored.

* If the dressing is applied to non-additive/subtractive feature, then
  only the dressing will be used for patterning.

New API FreatureAddSub::getAddSubShape() is added to account for the
fact that a dressing (e.g. a fillet) can be either additive or
subtractive, which means that a DressUP feature may contain both
additive and subtractive shapes.

FeatureTransformed is modified to perform both fusion and cut if
required.
 2020-07-11 13:03:21 +02:00
wmayer
0441478d49 PartDesign: [skip ci] revert TabFocus policy for spinbox in Thickness panel 
When clicking on the spinbox it won't get the focus and thus it's not possible to override the content with the keyboard.
The user has to actively press the Tab button in order to set the focus to the spinbox before he can override the content.
This is a very annoying behaviour and it's a regression caused by b01ebbc01
 2020-07-06 14:47:21 +02:00
donovaly
062c115e6c [PD] disable keyboardTracking for dressup dialogs 
- At the moment using e.g. the thickness dialog and change from the default "1.0" to e.g. "21.3" triggers 4 recomputes. This takes a lot of time and is unnecessary. Qt offers therefore to disable keyboardTracking (and we use it already in the TechDraw workbench).

- also change the default draft angle from 1.5° to more common 10° and the step to 1° so that one can quickly get usual angles for drafts
 2020-07-04 07:00:00 +02:00
wmayer
f3b460e42e boost: fix for boost < 1.60 2020-06-15 19:38:39 +02:00
wmayer
1ee3d79d7c Qt5: 'int QFontMetrics::width' is deprecated since Qt 5.11: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations] 2020-06-12 17:51:33 +02:00
wmayer
4ec45b545e boost 1.73.0: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated 2020-06-12 17:51:33 +02:00
wmayer
c9480d7d1a PartDesign: [skip ci] fix -Wunused-variable 2020-06-10 12:52:52 +02:00
Abdullah Tahiri
11f5500716 PartDesign: closing task dialog when exiting edit mode for Primitives 
=====================================================================

fixes #4241

Problem:

PartDesignGui::ViewProvider is responsible for closing the tasks for most of PD features when exiting edit mode
(i.e. unsetEdit()).

For primitives, PartDesignGui::ViewProviderPrimitive is responsible, and neither does it or relies on its parent
VP to do it when calling unsetEdit().

Solution:

Make PartDesignGui::ViewProviderPrimitive::unsetEdit() rely on parent PartDesignGui::ViewProvider to tidy up,
including closing the task dialog.

Reference:

This is the default stack call when closing a document while a PD task using PartDesignGui::Viewprovider is active:
 2020-06-08 15:12:26 +02:00
wmayer
1e117647ff [skip ci] include missing boost header 2020-06-07 20:58:45 +02:00
wmayer
8ac6b12ee5 PartDesign: [skip ci] fix wrong property values in UI file 
set step size of angle property to 1.0
 2020-05-24 12:18:19 +02:00
wmayer
53dbc5fc2d PartDesign: [skip ci] set minimum width of labels to align the spin boxes properly in the chamfer panel 2020-05-24 11:12:08 +02:00
wmayer
5bdb40d50e PartDesign: [skip ci] set an alias PartDesign_Body_Create_New.svg for PartDesign_Body.svg 2020-05-24 08:58:45 +02:00
Abdullah Tahiri
e4a5d8b862 PartDesign: Chamfer feature corrections and improvements 
========================================================

- Correction to mustExecute() to account for the new properties
- Make properties not used by the mode as read-only.
- Gui: apply() only for construction mode valid features
 2020-05-23 12:24:08 +02:00
Armandas Jarušauskas
e1240fb18d PartDesign: Chamfer direction flipping support 2020-05-23 12:24:08 +02:00
Armandas Jarušauskas
d2d26ab8d0 PartDesign: Chamfer icon art - flip icon 2020-05-23 12:24:08 +02:00
Armandas Jarušauskas
262841bb3c PartDesign: Chamfer with multiple creation modes 2020-05-23 12:24:08 +02:00
Zolko
fc4e83ad63 setting Datum Line size manually 2020-05-13 11:23:28 +02:00
wmayer
6b022b277a PartDesign: [skip ci] fix ambiguous widget name 2020-05-12 14:30:53 +02:00
Armandas Jarušauskas
4669b6c88d Fixed issues introduced in #3456 
- Copy-paste error when setting angle dimensions.
- Max angle limit set to 180 degrees.
 2020-05-12 14:29:28 +02:00
Armandas Jarušauskas
cc82cf3e50 Added chamfer angle support to PartDesign. 2020-05-10 18:59:30 +02:00
Yorik van Havre
28b51cf28a Merged crowdin translations 2020-04-29 16:08:23 +02:00
Abdullah Tahiri
0ec3cb16cb Remove hard-coded font families 2020-04-28 14:53:28 +02:00
Adam Spontarelli
1eef7064f8 Initial addition of fcsprocket feature. This is a PartDesign tool that allows for the simple creation of ANSI standard roller chain sprockets. 2020-04-20 12:28:27 +02:00
0penBrain
f9fc96047d [PartDesign] Remove 'Set tip' from Body contextual menu ; fixes #4304 2020-04-07 19:38:01 +02:00
luz.paz
2ed5786d07 [skip-ci] Various typo fixes 
Found via codespell  v1.17.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
 2020-04-07 18:17:03 +02:00
wmayer
107831e0a7 PartDesign: [skip ci] fixes #0004254: Crash when canceling duplicate sketch in PartDesign 2020-03-24 15:15:25 +01:00