Commit Graph

72 Commits

Author SHA1 Message Date
luz paz
298c677873 Gui: Fix header uniformity, whitespace, and doxygen fixes 2020-11-26 10:14:56 +01:00
wmayer
ad7fbee066 Part: [skip ci] fix crash when closing document while face colors panel is open 2020-08-06 11:26:24 +02:00
wmayer
44f42a8e2c LGTM: [skip ci] fix: Declaration hides parameter
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
2020-07-27 10:57:34 +02:00
wmayer
b480a207c0 Coverity: Uncaught exception 2020-07-20 17:34:29 +02:00
wmayer
a0d51baaf2 PVS: V547 Expression is always true/false 2020-07-18 10:59:27 +02:00
wmayer
f3b460e42e boost: fix for boost < 1.60 2020-06-15 19:38:39 +02:00
wmayer
033ddff089 cast between incompatible function types from 'PyObject* (*)(PyObject*, PyObject*, PyObject*)' {aka '_object* (*)(_object*, _object*, _object*)'} to 'PyCFunction' {aka '_object* (*)(_object*, _object*)'} [-Wcast-function-type] 2020-06-12 17:51:33 +02:00
wmayer
4ec45b545e boost 1.73.0: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated 2020-06-12 17:51:33 +02:00
wmayer
3df91974b8 Gui: [skip ci] fix unicode handling when showing units in status bar 2020-06-04 16:27:58 +02:00
Zheng, Lei
3f2f8ce039 Gui: fix crash on selecting removing object
The crash happens if some code calls Gui::Selection().addSelect() of a
removing object in response to App::Document::signalDeletedObject.
2020-06-04 09:34:27 +02:00
wmayer
08dca736e3 Gui: let each coordinate use its own unit to avoid that the displayed values can become very huge 2020-05-30 17:16:32 +02:00
wmayer
0821649a7f Gui: implement a static function schemaTranslatePoint to avoid code duplication 2020-05-30 16:46:35 +02:00
0penBrain
b0084cd43d [FC] Status bar preselection coordinates are aware of user unit setting ; fixes #4148 2020-05-30 12:29:58 +02:00
Zheng, Lei
e6fc155591 Gui: check object existence before SelBack/Forward 2020-05-03 19:18:46 +02:00
Zheng, Lei
39959f9500 App: add new convenient class SubObjectT
Derived from App::DocumentObjectT to add support of sub object

Also some minor changes to App::DocumentObjectT

Changed Gui::SelectionChanges to make use of SubObjectT
2020-02-11 15:40:27 -05:00
luz.paz
f11783a498 src/Gui: [skip ci] fix header uniformity
This PR fixes header uniformity across all `src/Gui` files
2019-12-25 11:39:17 +01:00
asapelkin
e951094af9 use emplace_back instead of push_back where justified 2019-11-21 14:48:09 +01:00
luz.paz
1c981e8f14 Fix typos and misc. formatting [skip ci]
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml`
2019-10-21 16:02:23 -03:00
Zheng, Lei
c98549a40a Gui: fix python documents in Gui.Selection methods 2019-10-13 17:02:32 +02:00
Zheng, Lei
bf27b115c0 Gui: fix SelectionSingleton::checkSelection()
This affects sub-object selection detection
2019-10-13 17:02:32 +02:00
wmayer
bea009c1d5 fix description of 'resolve' in Selection 2019-10-13 14:32:23 +02:00
Zheng, Lei
1e69eb0d8e Gui: improve SelectionSingleton::setVisible()
Change argument to enum type. Make setVisible() robust against
unexpected selection change.
2019-10-08 10:21:06 +02:00
Zheng, Lei
94f6f984e0 Gui: fix SelectionSingleton::checkSelection() 2019-09-03 12:25:09 +02:00
Zheng, Lei
848fbf6035 Gui: allow SelectionSingleton::hasSubSelection() check for sub-element
This is used by relative link command activation for sub-element
selection
2019-08-30 14:43:04 +02:00
wandererfan
f4bb395387 [TD]Prevent crash in SelectionSingleton
- in SelectionSingleton::setVisible, if the selection changes during
  loop, a crash may occur.
- in QGraphicsScene, hiding an item changes its selected status.
2019-08-28 12:20:42 -04:00
luz.paz
0f67e8ddfa Fix typos in src/Gio 2019-08-17 15:32:49 +02:00
Zheng, Lei
49b6944a20 Gui: Selection API changes
Mostly about API changes to SelectionSingleton. Also include related
changes to SelectionObject, SelectionChange, and SelectionView.

Please check out the summary of changes [here](https://git.io/fjimC)
2019-08-17 14:52:10 +02:00
Dion Moult
7ecc9cfb21 Add python binding for setPreselect function via Selection.SetPreselection() 2019-05-08 10:26:55 -03:00
wmayer
4a1c04e059 keep selection order with Selection.getSelection() 2019-03-10 18:01:25 +01:00
Mateusz Skowroński
317bcd59c9 Use QString's multi-arg overload to save memory allocations. [-Wclazy-qstring-arg] Thanks Clazy! 2019-02-11 15:39:14 +01:00
wmayer
0c37c7f5a5 simplify creation of strings 2019-02-11 13:46:58 +01:00
luz.paz
4cfda0c3a5 Misc. typos
Found via `codespell`
2019-02-08 11:01:24 -02:00
luz.paz
d5ea453f9d Crowdin: Several more various fixes 2019-01-30 11:08:03 -02:00
wmayer
0556a2ca68 fixes 0002304: Duplicate multi selection of sketch element produces many sketches 2018-12-19 21:17:59 +01:00
wmayer
c3014fc65f fix blocking of SelectionObserver 2018-11-04 11:54:40 +01:00
wmayer
f898eafd64 move from deprecated boost.signals to boost.signals2 library 2018-10-30 19:09:03 +01:00
wmayer
ff0cacca0a fixes 0003469: FreeCAD crashes on edge selection during fillet edge operation on extruded geometry 2018-09-25 22:51:33 +02:00
wmayer
b05f234fac fix overloaded methods SelectionSingleton::addSelection 2018-09-18 12:41:02 +02:00
wmayer
5fc8368753 add convenience method addSelection(SelectionObject) 2018-09-17 17:06:58 +02:00
luz.paz
55e93745fa Misc. typo fixes
Found via `codespell`
2018-08-26 17:30:44 +02:00
Zheng, Lei
69efa47374 Selection: handle exception in observer callback
Selection callback are sometimes called while traversing Coin node tree.
If any unhandled exception is thrown while traversing the tree, FC 3D
rendering will become unstable and non-usable thereafter.
2018-08-26 17:29:14 +02:00
wmayer
a9c4bcb5d6 remove kwd argument for functions only with flag METH_VARARGS 2018-08-08 17:39:32 +02:00
wmayer
1ef069292c notify selection node about cleared pre-selection 2017-12-25 01:19:02 +01:00
wmayer
be8f0ed83d do some code clean-up and corrections in Selection class 2017-09-20 23:22:19 +02:00
Yorik van Havre
4f044dcbe4 py3: Gui: files P-Z ported to python3 2017-05-06 20:11:31 +02:00
wmayer
72ab17fb48 fix typos 2016-12-19 14:07:35 +01:00
wmayer
6d5f7650ab allow to create SelectionObject from SelectionChanges structure 2016-10-21 14:56:29 +02:00
wmayer
68ea7fdac5 fix coverity issues 2016-10-08 17:43:30 +02:00
wmayer
1df315160d remove timeout for status messages related to (pre-)selection 2016-09-10 17:26:40 +02:00
wmayer
0824c5fd3c fix Coverity issues 2016-08-21 14:03:02 +02:00