Commit Graph

17655 Commits

Author SHA1 Message Date
luz paz
ea6b736208 Arch: fix typo in ArchBuildingPart.py [skip-ci]
Found by user PMac in https://forum.freecadweb.org/viewtopic.php?f=3&t=51049
2020-10-12 11:51:13 +02:00
vocx-fc
97c2be57d1 Show: add argument to NotAContainerError class constructor
The class `NotAContainerError` is used as an exception.
Where it is used it is initialized with an argument,
but the definition didn't accept one; now we accept an argument
in the constructor.
2020-10-12 11:49:11 +02:00
vocx-fc
cfb314f279 Draft: fix mismatch of argument in get_dxf function
The name of the argument, `projection`, in the old function
is incorrect; it should be `direction`, which was the original
argument's name when this method was split into its own module
(6c00fcf).
2020-10-12 11:48:26 +02:00
vocx-fc
330a5098b5 Arch: consider DraftText objects in the section plane for compatibility
After the reorganization of the Draft Workbench,
the `'DraftText'` objects are now of Proxy.Type `'Text'`.
In the `DraftAnnotation` class the `__setstate__` method
was defined to automatically migrate the Type.

The `Arch SectionPlane` only handles `'Text'` objects. If for
some reason there is still an old `'DraftText'` object
which has not been migrated to the new Type, it won't be found.
This is corrected by adding `'DraftText'` to the list of objects
to process.
2020-10-12 11:43:37 +02:00
Roy-043
83666f1e48 Arch: 4 additional tests for ArchRoof (bug fix)
ArchRoof bug fix:
* Removed unnecessary use of FreeCAD.Vector. Renamed some functions and variables for clarity (in this description the new names are used). Reformatted the code. Moved imports to the top of the file. Updated the tooltips. Tweaked the title text "Parameters ...".
* Fixed the length of list properties bug.
* Flip direction did not work properly. The adopted solution is to reverse the edges the roof is based on.
* Added support for consecutive parallel edges.
* Added support for zero angle roof segments.
* The code now handles zero length runs without throwing an error.
* To handle triangular roofs with a zero length eave, "eave" (egde) has been turned into "eavePtLst" (list of points).
* The ridges of opposite parallel roof segments (if they do not use a relative profile) are recalculated if the sum of their runs is larger than the distance between their edges. The old version of the command would do this only if segments connected to gables and only properly if the corners between the edges of the segments and the gable were 90 degrees.
* Revised backGable and nextGable. They now call helperGable.
* Revised the 6 other back/next functions. They now call helperSloped. This also fixes several cases where cookie-cutter outlines (profilCurr["points"]) were wrong. In nextHigher, backHigher, nextLower and backLower a point was wrongly projected on the X-axis. In nextHigher the point on the higher ridge was wrongly included.
* Improved the cookie-cutter outlines for roof segments with lower overhangs and higher ridges in corners.
* Data from a relative profile is no longer used if it in turn references a relative profile.
* Changed the default idrel to -1 and changed calcMissingData to not process this value. This avoids confusion for users who are unaware of the relative profile feature.
* Introduced find_inters as a workaround for DraftGeomUtils.findIntersection. The latter finds intersections for parallel lines that share a point. Find_inters uses a modified version of getLineIntersections from DraftGeomUtils.findIntersection.
* Calling DraftVecUtils.removeDoubles later in the program flow as it does not compares the first and the last vector.
* Avoided the QTreeWidget scrolling to the top on every change, by not clearing it but updating existing items instead.
* Added self.tree.setRootIsDecorated(False). This gets rid of the 1st column's extra left margin. Removed item.setTextAlignment(0,QtCore.Qt.AlignLeft) as this did not work.
2020-10-12 11:43:04 +02:00
Roy-043
b7125d0162 Arch: ArchRoof bug fix
* Removed unnecessary use of FreeCAD.Vector. Renamed some functions and variables for clarity (in this description the new names are used). Reformatted the code. Moved imports to the top of the file. Updated the tooltips. Tweaked the title text "Parameters ...".
* Fixed the length of list properties bug.
* Flip direction did not work properly. The adopted solution is to reverse the edges the roof is based on.
* Added support for consecutive parallel edges.
* Added support for zero angle roof segments.
* The code now handles zero length runs without throwing an error.
* To handle triangular roofs with a zero length eave, "eave" (egde) has been turned into "eavePtLst" (list of points).
* The ridges of opposite parallel roof segments (if they do not use a relative profile) are recalculated if the sum of their runs is larger than the distance between their edges. The old version of the command would do this only if segments connected to gables and only properly if the corners between the edges of the segments and the gable were 90 degrees.
* Revised backGable and nextGable. They now call helperGable.
* Revised the 6 other back/next functions. They now call helperSloped. This also fixes several cases where cookie-cutter outlines (profilCurr["points"]) were wrong. In nextHigher, backHigher, nextLower and backLower a point was wrongly projected on the X-axis. In nextHigher the point on the higher ridge was wrongly included.
* Improved the cookie-cutter outlines for roof segments with lower overhangs and higher ridges in corners.
* Data from a relative profile is no longer used if it in turn references a relative profile.
* Changed the default idrel to -1 and changed calcMissingData to not process this value. This avoids confusion for users who are unaware of the relative profile feature.
* Introduced find_inters as a workaround for DraftGeomUtils.findIntersection. The latter finds intersections for parallel lines that share a point. Find_inters uses a modified version of getLineIntersections from DraftGeomUtils.findIntersection.
* Calling DraftVecUtils.removeDoubles later in the program flow as it does not compares the first and the last vector.
* Avoided the QTreeWidget scrolling to the top on every change, by not clearing it but updating existing items instead.
* Added self.tree.setRootIsDecorated(False). This gets rid of the 1st column's extra left margin. Removed item.setTextAlignment(0,QtCore.Qt.AlignLeft) as this did not work.
2020-10-12 11:43:04 +02:00
Daniel Wood
9b2b86b91f Add a task panel page for controlling turning diameters 2020-10-11 07:57:59 +01:00
Daniel Wood
dcf33dca50 Add turning selection gate 2020-10-11 07:57:59 +01:00
wmayer
aa32b9c6af Part: [skip ci] harmonizing the way to add sub-modules to Part module 2020-10-10 11:44:51 +02:00
wmayer
424eacd5f0 Part: [skip ci] fix crash when trying to convert null shape to nurbs 2020-10-09 18:54:57 +02:00
wmayer
9d31b8dab4 Part: [skip ci] port class TaskCheckGeometryResults to OCCT 7.5 2020-10-09 08:39:42 +02:00
wmayer
93a331c3ba Part: [skip ci] fix crash when trying to scale null shape 2020-10-09 08:31:48 +02:00
wmayer
12b6dd955b Part: port class BOPProgressIndicator to OCCT 7.5 2020-10-09 02:42:13 +02:00
luz paz
df93939be3 Fix various typos [skip-ci]
Found via `codespell v2.0.dev0`  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-10-08 18:21:15 +02:00
wmayer
ebe458ac20 Part: link TKStepAttr, TKStepBase and TKStep209 2020-10-08 17:24:13 +02:00
wmayer
c35dba8e34 Part/Import: [skip ci] disable use of Message_ProgressIndicator for OCC >= 7.5 due to major API changes 2020-10-08 14:48:35 +02:00
wmayer
0c1f17d516 Path: [skip ci] fix build failure on Windows if PCH is disabled 2020-10-08 10:00:31 +02:00
sliptonic
6f9e36406e Merge pull request #3934 from J-Dunn/master
PATH: G0 retraction and return speeds for grbl_post G83 expand
2020-10-07 15:15:47 -05:00
sliptonic
a9e38e591a Merge pull request #3937 from sliptonic/feature/setupreport
Path Feature:  Setup Report
2020-10-07 12:21:12 -05:00
sliptonic
37a56b64b5 Merge pull request #3936 from sliptonic/bug/finshsteplabel
Path:  change final step down label for clarity fixes #4439
2020-10-06 18:02:05 -05:00
sliptonic
82a4281adf making it a bit more forgiving of old jobs/tools 2020-10-06 13:47:13 -05:00
sliptonic
e83eada9a5 Ignore old-style tool controllers 2020-10-06 13:47:13 -05:00
sliptonic
3cfe849f68 Allow adding a material to the stock object.
Select the stock object and use the Arch Material button to add and assign
the material to the stock.

The only thing affected is the path-sanity report
2020-10-06 13:47:13 -05:00
sliptonic
01ac150212 Working html report with asciidoctor 2020-10-06 13:47:13 -05:00
Bernd Hahnebach
4948ff5ccb Arch: import IFC, support multiple styles in styled items in IFC4 2020-10-06 19:27:54 +02:00
Bernd Hahnebach
2ceeedf3bd Arch: import ifc, small fix in colors 2020-10-06 19:10:52 +02:00
Bernd Hahnebach
528b029035 Arch: import ifc, colors in IFC4 print warning not implemented 2020-10-06 19:08:48 +02:00
Bernd Hahnebach
6cb4c91ee1 Arch: import ifc, fix typo in material colors 2020-10-06 17:20:32 +02:00
Bernd Hahnebach
74a1f21b67 Arch: import ifc, fix import break if colors dictionary contains None values 2020-10-06 17:16:42 +02:00
sliptonic
54bbb4c201 change final step down label for clarity
issue #4439
2020-10-06 10:07:58 -05:00
sliptonic
8f27172316 Merge pull request #3915 from Russ4262/fix_Profile
Path: Profile - Fix rotation error and remove FinalDepth limit
2020-10-06 09:04:02 -05:00
sliptonic
a98829393a Merge pull request #3933 from sliptonic/bug/vcarvedepth
Path:  improve vcarve to add coolant mode and set z depth from base object
2020-10-06 09:01:51 -05:00
wmayer
c7b8ff16b7 PartDesign: [skip ci] remove automatic adjustment of view frustum when creating a body
In v0.17 this was needed to fix bug 2503 and was done with commit d4ff570bf9.
Now a more sensible view frustum is already set on document creation.

The automatic adjustment is even annoying now if the document is not empty and nothing is selected because
the view frustum can become too big and thus the objects appear quite small.
2020-10-06 15:32:35 +02:00
vocx-fc
f59f24fa28 Complete: do not build the Complete workbench because it is empty
If it is "built", it can be hidden by commenting out the last line
which adds it to the system:
`# Gui.addWorkbench(CompleteWorkbench())`
2020-10-06 12:34:33 +02:00
Syres916
c5284cb1c7 [Image] Very minor improvement to Report View..
..output
2020-10-06 12:01:32 +02:00
Bernd Hahnebach
7700e3267f Arch: ifc import, typo in var name 2020-10-06 10:53:56 +02:00
wmayer
01f2cae73e Part: [skip ci] work around OCCT bug
For certain OCCT versions in the file ShapeUpgrade_UnifyDomain a method of the class Precision is used but Precision.hxx is not included which can lead to a build failure.
2020-10-06 08:48:53 +02:00
Matsievskiy S.V
f544688137 AddonManager: Fix python imports
Move misplaced imports from addonmanager_macro to addonmanager_workers
2020-10-06 08:21:04 +02:00
J-Dunn
a7af3b33ae PATH: fast retraction and return speeds for grbl_post G83 expansion #3725
Ensure fast retraction and then plunge to just short off previous drilled depth at G0.  Fixes painfully slow air drilling which makes peck drilling impracticable.
https://forum.freecadweb.org/viewtopic.php?f=15&t=25604&p=435639#p435639
2020-10-06 01:23:18 +01:00
sliptonic
15b54b7b9b add coolant mode
fix Z depth
2020-10-05 18:00:47 -05:00
sliptonic
4c1ea6e911 Merge pull request #3901 from J-Dunn/master
[Path] fix 3Dsurface with countersink tools
2020-10-05 14:23:48 -05:00
sliptonic
1df5c52d69 Merge pull request #3930 from mlampert/bugfix/voronoi-32-bit-build-failure
PATH: Dealing with 32bit compile error of Voronoi interface.
2020-10-05 14:21:01 -05:00
Yorik van Havre
d262b18ab1 Merge branch 'master' of github.com:FreeCAD/FreeCAD into master 2020-10-05 17:28:42 +02:00
Yorik van Havre
76896eae88 AddonManager: Fixed missing import 2020-10-05 17:03:16 +02:00
wmayer
d178c2bf91 Part: [skip ci] expose ShapeUpgrade_UnifySameDomain to Python 2020-10-05 16:57:16 +02:00
Markus Lampert
7ea1bb0cb7 Dealing with 32bit compile error of Voronoi interface. 2020-10-04 22:44:45 -07:00
wmayer
0cc65089c4 Path: [skip ci] fix memory leak in CommandPy::getParameters()
For some background information see: https://forum.freecadweb.org/viewtopic.php?f=15&t=50583
2020-10-04 19:43:54 +02:00
Russell Johnson
aebc319ced Path: Fix rotational error for certain situations
Error discovered during recent troubleshooting of Pocket_Shape with rotation.
Initial application of new operation yields path, but subsequent changes and applications failed due to `if ...` statement removed here for the fix.
2020-10-03 13:56:46 -05:00
Russell Johnson
a8f97febad Path: Remove FinalDepth limitation for internal profile operation
Requested in forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=50341
2020-10-01 22:51:33 -05:00
Russell Johnson
2a2c727aba Path: Add debug feedback and comment 2020-10-01 22:49:48 -05:00