Commit Graph

155 Commits

Author SHA1 Message Date
wmayer
5e16cb9792 fixes #0003323: Crash when clearing transaction list 2018-01-31 23:39:13 +01:00
wmayer
004206aa0b 0003279: Error 'invalid DAG' after deleting sketch using expressions 2018-01-31 00:27:38 +01:00
wmayer
eabfffe72a fix automatic update of dependency graph 2018-01-15 22:19:05 +01:00
wmayer
9fd18ee8c3 verify iterators in partialTopologicalSort to be on the safe side
currently this can cause a crash because issue 3214 is not fixed yet
See also: https://forum.freecadweb.org/viewtopic.php?f=19&t=26295
2018-01-10 22:16:39 +01:00
luz.paz
831bf31817 Misc. typos
+ stepcode typo submitted upsream https://github.com/stepcode/stepcode/pull/372
2018-01-07 18:41:29 -02:00
Unknown
e3eca59173 Misc. typo fixes
Various workbenches
2017-12-23 14:30:30 +01:00
wmayer
bea4b2c163 fixes #0003185: Recompute should work if only subgraph is cyclic 2017-12-10 17:47:09 +01:00
wmayer
b0bbbe9421 move implementation of topologicalSort to private class DocumentP and add a parameter 2017-12-10 11:04:25 +01:00
wmayer
4e74ef0cf7 move global function to private class DocumentP 2017-12-10 10:53:34 +01:00
Eivind Kvedalen
76d3d96071 When we are restoring, don't set the Label on object creation as it will be restored later.
This is to avoid potential duplicate label conflicts.

This fixes issue #3280.
2017-11-30 16:28:41 +01:00
Eivind Kvedalen
8b4adfa513 Moved ObjectStatusLocker template class to Base/Tools.h 2017-11-30 16:28:41 +01:00
Eivind Kvedalen
dd6757bbb8 Spreadsheet: Fix for issue #3225.
Done by adding a selector function to Document::renameObjectIdentifiers(...) to ensure
that the Spreadsheet document object is not rewritten twice.
2017-11-08 23:15:16 +01:00
wmayer
d7caea2cba fix crashes in dependency walker 2017-11-08 12:12:46 +01:00
wmayer
bed779a530 method to get paths between two objects 2017-10-20 18:26:18 +02:00
wmayer
f4a25522a7 fix possible dangling pointers in function to create dependency graph 2017-10-11 13:24:32 +02:00
luzpaz
f3bf8fe919 Misc. typos
+ some are doxy others are just comment code.  
+ some minor whitespace and grammatical tweaks. 
+ app/SCL/* typos have also been submitted upstream (https://github.com/stepcode/stepcode/pull/366). So it's ok to merge them in to master.
2017-10-04 17:59:11 +02:00
wmayer
712966ff50 rename method from remObject to removeObject to be more readable 2017-09-13 18:57:38 +02:00
wmayer
9d83bf8c12 mark document objects with Destroy flag before deleting them and handle this in the link properties 2017-09-13 16:14:19 +02:00
wmayer
ca77c54d10 rename status bit 'Delete' to 'Remove' as it fits better for its purpose, add new bit 'Destroy' 2017-09-13 15:47:48 +02:00
wmayer
071763d464 fix access of dangling pointer (in case undo/redo is off)
use unique_ptr to delete object before leaving remoObject
2017-09-13 15:11:29 +02:00
wmayer
7c93459ec2 copy check for disabled or nested recomputes from old implementation of recompute() 2017-09-09 19:11:28 +02:00
wmayer
3a0c3499e5 improve whitespaces 2017-09-09 18:07:46 +02:00
Stefan Tröger
a03000cc68 Ensure touched features, which override mustExecute(), are recomputed. 2017-09-09 16:55:55 +02:00
Stefan Tröger
c14e508c74 Fix GeoFeatureGroup claimChildren in case some out-of-group item links to a child 2017-09-09 16:55:55 +02:00
Stefan Tröger
a65856c022 Ensure that GeoFeatureGroup claims children when a parent of it is deleted. fixes #0003150 2017-09-09 16:55:55 +02:00
Stefan Tröger
7829849104 Fix deleting a Part 2017-09-09 16:55:55 +02:00
Stefan Tröger
b80e0b6191 DependencyGraph: show invalid links in red 2017-09-09 16:47:07 +02:00
Stefan Tröger
9cda1b53bc Allow interchangable use of link properties and their derivatives 2017-09-09 16:47:07 +02:00
Stefan Tröger
7b72973ba6 Fix _inList tracking in case of link removal 2017-09-09 16:47:07 +02:00
Stefan Tröger
2b7e0dc327 Prevent cross GeoFeatureGroup links on recompute 2017-09-09 16:47:07 +02:00
Stefan Tröger
85125f2a49 Make InList hadling and topological sort more robust. fixes #0002871 2017-09-09 16:47:07 +02:00
wmayer
a5bf15b55d remove properties from transactions when being deleted 2017-08-28 21:20:17 +02:00
Zheng, Lei
8ffcb3215a App::Document: fix breakDependency
Fixed breakDependency to handle repetitive entries inside
PropertyLinkList
2017-08-19 18:56:24 +02:00
Markus Lampert
01bedc2415 Prevent segfault if vertex map isn't set. 2017-07-29 11:58:43 +02:00
wmayer
e4770ffa9e protect document against nested recomputes
+ convert ObjectStatusLocker into a template class to make its usage more flexible
+ add status flag 'Recomputing' and set in Document::recompute to detect and avoid nested calls of recompute
2017-07-17 18:24:10 +02:00
wmayer
90653787a6 various fixes:
+ fix typos
+ fix const correctness
+ whitespace improvements
2017-06-19 17:18:16 +02:00
Stefan Tröger
fe8e69f122 Add missing header for random numbers 2017-06-19 15:37:09 +02:00
Stefan Tröger
1ee7f94d3f DependencyGraph: Ensure OriginFeatures get in the correct subgraph 2017-06-19 15:37:09 +02:00
Stefan Tröger
e5c1f2bc70 Fix undo/redo while checking link integrity 2017-06-19 15:37:09 +02:00
Stefan Tröger
fd62ef30f3 Unify and fix group handling in geofeaturegroups 2017-06-19 15:37:09 +02:00
Stefan Tröger
c3a9d43143 DependencyGraph: grouping & unflatten is optional
Property group "User parameter:BaseApp/Preferences/DependencyGraph" has two booleans to enable subgraphing and unflatten (by default on): "Unflatten", "GeoFeatureSubgraphs"
2017-06-19 15:37:09 +02:00
Stefan Tröger
f3f1706c9f DependencyGraph: Fix colors and unflatten 2017-06-19 15:37:09 +02:00
Stefan Tröger
07f464dd60 DependencyGraph: Add colors to coordinate systems 2017-06-19 15:37:09 +02:00
Stefan Tröger
7aac49bc04 DependencyGraph: Subgraphs are identified by label 2017-06-19 15:37:09 +02:00
Stefan Tröger
2e64d043d0 DependencyGraph: Show origins correctly 2017-06-19 15:37:09 +02:00
Stefan Tröger
b230d3c962 DependencyGraph: Show GeoFeatureGroups as subgraph. fixes #0002142 2017-06-19 15:37:09 +02:00
wmayer
cf0524945e fixes #0002156: Sketcher Visualization fails to represent sketch properly 2017-06-01 12:43:41 +02:00
wmayer
c4cb4518ba replace hard-coded values with enum values 2017-05-30 15:21:23 +02:00
wmayer
397539aed2 set Restore flag also for copy&paste operation 2017-05-30 14:16:29 +02:00
Abdullah Tahiri
7b110e06d8 App:Document new status bit to mark Restoring 2017-05-30 13:01:45 +02:00