Commit Graph

29033 Commits

Author SHA1 Message Date
PaddleStroke
ece64bea29 Assembly: Make sure that when a components is deleted its joints are as well. 2024-08-12 11:43:54 -04:00
PaddleStroke
00ca22e2c5 Assembly: Fix bug where double-clicking on a joint would unselect the underlying edge. 2024-08-12 11:43:26 -04:00
Chris Hennes
e52ef2a525 GUI: Update MacOS detection macros
For GUI-specific things use Q_OS_MACOS, and for other things use
Q_OS_APPLE.
2024-08-12 11:34:39 -04:00
Chris Hennes
f846cc7acf Addon Manager: Fix Qt6 button name 2024-08-12 08:49:06 -04:00
Chris Hennes
6f849e1ce2 Merge pull request #15845 from bgbsww/bgbsww-toponamingTransformedFixes
Toponaming: Fix transformed; abstract index element name generation
2024-08-12 08:48:11 -04:00
MisterMaker
d62444e230 Update FeatureLoft.cpp (#15851)
caused compile issues on MSVC with PCH.
See
https://forum.freecad.org/viewtopic.php?t=89702
4925957185
2024-08-11 19:38:36 -04:00
Chris Hennes
7186c6861f Addon Manager: Ensure metadata exists before use 2024-08-11 14:21:28 -04:00
bgbsww
26b2631251 Toponaming: Squash to one index character in element names 2024-08-11 13:29:40 -04:00
luzpaz
b5281158f3 Fix various typos 2024-08-11 12:09:27 -04:00
bgbsww
25ba8ab223 Toponaming: Fix transformed; abstract index element name generation 2024-08-10 23:02:05 -04:00
bgbsww
99b753b006 Toponaming: Refactor out duplicated code using elementMap() 2024-08-10 10:47:01 -04:00
bgbsww
aab0b31aec Toponaming: Make FeatureThickness elementMap aware 2024-08-09 16:40:07 -04:00
PaddleStroke
8339bd9618 TechDraw: ProjGroup Fix dim disappearing on upgrade. And also scale and scaleType properties not reappearing on downgrade. 2024-08-08 10:23:07 -04:00
PaddleStroke
ef4d79a383 TechDraw: add isDimCmdActive to remove code duplicates. 2024-08-08 10:23:07 -04:00
PaddleStroke
55588b9035 TechDraw: Fix Dimension tool being active at wrong times 2024-08-08 10:23:07 -04:00
bgbsww
4925957185 Toponaming: fix loft mistake and complete test 2024-08-08 09:12:48 -05:00
bgbsww
2b97b20a03 Toponaming: Additional element map changes to transform 2024-08-08 09:09:46 -05:00
Roy-043
f6c8850e80 Draft: Fix cursor scaling (#15745)
* Draft: Fix cursor scaling

The get_cursor_with_tail function was rewritten to match the Sketcher cursor code. Hopefully this fixes the scaling issue.

Related issue:
#13696

Related forum topic:
https://forum.freecad.org/viewtopic.php?t=89494

@maxwxyz
Can you check if this code fixes the issue? Apart from the size the 'hot' pixel should be checked. If you approach a vertical line from the left or right it should get highlighted at the same distance.
2024-08-08 12:07:34 +02:00
paul
f3910b386a [DraftBind] Bug-fix Consecutive Face Touch at Corner (#15350)
* [DraftBind] Bug-fix Consecutive Face Touch at Corner

Bug-fix Consecutive face (Wall segment) touch at corner.

Forum Discussion :  https://forum.freecad.org/viewtopic.php?p=769213#p769213

* [DraftBind] Bug-fix Consecutive Face Touch at Corner


Update following commit at https://github.com/FreeCAD/FreeCAD/pull/15350

* Minor formatting changes

coding_conventions.md says variable_names_without_capitals

* Use areColinear to find problematic edge pairs

It is clearer to use `areColinear` instead of `findIntersection` to detect problematic edge pairs.

@paullee0 Please check. Thanks.

* Use Shape.section() to find touching edges

Using `areColinear` indeed does not work here.

But the `findIntersection` function is very confusing IMO. It finds intersections for collinear edges which does not make sense.

Let's use `Shape.section()` instead.

Also improved the 'ascii art' a little.

* typo

* Some minor improvements.

* [DraftBind] Bug-fix Consecutive Face Touch at Corner

Update handling closed wire(s) case

* Typo

* [DraftBind] Bug-fix Consecutive Face Touch at Corner

Further update handling closed wire(s) case :

# if wires are closed, 1st & last series of faces might be connected
# except when
# 1) there are only 2 series, connecting would return invalid shape
# 2) 1st series of faces happens to be [], i.e. 1st edge pairs touch

---------

Co-authored-by: Roy-043 <info@b-k-g.nl>
2024-08-08 11:08:59 +02:00
bgbsww
4afbe73f51 Toponaming: Fix PropertyTopoShape restore; tweak Loft test; missing TopoShape method. 2024-08-07 20:31:21 -05:00
Chris Hennes
74e5c3fafb Revert "[PD] Revert 316506f, back to shell algo for some helix cases (#15678)"
This reverts commit dcfae6a897.
2024-08-06 18:54:46 -05:00
Chris Hennes
4801300913 Merge pull request #15734 from bgbsww/bgbsww-toponamingFixTopoShapeToHaveHasher
Toponaming: make sure TopoShapes have Hashers
2024-08-05 11:17:46 -05:00
PaddleStroke
e2e613acaa Assembly: Fix migrationScript2 2024-08-05 11:09:45 -05:00
Yorik van Havre
33088e006a BIM: Fixed nativeIFC psets loading - fixes #15436 2024-08-05 11:03:49 -05:00
marioalexis
ca70e06a05 Fem: Remove callback on right click during point marker selection - fixes #13694 2024-08-05 11:03:06 -05:00
bgbsww
80045d0e88 Toponaming: add code to implement guessing missing references 2024-08-05 11:01:46 -05:00
FEA-eng
87cc683ccc FEM: Remove obsolete "Fix" property from a few examples to repair them (#15698)
* FEM: Update rc_wall_2d.py

* FEM: Update buckling_platebuckling.py

* FEM: Update equation_deformation_spring_elmer.py

* FEM: Update buckling_lateraltorsionalbuckling.py
2024-08-05 10:54:32 -05:00
Chris Hennes
1566dfa37a Merge pull request #15669 from marioalexis84/fem-link_scope_python_objects
Fem: Fix link scope for Python objects
2024-08-05 10:53:50 -05:00
Chris Hennes
ff693a4dc2 Sketcher: Modernize license text 2024-08-05 10:49:14 -05:00
Yorik van Havre
aad060c0f0 Translations (#15689)
* Updated ts files

* Merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-08-05 10:42:18 -05:00
Florian Foinant-Willig
dcfae6a897 [PD] Revert 316506f, back to shell algo for some helix cases (#15678)
* [PD] Revert 316506f, back to shell algo for some helix cases

* fix test accuracy
2024-08-05 10:40:00 -05:00
bgbsww
19b63630c6 Toponaming: reformat tnp tests 2024-08-04 17:57:38 -04:00
Syres916
c845c976aa [AddonManager] Fix regression introduced by #15676 (me)... (#15688)
* [AddonManager] Fix regression introduced by #15676...

...it disabled composite view for more than intended

* [AddonManager] Use QLibraryInfo major and minor version
2024-08-04 09:59:01 -05:00
bgbsww
c0c7bd647d Toponaming: use correct face maker 2024-08-02 21:55:51 -04:00
bgbsww
cd128984e1 Toponaming: make sure toposhapes have hashers 2024-08-02 21:42:16 -04:00
marioalexis
317a664cbd Fem: Handle PropertyError exception 2024-08-02 20:19:16 -03:00
marioalexis
db3f4f0642 Fem: Fix link scope for Python objects 2024-08-02 20:19:16 -03:00
bgbsww
e4b2bf7630 Toponaming: bring in code to fix delExternal breakage. 2024-08-02 14:13:38 -05:00
hasecilu
58241e027e Fix typos on Assembly & Sketcher WBs 2024-08-01 21:25:28 -05:00
Roy-043
4bb0a0e817 BIM: Fix calculation of wall blocks
At the corners of the base wire the joint width was wrongly added.

Forum topic:
https://forum.freecad.org/viewtopic.php?t=89504
2024-08-01 11:04:05 +02:00
hasecilu
c5408de525 BIM: Don't mark for translation names of CC licenses 2024-07-31 11:47:31 +02:00
bgbsww
a348a1bc82 Toponaming: Update tests, implement missing subtractive operation tests,
fix helix and revolution
2024-07-30 09:12:58 -05:00
Roy-043
f03f4ace11 BIM: Fix BIM Views panel open behavior on WB activation (#15617)
* BIM: Fix BIM Views panel open behavior on WB activation

Fixes #15524.

* Something obvious was missed...
2024-07-30 10:29:30 +02:00
Chris Hennes
04acc05fcb Merge pull request #15661 from FEA-eng/mesh_gmsh_quasi_quad
MESH: Add missing Gmsh 2D algorithm (Quasi-structured Quad)
2024-07-29 15:28:11 -05:00
Chris Hennes
fe702349e8 Merge pull request #15652 from kadet1090/ui-fixes
Gui: Cosmetic Fixes
2024-07-29 11:26:58 -05:00
David Carter
233fcd1416 Material: PartDesign DiffuseColor custom attribute
PartDesign features did not inherit the custom attribute for
DiffuseColors as expected. The inheritance chain was incorrect. Also
added tests to ensure it's available.

fixes #15364
2024-07-29 11:24:46 -05:00
Chris Hennes
aef0dff13a Merge pull request #15624 from marioalexis84/fem-mesh_shape_object
Fem: Improve FemMeshShape objects
2024-07-29 11:13:43 -05:00
wandererfan
325a2834b1 [TD]fix autoscale loop
- checkfit and autoscale were calculating page size differently
2024-07-29 11:08:59 -05:00
fandaL
37c765e07b FEM: FemMesh2Mesh fix quad elements 2024-07-29 11:07:18 -05:00
Roy-043
a1a6f18008 Draft: Fix snap intersection hang (#15612)
Fixes #13797.

The code as suggested by @alafr works fine and has basically been implemented.
2024-07-29 18:05:01 +02:00