Commit Graph

41859 Commits

Author SHA1 Message Date
Syres916
ef4c33fee4 [Gui] InputField correct icon visibility logic on opening a pre-completed task panel 2025-05-26 17:54:39 +02:00
Chris Hennes
e4fa55a922 CAM: Ensure float constants are single-precision (#21322)
* CAM: Ensure float constants are single-precision

* Revert suggestion

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-05-26 17:38:34 +02:00
Syres916
0e40f2dfc5 [App] Use consistent unit schema names (#21355)
* [Start] ensure user's preferred unit schema is retained after restart of application

* [App] use consistent schema names throughout the application

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [Start] Revert commit 2eea421

in preference to PR #21466

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-05-26 17:33:45 +02:00
Kacper Donat
d5a091bf0c Merge pull request #21571 from alfrix/property_editor_2
Gui: property editor do not enter edit mode if the property is read-only
2025-05-26 17:20:06 +02:00
WandererFan
4dd2313425 [TD] fix small angle dims (fix #21114) (#21208)
* [TD]fix handling of very small angle dimensions

- also remove test for too small format specifier

* [TD]lint messages

* [TD]apply review comments.
2025-05-26 17:19:19 +02:00
PaddleStroke
82696359f6 TechDraw: richannotation : Fix white text issue (#21515)
* TechDraw: richannotation : Fix white text issue

* Update QGIRichAnno.cpp
2025-05-26 17:18:21 +02:00
Benjamin Bræstrup Sayoc
ade3922a31 TechDraw: fix state handling of dimensions
- Positioning was calculated using `boundingRect` while `transformOriginPoint` was set according to `tightBoundingRect`, causing mismatch when `QGIDatumLabel` contains more than text (eg. shapes around text). Now `transformOriginPoint` and positioning calculated according to `tightBoundingRect`, and setting `transformOriginPoint` of `QGIDatumLabel` are handled by itself. This fixes an issue where the gap between dimension lines and text varied depending on dimension's angle.
- `m_lineWidth` was set in multiple locations, causing confusion and bug introduction
- If `X` or `Y` property changed, the remaining changed properties were not handled due to using `if else` rather than `if` for property change checking. This became an issue due the above mentioned simplification of `m_lineWidth` setting: if `X` or `Y` had changed (upon document restore).
- Center position was uneededly saved in variables `posX` and `posY` when it could be calculated on demand using `tightBoundingRect`. Removing this uneeded state simplfies code and lowers the risk of bug introduction due to lack of updating state.
2025-05-26 17:18:04 +02:00
Alfredo Monclus
1bb05bf987 Gui: property-editor make readonly cells look disabled 2025-05-26 07:13:44 -06:00
tetektoza
8eaaaaff50 BIM: Parse Classification in IFC correctly for conversion/type assign 2025-05-26 10:24:34 +02:00
Furgo
5386ca838a BIM: add first iteration of unit tests 2025-05-26 10:23:24 +02:00
Furgo
edc4d04a41 BIM: refactor to reduce code duplication and improved readability 2025-05-26 10:23:24 +02:00
Furgo
df2e055183 BIM: remove command now removes windows from walls
Fixes: #21551
2025-05-26 09:53:21 +02:00
Furgo
92a9b1ae54 BIM: add test for window removal from walls 2025-05-26 09:53:21 +02:00
Paul Lee
8ff5c71101 [ArchWall] Fix SetLength Error When Base Sketch has External Geom
fix #21357 error message problem

Github issue and discussion:
https://github.com/FreeCAD/FreeCAD/issues/21357
https://github.com/FreeCAD/FreeCAD/issues/21357#issuecomment-2886010914

ArchWall return error when Base Sketch has external(projected) geometry.

External projected geometry has TNP-problem, until the feature is TNP-tolerant,  support of external(projected) geometry at ArchWall is not encouraged. The reported error message is fixed in the meantime in this PR.
2025-05-26 09:49:36 +02:00
Benjamin Bræstrup Sayoc
9af522c085 TechDraw: centralize usertype constants 2025-05-25 20:42:02 +02:00
Alfredo Monclus
8be84f2a9f Gui: property editor do not enter edit mode if the property is read-only 2025-05-25 06:25:09 -06:00
mosfet80
41c750be47 Sketcher: Remove unused variables (#21504)
removed unused variables
2025-05-25 00:19:46 +02:00
David Carter
15ed1a07a9 Materials: Correct model spelling errors 2025-05-25 00:14:08 +02:00
Roy-043
96af3a5bba Draft: remove 'CTRL to snap' from tooltips (#20619)
The 'CTRL to snap' option is not the default, it should therefore not be included in the tooltips.

Additionally:
* Some obsolete info was removed.
* Some minor improvements,
2025-05-24 18:55:47 +02:00
Roy-043
98d4222253 Draft: Revise close task panels on doc close solution (#21546)
Use built-in feature to close the task panels. See #21253.
2025-05-24 10:25:40 +02:00
David Carter
8ef8f64e9b Materials: External interface refinements (#21524) 2025-05-24 08:25:44 +02:00
longrackslabs
77a11efa0b Draft: Fix typo in arc input hint ("staring" → "starting") 2025-05-24 08:24:32 +02:00
saso badovinac
a969f31573 Update codeql.yml
disable cpp scan on pull requests and enable actions scan
2025-05-23 15:10:01 +02:00
Benjamin Nauck
e4eeb66626 Merge pull request #21289 from tetektoza/fix/fix_transparency_doors_windows_ifc
BIM: Change from RGBT to RGBA for IFC
2025-05-23 14:10:47 +02:00
paul
62cc73c104 BIM - ArchWindow - Add AutoNormalReversed property 2025-05-23 12:08:33 +02:00
tetektoza
bcb8932930 BIM: Additional improvements for Activate button in BIM Views
This patch introduces a few things:
- changes Activate button to be first in the list
- puts it in bold text, also adding (Default) to point it is default
  action
- removes all of the hiding logic upon double click and leaving Activate
by default to be called after double-clicking a BuildingPart
2025-05-23 12:06:55 +02:00
Roy-043
5cb88a63d0 BIM: Revise close panel on doc close solution (#21302)
* BIM: Revise close panel on doc close solution

Use built-in feature to close the task panels. See #21253.

* Keep self.doc
2025-05-23 11:49:55 +02:00
tetektoza
41dad48e5c BIM/Help: Access DockWidgetArea QFlag enum correctly
Currently, for both Help and BIM Views panels we can get a traceback
about incorrect casting if we move the panel.

This is because the QFlag of DockWidgetArea that is being passed, as it is not
able to be parsed down to an int. Most probably some historical change
either in Qt or FC.

This error also caused to not write current BIM Views/Help panel setup
to config, resulting in the position being resetted every run.
2025-05-23 11:47:10 +02:00
Krzysztof
4590d922ff Draft: Implementation of 'Align to face' checkbox in Hatch task panel (#21332) 2025-05-23 09:42:19 +00:00
tetektoza
391a41cbda BIM: Add missing IFC attributes for both Pipe and Rebar
As the title says - those two tools missed IFC attributes, since they
used different path of initialization than other components, so this
patch makes sure we initialize those properties properly.
2025-05-23 10:50:47 +02:00
Furgo
88d9be2e10 BIM: allow deleting locked IFC properties when needed 2025-05-23 10:18:36 +02:00
Furgo
78fcaaee34 Revert "BIM: add workaround for Draft workbench test mockup"
This reverts commit 5be803863e7552f7cb96998cd682edd3c556b4be.
2025-05-23 10:14:40 +02:00
Furgo
f901477601 BIM: add workaround for Draft workbench test mockup 2025-05-23 10:14:40 +02:00
Furgo
e710617093 BIM: add basic error checking in unit test, make extrusion a solid 2025-05-23 10:14:40 +02:00
Furgo
844bdada9c BIM: add area calculation unit tests for Arch Components 2025-05-23 10:14:40 +02:00
Furgo
1107f5f364 BIM: support curved vertical edges for area calculation 2025-05-23 10:14:40 +02:00
Furgo
7fa289cae4 BIM: refactor component area calculation into a helper class 2025-05-23 10:14:40 +02:00
Furgo
cc70fee4d7 BIM: correct planar check to avoid vertical/horizontal misclassification 2025-05-23 10:14:40 +02:00
Furgo
f5737a9c5a BIM: add support for bsplines in Arch structures 2025-05-23 10:14:40 +02:00
FC-FBXL5
2c8d6529b5 TechDraw: Update LineGroup.csv (#21513)
: -> ;

It seems a colon was mistakenly used instead of a semicolon, this has been corrected.
2025-05-22 22:45:22 +02:00
saso badovinac
b43b3e9096 Update codeql.yml
Testing cpp scan on pull requests (will probably run for too long)
2025-05-22 22:40:21 +02:00
Roy-043
e5f81e4791 Draft: ShapeString fix stick font check for small character (#21522)
Fixes #21501.

For some fonts `Part.makeWireString()` returns characters that are much smaller than the given height. This would lead to a false positive for the 'sticky font' check (which checks the area of the "L" character).
2025-05-22 17:26:00 +02:00
Benjamin Nauck
333acffd66 Merge pull request #21349 from rhabacker/obj-import-lines
BIM: Add support to import lines from obj files
2025-05-22 15:19:49 +02:00
Ralf Habacker
74ad3978a0 BIM: Add support for concatenation of lines in Obj files
If a line in an obj file ends with '\', the following line is appended.
2025-05-22 12:54:35 +02:00
Ralf Habacker
5e0c109cb1 BIM: Add support to import lines from obj files
Single lines and polylines from 'l' instructions are imported as
Draft::Wire objects and grouped with an App:Part object so that
the lines contained in the obj file are included in the
corresponding object definition.

Single lines defined in the obj file within a block are converted
into a non-closed polyline if the second point of a line matches
the first point of the following line.

Fixes #21326
2025-05-22 12:54:03 +02:00
Roy-043
ec88f39f6d Draft: Tweak polygonTracker code (#21518)
Minor improvement for the `setOrigin` and `update` functions of the class.
2025-05-22 11:35:25 +02:00
Roy-043
819b1b9218 Typo in ViewProviderGeometryObject.cpp (#21517)
appearrance -> appearance
2025-05-22 11:04:10 +02:00
jffmichi
46a11b6538 Sketcher: remove surplus push_back to shapes (fixes #21499) 2025-05-22 06:24:47 +02:00
Benjamin Nauck
b119588203 Merge pull request #18961 from kadet1090/tool-hints 2025-05-21 18:46:10 +02:00
Kacper Donat
239173bcf2 Draft: Add example tool hints 2025-05-21 17:42:45 +02:00