Commit Graph

2428 Commits

Author SHA1 Message Date
Chris Hennes
f018b1dedb [DRAFT] Remove unused loop variable
LGTM is concerned about the unused loop variable in this algorithm.
While there was nothing wrong here, to eliminate the alarm the loop was
removed entirely, since Python allows the use of the multiplication
operator here to achieve the same effect.
2021-02-28 23:18:53 -06:00
Chris Hennes
283d09dc1a [DRAFT] Add call to super().__init__ where missing
Identified by LGTM. The toplevel superclass does initialize one data
member to an empty array, but this didn't appear to cause any problems.
2021-02-27 18:21:54 +01:00
Yorik van Havre
958009c2ca Merged crowdin translations 2021-02-25 13:27:48 +01:00
Yorik van Havre
5ba28fa7ff Merged crowdin translations 2021-02-24 18:07:59 +01:00
Yorik van Havre
d90c1ff72f Merge branch 'master' into Draftutils_BugFixes_01 2021-02-23 11:45:23 +01:00
David Osterberg
f39002fb07 Draft: Fix PathTwistedArray bug 2021-02-22 08:01:34 +01:00
Yorik van Havre
686df593ea Draft: Applied patch from nahshon - fixes misc errors from translation fixes 2021-02-15 15:50:45 +01:00
David Osterberg
1d2c51d66f Draft: Fix regressions in Draft array 2021-02-14 01:20:06 +01:00
wmayer
2b881cccad Draft: fix syntax errors 2021-02-13 12:14:12 +01:00
Yorik van Havre
84b8282f48 Updated ts files 2021-02-12 14:47:37 +01:00
Yorik van Havre
43feb585ad Draft: Fixed broken translations everywhere 2021-02-12 14:44:58 +01:00
paul lee
0e81e76f7d [Draft.draftutils.groups] get_windows() to support Links
FC Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=55438
2021-02-12 09:59:28 +08:00
Chris Hennes
fe7e45a7de [DRAFT] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Yorik van Havre
bcb5c8786f merged crowdin translations 2021-02-09 16:12:18 +01:00
Yorik van Havre
298004a39c Updated master TS files 2021-02-08 16:35:41 +01:00
Yorik van Havre
97dcb24c80 Merge pull request #4341 from hyarion/feature-error-handling-get_svg
[0.19] [Draft] Add better error message in get_svg for direction
2021-02-08 16:08:18 +01:00
marioalexis
7c8c5892d0 Draft: Correct the placement in scale_with_clone - fixes #0004113 2021-02-06 23:42:22 -03:00
Amritpal Singh
d9e7ee46e6 Draft: Fix bug in getCubicDimensions function 2021-02-04 22:57:31 +05:30
luz paz
ccbc13ee82 Draft: fix LGTM 'Testing for None should use the 'is' operator' alerrts
https://lgtm.com/projects/g/FreeCAD/FreeCAD/alerts/?mode=tree&ruleFocus=7900090
2021-02-03 21:58:47 +01:00
Yorik van Havre
d02a0d558e Merge pull request #4331 from chennes/openSCADFix
[Draft] OpenSCAD/DXF error: fix DXF import with no layers
2021-02-02 14:01:43 +01:00
Benjamin Nauck
d32631cc54 [Draft] Add better error message in get_svg for direction
An AttributeError is raised when `direction=Vector(0,0,0)` and obj is
an Arch::Space on line: bead9bb938/src/Mod/Draft/draftfunctions/svg.py (L799)

This patch checks if early on if the direction vector and raises a
ValueError with a description of what has gone wrong.

A caveat with this solution is that this new behaviour might break old
code which depends on that invalid directions can be used.
2021-01-31 20:24:59 +01:00
Stefan Tröger
446ce21517 Remove ExtensionProxy and rely on default Python proxy for extensions. fixes #0004534 2021-01-30 16:00:48 +01:00
Chris Hennes
77d666a48b Fix DXF import with no layers
As discussed in https://forum.freecadweb.org/viewtopic.php?f=3&t=54842, if OpenSCAD creates a DXF with no layers in it, the code that is supposed to handle that in FreeCAD has a minor type error in it that prevents the import from working.
2021-01-29 17:01:22 -06:00
Roy-043
74d5c0a88a [Draft] Fix snap to center of faces of solids
The code would only find a center snap on the face with index=0 of solids.

In V0.19 Part.getShape was introduced (line 399). But not all consequences were not fully implemented.

In the '# we are snapping to an edge' section (line 411) the code could be cleaned up. There is no need to check if the index of the edge is correct for the parent object since we are no longer dealing with a parent object. That portion was effectively dead code.

The '# we are snapping to a face' section (line 429 in the revised code) has been modified accordingly, which fixes the bug.

Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=54747
2021-01-25 15:33:36 +01:00
marioalexis
0f33a09c10 Draft: Prevent Draft_Wire from setting a single-edge wire as closed 2021-01-22 01:16:40 -03:00
Yorik van Havre
d7d20ba484 Draft: Don't snap to ImagePlanes 2021-01-12 15:31:55 +01:00
Yorik van Havre
eb549a99d3 Draft: Added import/export buttons to Annotation styles editor dialog 2021-01-05 16:54:06 +01:00
Yorik van Havre
9324b0aa56 Merge pull request #4216 from marioalexis84/draft-draftify
Draft: Replace Part.getSortedClusters by Part.sortEdges in draftify function
2021-01-04 12:33:55 +01:00
Yorik van Havre
f1b644d176 Merge pull request #4235 from marioalexis84/draft-facebinder
Draft: Fix multiple crashes when using modification functions - fixes #0004243, #0003971
2021-01-04 12:30:56 +01:00
carlopav
79aa9ed0c4 Draft: change in default Draft.makeCopy
always copy with dependencies when copying App::Part and PartDesign::Body
.
2021-01-03 15:10:29 +01:00
marioalexis
4d9e29418a Draft: Fix multiple crashes when using modification functions - fixes #0004243 2021-01-02 02:15:43 -03:00
marioalexis
60dfd2552b Draft: Replace Part.getSortedClusters by Part.sortEdges in draftify function 2020-12-29 23:21:33 -03:00
luz paz
ff96cb301e Fix typos [skip ci]
Found via `codespell v2.1.dev0`
2020-12-23 14:32:38 -05:00
Yorik van Havre
799a2e1f5d Reverting files wrongly committed with 5a974f824 2020-12-23 15:21:43 +01:00
Yorik van Havre
5a322d75cb Merged crowdin translations 2020-12-23 15:13:05 +01:00
Yorik van Havre
5a974f824c Updated ts files 2020-12-23 14:51:04 +01:00
Yorik van Havre
7da7955255 Merge pull request #4142 from DinoMesina/master
Draft: Correct placementFromDXFOCS()
2020-12-23 14:24:21 +01:00
luz paz
3b449e1ce9 Fix typo found via Crowdin [skip ci]
https://crowdin.com/translate/freecad/548/en-eu?filter=basic&value=3#6585264
2020-12-21 13:18:13 +01:00
Dino del Favero
d8ea0c9c65 Merge branch 'master' into master 2020-12-15 21:41:59 +01:00
Yorik van Havre
e672aa26b4 Draft: Small layer improvements
- Added 'Print Line Color' property
- Added 'Add new layer' context menu action to layers group
2020-12-15 16:43:33 +01:00
Yorik van Havre
8e223cdf5d Draft: Small wording fix 2020-12-15 16:41:35 +01:00
Yorik van Havre
bc4856672f Draft: Small fixes to Draft SetStyle panel 2020-12-15 16:40:16 +01:00
Dino del Favero
f948da83aa Merge branch 'master' into master 2020-12-14 22:24:50 +01:00
Yorik van Havre
c25ff3ac16 Draft: Hide undo button from modify operations 2020-12-14 15:21:25 +01:00
Yorik van Havre
fe721a1934 Merge pull request #4116 from chennes/fixAirfoilImportNumberRegex
[Draft] Fix airfoil data detection regex
2020-12-14 12:29:50 +01:00
Yorik van Havre
dd580a49ab Merge pull request #4115 from JAndersM/patch-1
[Draft] Update task_scale.py
2020-12-14 12:21:47 +01:00
Yorik van Havre
115963d79e Merge pull request #4100 from marioalexis84/draft-upgrade
Draft: Improve makeWires in upgrade function
2020-12-14 11:59:21 +01:00
Chris Hennes
50d97a3f24 Merge branch 'master' into fixAirfoilImportNumberRegex 2020-12-13 23:02:36 -06:00
Dino del Favero
736c22e8dd Updated links
Added links in english
2020-12-14 00:29:21 +01:00
Dino del Favero
d89c869124 Correct placementFromDXFOCS()
Corrected placementFromDXFOCS() function with the indications provided by Autodesk (TM)
http://docs.autodesk.com/ACD/2011/ITA/filesDXF/WS1a9193826455f5ff18cb41610ec0a2e719-7941.htm
http://docs.autodesk.com/ACD/2011/ITA/filesDXF/WS1a9193826455f5ff18cb41610ec0a2e719-793d.htm#WSc30cd3d5faa8f6d81cb25f1ffb755717d-7ff5
2020-12-13 23:59:47 +01:00