kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
28,843 Commits 41 Branches 6 Tags
f0f0124f760f1dfcfc7a49ae292bdaab9a32e482
Commit Graph

2243 Commits

Author SHA1 Message Date
Yorik van Havre
0680ad5558 Merged crowdin translations 2022-05-05 15:46:09 +02:00
Yorik van Havre
ab5a6d83a1 Updated ts files 2022-05-05 15:20:57 +02:00
Zheng, Lei
3ef438eaf0 Fix mixed line endings 2022-04-26 12:52:55 -05:00
Yorik van Havre
a4a0d11eca Merged crowdin translations 2022-04-21 14:18:33 +02:00
wmayer
922ce46506 Gui: add convenience functions to SelectionFilterGate 2022-04-19 15:04:14 +02:00
wmayer
139370a20f Sketcher: fix crash after having created a new B-Spline 
The crash might be related to issue #6324: Segmentation fault on knot insertion in older B-Spline
 2022-04-17 17:33:11 +02:00
Yorik van Havre
35bb6278ea merged crowdin translations 2022-04-13 13:47:06 +02:00
Ed Williams
c5059d4108 Replace Line with LineSegment 
It doesn't run with Line
 2022-04-08 10:45:19 +02:00
0penBrain
02cb0b8234 Sketcher: restore constraint filter if Multiple dialog is canceled 2022-04-07 12:30:36 +02:00
Yorik van Havre
cb9dda7084 Merged crowdin translations 2022-03-31 11:41:28 +02:00
Chris Hennes
1ee046788d Sketcher: PR6497 move return statement to new line 2022-03-29 13:25:06 -05:00
Chris Hennes
b405de05df Sketcher: PR4556 Step 3: sort QGridLayout by row-col 2022-03-28 10:43:22 -05:00
Chris Hennes
b134322748 Sketcher: PR4556 Step 2: remove native=true 2022-03-28 10:43:21 -05:00
wmayer
8e19f83803 Sketcher: include header with export macros 2022-03-24 21:09:14 +01:00
wmayer
97330443a2 All: modernize C++11 
* replace deprecated headers
 2022-03-23 22:44:18 +01:00
wmayer
ead5154b18 Sketcher: modernize C++11 
* use nullptr
 2022-03-23 19:26:15 +01:00
Yorik van Havre
1dd773e7b3 Translations: Merged crowdin strings 2022-03-23 10:37:50 +01:00
Uwe
3c96daf105 [Sketch] remove Python.h and Xerces 
seems not to be necessary anymore
 2022-03-21 02:51:57 +01:00
wmayer
cf7fd5d2ac lgtm: removes unused imports in Python scripts 2022-03-20 23:00:55 +01:00
wmayer
c9a0fae9db lgtm: [skip ci] FIXME comment 
Change FIXME or remove it
 2022-03-20 16:51:23 +01:00
wmayer
2ad512f14b Sketcher: [skip ci] close directory in unit test 2022-03-19 13:54:59 +01:00
Abdullah Tahiri
c4b17c5f2b Sketcher: Fix edit curve drawing for bounded curves 2022-03-15 13:16:48 +01:00
Abdullah Tahiri
89bf7f3d0b Sketcher: DrawSketchHandler draw multiple edit curves 
=====================================================

Extension of the framework to draw an arbitrary curve in draw sketch handlers, so that
a plurality of curves can be handled.

DrawSketchHandler is extended to additionally offer drawing several curves:
- void drawEdit(const std::list<std::vector<Base::Vector2d>> &list);
- void drawEdit(const std::vector<Part::Geometry *> &geometries);

A new class, CurveConverter, enables to convert individual Part::Geometry or vectors of them
to appropriate vectors or list of vectors of Vector2d representing the curves. This can be
used in a specific DrawSketchHandler to combine Part::Geometries and arbritary curves.
 2022-03-14 16:02:49 +01:00
Yorik van Havre
6efe74a554 Merged crowdin translations 2022-03-14 12:21:01 +01:00
wmayer
0054cbddaa Fix coverity issue: 
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
 2022-03-14 11:35:04 +01:00
Abdullah Tahiri
2908150282 Sketcher: Some code comments 2022-03-13 19:28:38 +01:00
Abdullah Tahiri
8c35a895eb Sketcher: Redraw constraints on wheel event 
===========================================

https://forum.freecadweb.org/viewtopic.php?p=577585#p577585
 2022-03-13 11:33:52 +01:00
Ajinkya Dahale
76029a5b2d [Sketcher] Fix "toggle internal geo" on multi-selection 
Some deleted GeoIds can stay in selection and GeoIds can change as some objects
are deleted.
 2022-03-13 06:58:40 +01:00
Abdullah Tahiri
a5d0de0994 Sketcher: Coverity 332695 - unlikely array indexing with negative value 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
4185b8b849 Sketcher: Coverity 332679 - logically dead code removed 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
d60da72b6e Sketcher: Coverity 332685, 332686, 332696 
=========================================

Detected by coverity as unchanged variable (constant intended).

It was actually an unnecessary variable that prevented correct command committing.
 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
fb87709193 Sketcher: Coverity 350601 - possible resource leak 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
c7367dc167 Sketcher: Coverity 350637 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
8a20f1a071 Sketcher: Coverity 350641 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
e48d3e355d Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Abdullah Tahiri
a6e67dafa2 Sketcher: BSpline code review and fix 
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
 2022-03-12 15:47:50 +01:00
Ajinkya Dahale
c596c2fe3d [Sketcher] Constrain first pole when created 
By doing this, duplicate radius constraints are not made when deleting and
redefining second pole.
 2022-03-09 16:43:47 +01:00
Ajinkya Dahale
0f093f4221 [Sketcher] Safeguard against spurious pre-selection 
Preselection is sometimes not updated under some circumstances
1. when deleting an object through python;
2. before autoconstraint when deleting previous pole in bspline creation mode.

When the preselected curve is the deleted object, segfault/crash can happen.
 2022-03-09 16:43:47 +01:00
Ajinkya Dahale
1d9dd035e7 [Sketcher] Redraw correctly on pole delete in "create b-spline" 
This ensures that the last preview line drawn is always at the cursor and that
the coordinates are always w.r.t. the last defined pole.
 2022-03-09 16:43:47 +01:00
Uwe
9654786c67 [Gui] Quarter: remove unused includes 2022-03-09 01:12:15 +01:00
wmayer
6193fc9cdb Sketch: [skip ci] fix linking error with MSVC 
For more details see: https://forum.freecadweb.org/viewtopic.php?f=10&t=66939
 2022-03-09 01:11:15 +01:00
Uwe
bda12907de [Gui] rename the Qt header list 2022-03-07 20:35:38 +01:00
wmayer
1ca7429705 Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Yorik van Havre
7653a9473d Merged crowdin translations 2022-03-07 14:55:22 +01:00
Ajinkya Dahale
c7546287d2 [Sketcher] Check for b-spline before starting knot insertion "mode" 
The DrawSketchHandler will otherwise give confusing error messages.
 2022-03-07 14:27:28 +01:00
Ajinkya Dahale
6eedd0f9c5 [Sketcher] Remove "incomplete" from insert knot command 
I had kept the qualifier there when developing the tool and forgot to remove it. At this time the tool is fairly well-developed.
 2022-03-06 16:25:08 +01:00
Ajinkya Dahale
47a040537b [Sketcher] Allow deleting last knot during B-Spline creation 2022-03-06 16:14:07 +01:00
Ajinkya Dahale
00ef0e0504 [Sketcher] Reduce duplicate code in DrawSketchHandlerBSpline 2022-03-06 16:14:07 +01:00
wmayer
95c70e7f4c App: use forward declarations 2022-03-04 21:09:46 +01:00
wmayer
4ae1ca58d1 App: use forward declaration to reduce compile time 2022-03-04 17:27:53 +01:00