Commit Graph

39444 Commits

Author SHA1 Message Date
Ajinkya Dahale
f0f70daa0e [Sketcher][test] Add and use helper function to get points of interest 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
6c3d2eff64 [Sketcher] Use variable for frequently used static cast in trim 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
b2c806d227 [Sketcher] Remove some commented code from SketchObject::trim()
...and replace with a TODO
2024-12-04 00:57:41 +05:30
Ajinkya Dahale
d8a86e4e9d [Sketcher] Remove some unneeded comments 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
0b32db53ed [Sketcher] Use switch-case in getPointForGeometry()
Minor readability improvement.
2024-12-04 00:57:41 +05:30
Ajinkya Dahale
5262482bc4 [Sketcher] Refactor SketchObject::trim()
1. Use `Part::GeomCurve::createArc()`
2. Refactor constraint logic in `trim`
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
1453d5680a [Part] Add methods to create an arc of the curve 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
1cee07cb26 [Sketcher] Add some utility functions to Sketcher::Constraint
`involvesGeoId`, `invovesGeoIdAndPosId`, `substituteIndexAndPos`
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
0d27efbc2f [Sketcher] Some trivial for loop changes in SketchObject 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
ca989f73a2 [PartDesign] Fix TestTopologicalNamingProblem
Issue caused by refactor of `SketchObject::trim()`.
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
7d8a8b7cc8 [Sketcher] Attempt to fix toponaming issue on trim refactor
TNP fix algorithm doesn't seem to like when edge with geoId 0 is deleted/made
construction after new geometry is added. Instead, we just ensure that one of
the newly added geometries becomes geoId 0 instead.

Making a `generateId(const Part::Geometry*)` was part of earlier attempts, but
still appears to remain relevant. This part can be reverted if necessary.
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
263331f6fb [Sketcher] Refactor SketchObject::trim()
DO NOT MERGE because not complete: not all constraints are not transferred.

Includes:

* Adjust `deriveConstraintsForPieces` for trim
* Make sure new points are constrained on the cutting edges
* Add constraints at trim end(s) dependent on pre-exisiting ones with cutting curve(s). Also change tests to reflect that auto-coincidence can now be applied to non-periodic curves as well.

Known issue(s):
* Some redundant constraints may be added under certain circumstances (e.g. in
presence of perpendicular-via-point)
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
c823a6b270 [Sketcher] Refactor SketchObject::split() 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
b991c2fbc2 [Sketcher] Add tests for split and trim
Includes:
* Tests for splitting and trimming of various types of curves
* Assertions on constraints expected to be added on these curves
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
423fb77e1f [Sketcher] Refactor SketchObject::AutoLockTangencyAndPerpty() 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
4cc21e26e1 [Sketcher] Refactor SketchObject::delGeometry()
Just dropped cognitive complexity to 25.
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
5f86d7f5a8 [Sketcher] Refactor SketchObject::getPoint()
...to reduce cognitive complexity.

Use templates to break longer functions. Also makes it possible to avoid
repetition of type-checking logic.
2024-12-04 00:57:39 +05:30
Ajinkya Dahale
311ac3591c [Sketcher][test] Add unit tests for SketchObject::getPoint() 2024-12-04 00:57:39 +05:30
Max Wilfinger
77ba6eed4f Update stale_issues.yml
Remove print outputs
2024-12-03 20:10:27 +01:00
Aik-Siong Koh
3326c33d83 Assembly: Simulation implementation 2024-12-03 20:07:04 +01:00
Max Wilfinger
4a2edae421 Update stale_issues.yml
fix label selection
2024-12-03 19:59:03 +01:00
Max Wilfinger
e2b36e583b fix stale action.
Add .yml extension and move to workflow folder.
2024-12-03 18:43:30 +01:00
Yorik van Havre
41ca58bf7c BIM: Support for property sets in Native IFC (#18067)
* BIM: UI to add properties and psets to IFC objects

* BIM: Support native IFC objects in BimProperties

* BIM: Support removing IFC properties

* BIM: Fixed lint issues
2024-12-03 16:08:27 +01:00
Paul Lee
6a92b77632 [ArchWall] Further fix dumps()
Noted simply super().dumps() won't work as original method return dumps information.
2024-12-03 15:19:11 +01:00
Roy-043
284bb80412 BIM: import ToDo from correct file (#18221)
* BIM: import ToDo from correct file

* Oops, forgot to save some files.
2024-12-03 15:18:06 +01:00
wmayer
7fdc3b807a Fix compiler warnings 2024-12-03 10:16:08 +01:00
Ladislav Michl
0ee3c9f8e6 Base: Drop QString-std::string conversion functions from Tools
Convenience helpers function Tools::toStdString and Tools::fromStdString
were implemented for Qt4 or older to perform utf8 aware conversion as
QString::toStdString/QString::fromStdString were using toAscii/fromAscii
internally (see https://dreamswork.github.io/qt4/classQString.html).

Since Qt5 QString uses toUtf8/fromUTf8, which makes the helper functions
obsolete (see https://doc.qt.io/qt-5/qstring.html#fromStdString).
2024-12-02 23:30:53 -05:00
Vincent Belpois
f9d1391588 Sketcher: remove auto-generated 'enum value' comments 2024-12-02 23:27:26 -05:00
PaddleStroke
f6268ffd28 Assembly: Insert new part (#17922)
* Assembly: Joint Object : encapsulate the joint creation widget such that the task can be subclassed and ui customized by other commands.

* Assembly: Insert New Part

* Update src/Mod/Assembly/CommandInsertNewPart.py

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

---------

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
2024-12-02 18:34:02 +01:00
Max Wilfinger
7b7db5be0e add action/stale to keep the GitHub backlog tidy 2024-12-02 12:31:26 -05:00
Benjamin Bræstrup Sayoc
36f2aa6152 [TechDraw] Translations and grammer (#16301)
Co-authored-by: WandererFan <WandererFan@gmail.com>
2024-12-02 12:27:39 -05:00
Jacob Oursland
027581e367 CMake: modernize to use CMAKE_<LANG>_COMPILER_LAUNCHER for ccache. 2024-12-02 12:24:50 -05:00
Pieter Hijma
4c4fe8cc75 Gui: Fix VarSet dialog 2 digit problem 2024-12-02 12:17:56 -05:00
Rotzbua
f0d07f6310 feat(win): add registry for silent uninstall
Entry is recommended to support the silent uninstall process without knowing the arguments.
https://nsis.sourceforge.io/Add_uninstall_information_to_Add/Remove_Programs#Recommended_values
2024-12-02 12:16:54 -05:00
PaddleStroke
b29f2cdfe2 Assembly: Make ExplodedView: a group extension. So that we don't mimick group. Fixing the delete exploded view group issue 2024-12-02 12:14:43 -05:00
Fabio Rossi
18f63edadb add local OndselSolver includes only when not external 2024-12-02 12:04:54 -05:00
Florian Foinant-Willig
70184ba59d PartDesign: decouple refine and other geometric computation (#17008) 2024-12-02 10:57:30 -06:00
Benjamin Nauck
e5c2c81685 Move back the assembly util functions to AssemblyUtil (#18020)
* Move back util functions to AssemblyUtils again

* Add getPropertyByName<T>() helper

* Improve constness in AssemblyUtils

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-12-02 10:48:48 -06:00
Yorik van Havre
8fb4be6108 BIM: Set opening name - fixes #16948 2024-12-02 11:44:52 -05:00
Yorik van Havre
8ba34888fd BIM: ensure the Base has the correct type (#17264)
* BIM: ensure the Base has the correct type - fixes #16409

* BIM: refactor according to chenne's comment
2024-12-02 10:44:11 -06:00
Chris Hennes
d2b64f8fd6 Merge pull request #17826 from jbaehr/cam-fix-rename-cw-ccw-climb-conventional-main
CAM: Port #17655 to main: "Fix CW/CCW to Climb/Conventional rename"
2024-12-02 11:41:40 -05:00
Roy-043
91482cb38d Solve merge conflict
OK, there was indeed a merge conflict due to reformatting.
2024-12-02 11:35:28 -05:00
luzpaz
ffd3a79751 Spreadsheet: use 'text' instead of 'foreground' in tooltip (#18018)
* Spreadsheet: use 'text' instead of 'foreground' in tooltip
2024-12-02 10:32:12 -06:00
Roy-043
7541371779 Pattern name Diamant -> Diamond 2024-12-02 11:40:01 +01:00
Roy-043
fa65fcce0d Draft: Display default file and pattern in hatch task panel
Fixes #18197.
2024-12-02 11:40:01 +01:00
martinRenou
6bf372aef6 Fixing OfflineRenderingUtils.guidata on BIMExample.FCstd 2024-12-02 11:36:39 +01:00
wmayer
63ad7d3fea Gui: Do not ignore alpha channel when converting QImage to SoSFImage
Fixes #18213: Sketcher constraints have black box backgrounds
2024-12-01 20:14:00 -05:00
Stephen Hurd
a8ecf5c517 Fix compile on FreeBSD with spnav
If spnav is installed on a FreeBSD system, it will be detected,
but the build will fail.  With this change, it both builds
successfully and works on FreeBSD.
2024-12-01 10:40:30 +01:00
mosfet80
be3ad26140 Disable python2 support
Disable python2 support
2024-12-01 10:39:48 +01:00
wmayer
870424995c RE: Fix dialog title 2024-11-30 18:52:23 +01:00