Commit Graph

26846 Commits

Author SHA1 Message Date
wmayer
f6f21f4fa6 Mesh: Fix several coverity issues:
* CID 350557: Out-of-bounds read (false-positive)
* CID 316517: Uninitialized scalar variable
* CID 316519: Uninitialized scalar variable
* CID 316547: Uninitialized scalar variable
* CID 316556: Uninitialized scalar variable
* CID 350614: Uncaught exception
* CID 350606: Uncaught exception
* CID 332681: Using invalid iterator
2022-03-13 14:58:14 +01:00
wmayer
76d1180283 Fem: Fix several coverity issues:
* make SelectionChangeModes an enum class
* CID 350596: Uninitialized scalar field
* CID 350572: Uncaught exception
* CID 350647: Uncaught exception
2022-03-13 14:09:04 +01:00
wmayer
2dc78804b6 Core: Fix several coverity issues:
* CID 350582: Big parameter passed by value
* CID 350639: Big parameter passed by value
* CID 305234: Uncaught exception
* CID 316529: Uncaught exception
* CID 350597: Uncaught exception
* CID 350623: Uncaught exception
* CID 332690: Uncaught exception
* CID 332700: Unchecked return value
* CID 350576: Uninitialized scalar field
* CID 350587: Uninitialized scalar variable
* CID 192606: Uninitialized scalar field
* CID 332699: Uninitialized pointer field
* CID 350561: Dereference null return value
* CID 350610: Dereference null return value
* CID 350567: Dereference after null check
2022-03-13 13:53:32 +01:00
Anders Torger
08552c6e68 Apply multi-thread configuration for Calculix also when started via task panel 2022-03-13 13:32:30 +01:00
Uwe
fd11686fe4 [Gui] QSint: remove unused headers 2022-03-13 12:59:11 +01:00
wmayer
68b92c504f Fix several coverity issues:
* CID 350617: Dereference after null check
* CID 350585: Out-of-bounds read
* CID 350624: Resource leak
* CID 332701: Uncaught exception
* CID 350642: Uninitialized scalar field
* CID 350590: Uninitialized scalar field
* CID 350629: Uninitialized scalar variable
* CID 350602: Uninitialized scalar variable
* CID 350564: Uninitialized scalar variable
* CID 350548: Uninitialized scalar variable
2022-03-13 12:12:49 +01:00
wmayer
02bd57ac82 PD: Fix several coverity issues:
* CID 350622: Negative array index read
* CID 350613: Negative array index read
* CID 166163: Negative array index read
* refactor Hole::updateDiameterParam()
2022-03-13 12:10:01 +01:00
Abdullah Tahiri
8c35a895eb Sketcher: Redraw constraints on wheel event
===========================================

https://forum.freecadweb.org/viewtopic.php?p=577585#p577585
2022-03-13 11:33:52 +01:00
Abdullah Tahiri
85cf3ca514 Gui: Pass wheel event to viewprovider
=====================================

https://forum.freecadweb.org/viewtopic.php?p=578857#p578857
2022-03-13 11:33:52 +01:00
wmayer
33577a087f Robot: [skip ci] add header with export macros 2022-03-13 08:37:58 +01:00
Ajinkya Dahale
76029a5b2d [Sketcher] Fix "toggle internal geo" on multi-selection
Some deleted GeoIds can stay in selection and GeoIds can change as some objects
are deleted.
2022-03-13 06:58:40 +01:00
sliptonic
b0d19d28d7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
2022-03-12 19:05:39 -06:00
Uwe
393164505f [3rdParty] SalomeMesh: fix parameter typos found by the spellchecker CI 2022-03-13 02:00:52 +01:00
Uwe
131a8d038a [Assembly] fox typos in element names
all found by the spellchecker CI
2022-03-13 01:32:27 +01:00
sliptonic
a10fd46b09 Merge pull request #5440 from voneiden/path-array-improvements
Path: Path Array dressup compatibility
2022-03-12 18:21:40 -06:00
Uwe
f8d41639d3 [Gui] QSint: some sorting of headers 2022-03-12 23:57:14 +01:00
mwganson
3e18c76d4f PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Anders Torger
65718f0e51 Add General.NumThreads = CPU core count setting to Gmsh
settings file to enable multi-threaded meshing (much faster
for larger models)
2022-03-12 23:26:55 +01:00
wmayer
4547e989ea PyCXX: remove use of std::iterator that is deprecated since C++17 2022-03-12 22:22:00 +01:00
Matti Eiden
af8b6fba07 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Abdullah Tahiri
a5d0de0994 Sketcher: Coverity 332695 - unlikely array indexing with negative value 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
4185b8b849 Sketcher: Coverity 332679 - logically dead code removed 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
d60da72b6e Sketcher: Coverity 332685, 332686, 332696
=========================================

Detected by coverity as unchanged variable (constant intended).

It was actually an unnecessary variable that prevented correct command committing.
2022-03-12 21:14:19 +01:00
Abdullah Tahiri
fb87709193 Sketcher: Coverity 350601 - possible resource leak 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
c7367dc167 Sketcher: Coverity 350637 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
8a20f1a071 Sketcher: Coverity 350641 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Uwe
c20c6525b4 [3rdParty] libE57: fix comment typos found by the spellchecker CI 2022-03-12 20:20:18 +01:00
Uwe
c30e485ca9 [skip CI] fix inconsistent line endings in 2 files
was reported by MSVC
2022-03-12 20:12:19 +01:00
Uwe
9aec53c1cf [skip CI] [3rdParty] libE57: fix comment typos found by the spellchecker CI 2022-03-12 19:52:29 +01:00
Uwe
f217ff4174 [zipios] fix comment typos found by the spellchecker CI 2022-03-12 19:51:21 +01:00
Uwe
fdfb47863b [skip CI] [Tools] wxWidgets: fix inconsistent line endings 2022-03-12 19:42:07 +01:00
Uwe
bd77ff03ce [skip ci] [Gui] fix a typo 2022-03-12 19:19:16 +01:00
Uwe
5f33e020b7 [skip ci] [3rdParty] SMESH: fix comment typos found by the spellchecker CI 2022-03-12 19:18:12 +01:00
Russell Johnson
dd76cabb34 Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug]
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
2022-03-12 12:18:09 -06:00
Uwe
6fd8206849 [3rdParty] SalomeMesh: fix more comment typos found by the spellchecker CI 2022-03-12 19:02:37 +01:00
Abdullah Tahiri
e48d3e355d Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Uwe
3e156aa5eb [3rdParty] SalomeMesh: fix comment typos found by the spellchecker CI 2022-03-12 18:38:53 +01:00
Uwe
bd3f45a208 [CXX] uniform inconsistent line endings 2022-03-12 18:29:51 +01:00
Uwe
426fdbd502 [CXX] fix typos found the spell CI 2022-03-12 18:25:35 +01:00
Uwe
a9b510f640 [Assembly] fix typos found by the spellchecker CI 2022-03-12 17:52:33 +01:00
Uwe
eb8636bb4e [3rdParty] fix typos found by the spellchecker CI 2022-03-12 17:49:37 +01:00
Uwe
06c9907982 [Robot] fix some typos found by the spellchecker CI 2022-03-12 17:46:48 +01:00
Abdullah Tahiri
a6e67dafa2 Sketcher: BSpline code review and fix
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
2022-03-12 15:47:50 +01:00
Uwe
1e852e6d6b [Part] remove unused variable
MSVC complained about it
2022-03-12 15:44:27 +01:00
Wanderer Fan
12f0736189 [TD]fix 2 edge angle Dim special case 2022-03-12 08:55:35 -05:00
Chris Hennes
84bc5ea5d1 Test: Add first tests for Metadata 2022-03-11 20:15:44 -06:00
Chris Hennes
633449f8f7 Addon Manager: Fix window focus issues 2022-03-11 20:07:20 -06:00
mwganson
72e06ae529 Part: 2doffset fix crash by chacking for null shape before adding with builder.Add() 2022-03-12 02:48:22 +01:00
Zheng, Lei
b47e6723dc PD: add SubShapeBinder 'Refine' property
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
2022-03-12 02:45:13 +01:00
Zheng, Lei
e56bcbc924 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00