Commit Graph

3190 Commits

Author SHA1 Message Date
PaddleStroke
fa0fdf22cf Sketcher: Dimension: Fix constraint switching. Refactor a little bit by adding finishDimensionCreation to reduce code copies. 2024-07-02 09:49:47 +02:00
Chris Hennes
2411f9f3b3 Merge pull request #14461 from AjinkyaDahale/sk-fix-12592-bsp-by-knot-trim
[Part][Sketcher] Fix some B-spline trimming issues
2024-07-01 11:28:50 -05:00
FEA-eng
2abe477651 Sketcher: New carbon copy icons (#15074)
* Sketcher: Delete src/Mod/Sketcher/Gui/Resources/icons/geometry/Sketcher_CarbonCopy.svg

* Sketcher: Delete src/Mod/Sketcher/Gui/Resources/icons/geometry/Sketcher_CarbonCopy_Constr.svg

* Add new carbon copy icon

* Add new carbon copy constr icon
2024-07-01 11:00:07 -05:00
Max Wilfinger
e490531510 Activate Part/Part Design check and refine preferences by default (#14406)
* Activate Part/Part Design check and refine preferences by default

* added bool in .ui

* Update tests

* Fix Sketcher tests
2024-07-01 10:50:42 -05:00
bgbsww
d65ee84ff2 Cleanup 2024-06-28 22:24:30 -04:00
pre-commit-ci[bot]
54920e6611 Review cleanups 2024-06-28 11:57:43 -05:00
bgbsww
a674729dd3 Toponaming: Cleanups 2024-06-28 11:57:43 -05:00
Zheng, Lei
7a4bc95d47 Toponaming: Transfer in missing Code for BaseFeatures and Sketches 2024-06-28 11:57:43 -05:00
Ajinkya Dahale
333ca836c0 [Sketcher] Delete point-on-object on trimmed portion
This could cause undesirable shape change, especially in B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
de61b9dc9f [Sketcher] Fix some issues with trimming splines
1. Transfer point-on-object to the correct resulting curve: Currently the
constraint remains on the "start" curve created after the trim.
2. Expose internal geometries of both resulting B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
7c15affce6 [Sketcher] Rearrange directives to appease syntax highlight
Spacemacs doesn't handle the braces flow very well. This commit can be dropped
if necessary.
2024-06-24 21:56:58 +05:30
Syres916
8bf54ad82f [Sketcher] Correct default OVP and Geometry Creation colors... (#14763)
* [Sketcher] Correct default OVP and Geometry Creation colors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-24 11:08:28 -05:00
Chris Hennes
e60d43fcdc Merge pull request #14386 from maxwxyz/sketcher-draw-style
Sketcher: Changes override draw style when entering sketch edit mode.
2024-06-24 10:48:19 -05:00
Chris Hennes
926fd370b1 Merge pull request #14079 from Ondsel-Development/sk_bspline_ovp
Sketcher: BSpline DSH: implement OVP/widget
2024-06-24 10:38:15 -05:00
CalligaroV
4a486b21ed Sketcher: fix external edges selection
* fix selection from Sketcher Task Panel
 * fix selection from 3D View
 * Synchronize selection between Task Panel and 3D View

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
2024-06-24 10:35:54 -05:00
Max Wilfinger
d2491541e1 Rename OVP preference options 2024-06-23 12:29:19 -05:00
wmayer
f6e67a009d Fix several compiler warnings
* -Wmaybe-uninitialized
* -Wunused-parameter
* -Wunused-variable
* -Wnonnull
* -Wstringop-truncation
* -Wstringop-overflow
2024-06-19 21:14:23 -05:00
Chris Hennes
a36a60d29d Fem/Sketcher: Fix missing PreCompiled.h files 2024-06-18 08:05:32 -05:00
bgbsww
2d22e7a21a Toponaming: Fix crash with invalid external geometry 2024-06-17 11:31:04 -05:00
Mihail Dumitrescu
77eedb84f8 Fix importing arcs and elliptical arcs as external geometry.
Fix importing elliptical arcs issue #8700.
Fix importing arcs into sketches in the case where they project as elliptical arcs.
Fix a discontinuity that happens when an external arc projects down to a segment. The segment end points should not jump around if the projection angle changes from 89.9 to 90 degrees.
When handling external geometry compare points for equality in a consistent way and remove some dead code.
2024-06-17 11:04:52 -05:00
Alexandre Prokoudine
a98d7eb288 Adjust names of two Sketcher tools to make their functions discoverable
Users report that they have a hard time figuring out that 'Array transform' does
movement/translations, and 'Polar transform' does rotation. Hence this
adjustment of their user-visible names.
2024-06-17 10:57:10 -05:00
PaddleStroke
177673a056 Sketcher: BSpline DSH: implement OVP/widget 2024-06-17 16:52:24 +02:00
PaddleStroke
4d15b8f66a Sketcher: Fix circle diameter OVP 2024-06-13 14:51:48 -05:00
PaddleStroke
22a98d81f0 Sketcher: - Give focus to the MDI so that keyboard events are caught after starting edit. Else pressing ESC right after starting edit will not be caught to exit edit mode.
- After tool handler is purged, give back focus to MDI to make sure VPSketch receive the keyboard event. Else if user start a tool, dismiss it with ESC, then press ESC again to exit edit mode it won't be detected.
2024-06-13 14:44:30 -05:00
PaddleStroke
e6b18dc381 Sketcher: polygone DSH, typo fix 2024-06-12 10:57:43 +02:00
bgbsww
d467236564 Guard all uses of basic_random_generator for thread safety 2024-06-10 11:10:57 -05:00
PaddleStroke
833e9cc8ab Sketcher: Fix default value of dimConstrDeactivatedColor 2024-06-10 11:09:36 -05:00
mosfet80
62279d083d [mod] clean (#14378)
* [mod] clean

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-10 11:07:14 -05:00
Emmanuel Obrien
a7e1760bfb Speedup sketcher item selection
Selecting lots of elements in the sketcher slows down quadratically because we were redrawing the entire element list widget for each element.
2024-06-10 10:35:32 -05:00
Kacper Donat
8def94e6f8 Gui: Update sketcher colors after file load
This commit introduces AutoColor property for sketches that when
enabled ensures that sketches are updated with the color of user
preference. It ensures that sketches from different users will be
still visible on different themes.

To ensure backward compatiblity migration strategy is to compute default
value for this property based on the color. If it is non-white (the
default value in FreeCAD) we assume that the change was inentional and
that it should be kept as-is turning automatic coloring off. In other
cases it is enabled by default.

Fixes: FreeCAD#13980
2024-06-03 11:15:36 -05:00
Chris Hennes
696196d8f0 Update translations 2024-06-03 11:04:42 -05:00
Chris Hennes
e11bafc715 Merge pull request #14337 from wwmayer/refactor_sketch_analysis
Sketch: Refactor SketchAnalysis
2024-06-03 10:49:30 -05:00
howie-j
a4b97e29d6 Fixes #12384 2024-06-03 10:43:18 -05:00
Max Wilfinger
4e8f3f0381 Added preference for disabling shaded override draw style when entering sketch edit mode.
Storing previous override draw style and applying it when leaving the sketch.
2024-05-30 21:07:30 +02:00
Max Wilfinger
5c7d287f6b Changes override draw style when entering sketch edit mode. 2024-05-30 11:17:35 +02:00
wmayer
4185605d5e clang/gcc: Add build option FREECAD_WARN_ERROR to force to make warnings into errors 2024-05-29 13:37:07 +02:00
wmayer
ddfc21afc1 Sketch: Refactor SketchAnalysis
Refactor detectMissingPointOnPointConstraints()
2024-05-28 15:28:53 +02:00
wmayer
7e5b0d570a Sketch: Refactor SketchAnalysis
Refactor detectMissingEqualityConstraints()
2024-05-28 15:10:51 +02:00
wmayer
112c26cf1c Sketch: Refactor SketchAnalysis
Fix linter warnings
2024-05-28 14:43:46 +02:00
wmayer
e0e2e01484 Sketch: Refactor SketchAnalysis
Refactor autoconstraint()
2024-05-28 14:28:07 +02:00
wmayer
1c03bc4eaa Sketch: Refactor SketchAnalysis
Refactor makeMissingEquality()
2024-05-28 14:19:58 +02:00
wmayer
d5c92fee98 Sketch: Refactor SketchAnalysis
Refactor makeMissingVerticalHorizontal
2024-05-28 14:08:44 +02:00
wmayer
5461d0d27f Sketch: Refactor SketchAnalysis
Refactor makeMissingPointOnPoint
2024-05-28 13:40:38 +02:00
wmayer
bcc1a9ada5 Sketch: Refactor SketchAnalysis
Refactor detectMissingPointOnPointConstraints
2024-05-28 13:24:05 +02:00
wmayer
5982ac470e Sketch: Refactor SketchAnalysis
Move helper classes to anonymous namespace
2024-05-28 12:26:23 +02:00
wmayer
e67502025d Sketch: Add test case for validating constraints 2024-05-27 19:15:18 +02:00
wmayer
948d747c6c Sketch: Add test case for deleting constraints with external geometry 2024-05-27 19:15:18 +02:00
wmayer
e96ac0b1db Sketch: Add test case for degenerated geometry 2024-05-27 19:15:18 +02:00
wmayer
cdec6dd1a2 Sketch: Fix TestSketchValidateCoincidents 2024-05-27 19:15:18 +02:00
Syres916
f52a039811 [Sketcher] Add new Fix Missing Coincident test 2024-05-27 19:15:18 +02:00