Commit Graph

26860 Commits

Author SHA1 Message Date
helaslo
71fe41988b [OpenSCAD] Fix colors not working correctly when polygons are extruded 2021-02-25 15:08:19 +01:00
Yorik van Havre
162d5c578f Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-02-25 13:30:09 +01:00
Yorik van Havre
fa85db61f9 Merged crowdin translations 2021-02-25 13:27:48 +01:00
Aapo
505ba2e42f [TD] DrawViewPart.cpp: Fix a crash when user sets the PropertyVector Direction to zero. 2021-02-25 12:40:59 +01:00
wmayer
3ad1d8fccc TD: [skip ci] implement DrawView::recompute to handle all OCC exception types 2021-02-25 12:39:50 +01:00
wmayer
88d49cd982 Gui: [skip ci] improve exception handling:
* handle all exceptions in Application::onLastWindowClosed because this method can be (indirectly)  called from ~BaseView and would otherwise trigger std::terminate()
* handle exceptions in PropertyEditor::closeTransaction() because when recomputing a document while closing it leaves the editor in a bad state
2021-02-25 12:23:13 +01:00
wmayer
2de6a80bb4 TD: [skip ci] explicitly nullify geometryObject in DrawViewPart::partExec to avoid to leave it a dangling pointer in case makeGeometryForShape raises an exception 2021-02-25 11:34:29 +01:00
luz paz
755f4cf1be Crowdin: removing obsolete strings from PartDesign.ts [skip ci]
Uncertain to why but lupdate is not removing obsolete strings from `PartDesign.ts`. This PR manually removes obsoletes strings from it.

ref:
https://crowdin.com/translate/freecad/564/en-de?filter=basic&value=0#6500474
https://crowdin.com/translate/freecad/564/en-en?filter=basic&value=0#6500475
2021-02-25 10:41:58 +01:00
wmayer
f36ba4c56e Crowdin: Gui: move whitespace out of translation string [skip ci] 2021-02-25 10:38:52 +01:00
luz paz
2f9ad32813 Crowdin: fix trailing whitespace [skip ci]
ref: https://crowdin.com/translate/freecad/549/en-en?filter=basic&value=0#6577470
2021-02-25 10:31:59 +01:00
luz paz
a522f4a240 Crowdin: Gui: fix user-facing typo in Document.cpp [skip ci]
ref: https://crowdin.com/translate/freecad/549/en-en?filter=basic&value=0#6584664
2021-02-25 10:31:33 +01:00
Aapo
e39ef22c1b [TD] Hotfix for Dimension label Arbitrary value regression in DrawViewDimension.cpp 2021-02-25 10:28:42 +01:00
wmayer
aa1eb6ea76 Gui: [skip ci] make Save logic of text document more intuitive 2021-02-25 10:17:51 +01:00
wmayer
46e46a1466 FEM: [skip ci] fixes #0004405: Using PartDesign axis / plane as direction for constraints 2021-02-24 23:59:10 +01:00
wmayer
ab04719372 FEM: [skip ci] support Line and Plane objects in Constraint::getDirection() 2021-02-24 23:53:15 +01:00
wmayer
ec2dbecac4 FEM: [skip ci] connect onButtonDirection() slot with clicked() signal 2021-02-24 21:55:51 +01:00
wmayer
78a9a3c2a8 PD: [skip ci] remove invalid static_cast 2021-02-24 20:12:26 +01:00
Yorik van Havre
5c12afb5b5 Merged crowdin translations 2021-02-24 18:07:59 +01:00
wmayer
145eb8ea8c PD: fixes #0004567: Pattern from a feature type UpToFace and Offset > copy whole body 2021-02-24 17:08:20 +01:00
wmayer
4c18734d2e PD: [skip ci] code refactoring
Move adding offset to face from getUpToFace() to addOffsetToFace()
2021-02-24 16:08:03 +01:00
sliptonic
66ef19ce1d Merge pull request #4520 from sliptonic/bug/translations
[PATH]  Bug/translation issues
2021-02-23 19:27:53 -06:00
sliptonic
81a3b9693b Fix whitespace error 2021-02-23 19:14:49 -06:00
sliptonic
53bd6a2d77 fix trailing whitespace 2021-02-23 19:12:25 -06:00
sliptonic
90ec044cb4 fix bad string formatting 2021-02-23 19:06:08 -06:00
sliptonic
3d83e73549 Make string less ambiguous 2021-02-23 19:03:18 -06:00
sliptonic
8ab39462b7 typo in string 2021-02-23 19:01:29 -06:00
sliptonic
5c984dff6a fix string formatting 2021-02-23 18:59:04 -06:00
marioalexis
b8dee20115 Draft: Fix snap to proxy WP and BuildingParts - fixes #0004278 2021-02-23 21:40:06 -03:00
Roy-043
99af124f80 [ARCH] Arch_Roof fix for adjust_list_len function
LGTM code analysis did not like that the adjust_list_len function would mutate default list values. De function now always clones the list.
See: https://forum.freecadweb.org/viewtopic.php?f=23&t=55943
2021-02-23 19:58:39 +01:00
Yorik van Havre
5ab70fd1b6 AddonManager: Fixed missing WB icons 2021-02-23 18:01:04 +01:00
wmayer
30ccf14117 Gui: [skip ci] fixes #0004104: Void property value defaults to 1 2021-02-23 17:32:02 +01:00
luz paz
646103113e Crowdin: Gui: fix DlgSettings3DView.ui tooltip [skip ci]
Remove trailing whitespace  
ref: https://crowdin.com/translate/freecad/549/en-en?filter=basic&value=0#6577482
2021-02-23 17:01:54 +01:00
wmayer
f0740edd20 App: [skip ci] AddressSanitizer: heap-use-after-free
In Document::removeObject() do not access object after it has been possibly deleted
2021-02-23 14:30:00 +01:00
wmayer
45079ca2ac PD: [skip ci] AddressSanitizer: stack-use-after-scope
Axis() returns a tmp. object and thus we cannot use a const reference to get its Location() method
2021-02-23 13:57:51 +01:00
Yorik van Havre
3b477772aa Merge pull request #4438 from paullee0/Draftutils_BugFixes_01
[Draft.draftutils.groups]  get_windows() to support Links
2021-02-23 11:45:41 +01:00
Yorik van Havre
74c280ae40 Merge branch 'master' into Draftutils_BugFixes_01 2021-02-23 11:45:23 +01:00
Yorik van Havre
6d9cd2f058 Merge pull request #4506 from berndhahnebach/bhbdev242
Arch: ifc export, save guid to obj attribute
2021-02-23 11:43:02 +01:00
Yorik van Havre
dcedcf8651 Merge pull request #4508 from donovaly/TD-BalloonHotfix
[0.19] [TD] fix balloon dragging regression
2021-02-23 11:41:58 +01:00
wmayer
48f56169de PD: [skip ci] fix regression caused by fdf7e6acbe120
In the accept() method the view provider of the edited object must be made visible if it's valid as otherwise it can happen that the view is empty.

See https://forum.freecadweb.org/viewtopic.php?f=13&t=55915
2021-02-23 11:20:45 +01:00
Abdullah Tahiri
88acd77442 Sketcher: Work-around for expression engine failure to calculate dependencies
=============================================================================

THIS IS A WORK-AROUND NOT TO DELAY 0.19 RELEASE

depsAreTouched is not returning true in this case:
 https://forum.freecadweb.org/viewtopic.php?f=3&t=55633&p=481061#p478477

It appears related to a drastic change in how dependencies are calculated, see:
 https://forum.freecadweb.org/viewtopic.php?f=3&t=55633&p=481061#p481061

This is NOT the solution, as there is no point in systematically executing the ExpressionEngine
on every dimensional constraint change. Just a quick fix to avoid clearly unwanted behaviour in
absence of time to actually fix the root cause.
2021-02-23 07:40:56 +01:00
Yorik van Havre
a1c6db4afa Doc: Updated offline doc for 0.19 2021-02-22 22:06:29 +01:00
Yorik van Havre
11b84ea87d Tools: Added link fix tool to offlinedoc tools 2021-02-22 22:05:51 +01:00
wmayer
d17b061fea App: [skip ci] check object status before accessing back links 2021-02-22 17:31:25 +01:00
Yorik van Havre
a01703d280 Tools: Updated offline doc scripts 2021-02-22 14:07:33 +01:00
luz paz
a7084b49dd Mesh: Crowdin: fix typo in translation [skip ci]
ref: https://crowdin.com/translate/freecad/561/en-en?filter=basic&value=0#6585564
2021-02-22 08:02:22 +01:00
David Osterberg
a243ce6346 Draft: Fix PathTwistedArray bug 2021-02-22 08:01:34 +01:00
donovaly
d208fc6ef0 [TD] fix balloon dragging
Fixes bug that dragging while pressing CTRL did not work anymore, see https://forum.freecadweb.org/viewtopic.php?f=35&t=55863
2021-02-22 02:17:05 +01:00
Bernd Hahnebach
486febf3dc Arch: ifc export, save guid to obj attribute 2021-02-22 01:50:47 +01:00
wmayer
0d18edc006 Sketcher: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 129530 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member pixelScalingFactor is not initialized in this constructor nor in any functions that it calls.
2021-02-21 16:59:57 +01:00
wmayer
a9bf90cd17 Gui: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 305123 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach the expression this->linked inside this statement: if (role == Qt::TextColorRole && linked)
2021-02-21 16:53:23 +01:00