Commit Graph

3345 Commits

Author SHA1 Message Date
wmayer
4f854bf998 Path: suppress warnings caused by boost 2022-03-24 21:09:28 +01:00
sliptonic
c01a82e3b5 Merge pull request #6651 from sliptonic/bug/5956
[Path] Fix # 5956.
2022-03-24 09:05:39 -05:00
sliptonic
05a8b67dce Merge pull request #6649 from sliptonic/bug/5832
[Path] Fixes #5832
2022-03-23 18:51:20 -05:00
wmayer
97330443a2 All: modernize C++11
* replace deprecated headers
2022-03-23 22:44:18 +01:00
sliptonic
d4623baf0a Expose PocketLastStepOver property
Property can be useful to fine tune the last stepover for some shapes
2022-03-23 15:10:34 -05:00
wmayer
7b591da9f5 Path: modernize C++11
* use nullptr
2022-03-23 19:26:15 +01:00
Uwe
5496accd5f [Path] Fixes #5832
Remove unused and confusing spiral and triangle patterns
2022-03-23 10:35:58 -05:00
Yorik van Havre
1dd773e7b3 Translations: Merged crowdin strings 2022-03-23 10:37:50 +01:00
Yorik van Havre
36f97d0ea4 Translations: updated ts files 2022-03-23 10:24:55 +01:00
sliptonic
553554f936 Merge pull request #6612 from mlampert/bugfix/bag-of-minor-isssues
PATH: Bugfix/bag of minor isssues
2022-03-21 08:34:23 -05:00
sliptonic
0643446bb9 Merge pull request #6592 from Russ4262/fix/depth_params_twin_depths
Path: Fix roughly equal depth entries
2022-03-21 08:33:59 -05:00
Uwe
f23fa31f42 [Path] remove Python.h and Xerces
they are not needed anymore
2022-03-21 13:18:42 +01:00
Markus Lampert
d52fc71663 Blanket black formatting for Path python files 2022-03-20 13:23:48 -07:00
Markus Lampert
efc942a8f6 Fixed read-only state of quantity spin box when expression is 'clear'ed 2022-03-20 13:23:48 -07:00
markus
a23b610f41 Fixed setting a face's normal as the axis for model alignment 2022-03-20 13:23:48 -07:00
Russell Johnson
95cffaf502 Path: Simplify changes per developer conversations
Also update TestPathDepthParams.py to reflect simplification of changes.
Remove some comments.
Employ `sorted()` function per MLampert suggestion
2022-03-20 14:25:17 -05:00
sliptonic
afb3262118 simpler way to filter roughly equal depth values 2022-03-20 14:25:16 -05:00
Russell Johnson
186042b2cf Path: Renumber unit tests per triple-digit schema
per request of Sliptonic
2022-03-20 14:25:15 -05:00
Russell Johnson
ee6d9fb5e0 Path: Add additional roughly-equal depths unit tests 2022-03-20 14:25:15 -05:00
Russell Johnson
3e6d542cd7 Path: Fix roughly equal depth entries
Add code block to remove first of any two consecutive, roughly equal depth values (twin values).

Add two unit tests to support new code block and use cases.
2022-03-20 14:25:14 -05:00
wmayer
21404f319b Path: fix assignment operator of CLine
* Assignment operator in class CLine should have return type CLine&. Otherwise a copy is created at each call.
2022-03-20 19:32:32 +01:00
luz paz
8939e3a2eb Path: remove superfluous 'pass' per LGTM
ref: https://lgtm.com/rules/910088/
2022-03-19 20:06:48 -04:00
sliptonic
06959ededb Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
2022-03-19 15:44:28 -05:00
sliptonic
94c32d9a46 Merge pull request #6590 from sliptonic/feature/warnlegacy
[Path]  Warn user if enabling legacy tools
2022-03-18 10:46:42 -05:00
wmayer
9160f06e1c Base: rename BaseExceptionFreeCADError to PyExc_FC_GeneralError 2022-03-17 14:45:48 +01:00
wmayer
d69defaa3c Py: replace BaseExceptionFreeCADError with more suitable exception types 2022-03-17 13:54:23 +01:00
Russell Johnson
b06389edb2 Path: Change action to warning with option for action. 2022-03-16 11:47:51 -05:00
Russell Johnson
70d5a422f7 Path: Correct comment spelling 2022-03-16 11:40:24 -05:00
Russell Johnson
e4286139db Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
This commit adds a simple `_jobIntegrityCheck()` method to verify that a model and tool exists within the Job object, when interacting with the Task Panel.  If either is missing, the appropriate tab is activated in the task window, and the appropriate edit window is opened for the user, with messages printed in the report view window.

Add check for existence of `SetupSheet` property of empty Job object.

These changes improve upon fixes in PR #5008 and related bug fixes.
2022-03-16 11:40:23 -05:00
sliptonic
de94520d9b [Path] Warn user if enabling legacy tools
Warn user if opening job that contains legacy tools
2022-03-15 11:05:20 -05:00
sliptonic
b640a1d106 Merge pull request #6577 from Russ4262/fix/millface_removalshapes
Path: Fix `self.removalshapes` declaration [Bug]
2022-03-15 09:26:39 -05:00
sliptonic
a70adce220 Merge pull request #6576 from Russ4262/fix/cancel_new_dressup_cleanup
Path: Fix automatic `commitTransaction()` calls, issue #6149 [Bug]
2022-03-15 09:25:43 -05:00
sliptonic
75fee12d7b Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value
Path: Fix inconsistent float type usage, issue #6170 [Bug]
2022-03-14 09:26:24 -05:00
Yorik van Havre
6efe74a554 Merged crowdin translations 2022-03-14 12:21:01 +01:00
Yorik van Havre
583206d47c Updated master ts files 2022-03-14 12:13:40 +01:00
wmayer
0054cbddaa Fix coverity issue:
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
2022-03-14 11:35:04 +01:00
Russell Johnson
ac4c7bb954 Path: Fix self.removalshapes declaration [Bug]
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty.  This moves the declaration up in scope to the method level.
2022-03-12 22:34:03 -06:00
Russell Johnson
20e3657125 Path: Fix automatic commitTransaction() calls, issue #6149 [Bug]
This commit removes the automatic committal of transactions when activated with GUI command.  The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
2022-03-12 22:05:04 -06:00
Russell Johnson
1fc468912c Path: Improve value assignment syntax for radius 2022-03-12 20:00:40 -06:00
sliptonic
b0d19d28d7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
2022-03-12 19:05:39 -06:00
Russell Johnson
a2fb5b66fa Path: Fix radius type inconsistency, issue #6170 [Bug]
Make `self.radius` a float type throughout since other methods and functions treat it as such.
2022-03-12 18:29:21 -06:00
Matti Eiden
af8b6fba07 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Russell Johnson
dd76cabb34 Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug]
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
2022-03-12 12:18:09 -06:00
Uwe
48b2c3da12 [Path] fix a typo 2022-03-12 02:24:44 +01:00
Uwe
bc09020e8b [Path] 2nd part of the Git fix attempt
renaming it back
2022-03-12 02:01:29 +01:00
Uwe
6901b9cf63 [Path] next attempt to fix Git error by renaming
use lowercase letters fro file ending like it is also in the CMake file
2022-03-12 02:00:40 +01:00
Uwe
b6f3295201 [Path] try to silence a git error with a file
Git has issues with this file telling me it is corrupted and its file ending is wrong (in Git lowercase, in the file uppercase).

The attempt is to just to save save it with FC 0.20.
2022-03-12 01:55:37 +01:00
sliptonic
e1ce0c7695 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
2022-03-11 10:06:42 -06:00
sliptonic
0bc9edeb50 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup
Path: Fix enumeration dictionary error [Bug]
2022-03-11 10:04:53 -06:00
sliptonic
182cabcfbb Merge pull request #6530 from sliptonic/bug/6114
[Path] Fix minor non-modal bug.  Fixes 6114
2022-03-11 10:03:53 -06:00