Commit Graph

183 Commits

Author SHA1 Message Date
luzpaz
fdca2d49f7 Arch: lint bad indentation, superfluous formatting (#9310) 2023-04-19 09:40:16 +02:00
luzpaz
e7ced1f7cb Arch: linting multiple imports on one line (#9281) 2023-04-18 16:23:44 +02:00
Roy-043
43e74e67a8 Arch: ArchWindow.py improve invertHinge 2023-01-15 21:31:04 +01:00
Roy-043
172f6c17a7 Arch: improve context menus (rebase) 2023-01-12 22:54:09 +01:00
Roy-043
0e2b2bcf85 Arch: Improve handling of window hosts 2022-10-10 21:19:54 +02:00
Roy-043
7e0550a7c8 Arch: Housekeeping: import translate from correct file 2022-07-21 10:17:03 +02:00
Yorik van Havre
d85cea7e7d Arch: fixed window for good this time 2022-05-16 13:21:52 +02:00
Yorik van Havre
c72d865b6e Arch: Fixed mistake in last commit 2022-05-16 10:42:09 +02:00
Yorik van Havre
b4ee9b62ae Arch: Fixed default component type for new windows 2022-05-16 09:34:14 +02:00
Matthijs Kooijman
199c35ca46 Arch: When inverting hinge position, keep opening direction
Previously, just the hinge position was changed, with the rotation
direction kept unchanged, which would make the door open towards the
other side of the wall. This also inverts the rotation direction, so the
door still opens toward the same side of the wall, which is more
intuitively what you would expect.
2022-03-20 14:46:13 +01:00
Roy-043
c673079e39 Arch: Arch_Window.py: do isdir and isfile check for librarypath 2022-02-11 19:50:11 +01:00
Roy-043
30e2f1aa8f Arch: ArchWindow.py fix alignment of library windows
Windows and doors from parts_library were not aligned with or inserted in a wall.
2022-02-02 17:23:12 +01:00
Paul Lee
c0cc4d2c24 [ArchWindow] add SketchArch attachment support (2nd attempt)
FreeCAD Forum Discussion :
- on Intuitive Automatic Windows/Doors Placement
- https://forum.freecadweb.org/viewtopic.php?f=23&t=50802
2021-12-10 05:26:21 +08:00
Yorik van Havre
644a77a17f Arch: Fixed windows invert hinge option 2021-07-16 12:22:56 +02:00
Łukasz Stelmach
ba63ef51e5 Arch: Parse window opening modes with more than one digit
Signed-off-by: Łukasz Stelmach <stlman@poczta.fm>
2021-04-20 15:02:13 +02:00
Matthijs Kooijman
4346d87c88 Arch: Fix displayed rotation values when adding or editing window components
This ensures the rotation edge and mode GUI elements are cleared when starting
to add or edit a component. Previously, when adding a new component or
editing one without rotation, the GUI elements would retain the value
from the previously edited component, which made it hard to check that
components did not have any rotation, and would make it easy to
accidentally add rotation to components that did not need it (just by
clicking edit and confirming).
2021-03-30 12:40:06 +02:00
Chris Hennes
9d1958475e [ARCH] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Yorik van Havre
ad8d83a71b Arch: Windows: Added 'invert opening' and 'invert hinge' context menu items + task panel buttons 2020-11-19 13:13:38 +01:00
luz paz
ccf30d98d2 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
Yorik van Havre
32c270a2e3 Arch: Added Awming window preset 2020-11-10 19:14:06 +01:00
vocx-fc
fcc9a68f8e Arch: use new name of the icon Part_3D_object
It is defined in the Part Workbench. Before, it was called `Tree_Part`.
2020-10-22 15:11:45 +02:00
mikeprice99
a3749d38b1 fixed door open plan symbol and make makeWindow use name parameter 2020-07-20 14:26:35 +02:00
Yorik van Havre
fa219743d0 Arch: Better support for App::Parts in Arch Windows 2020-06-12 14:22:39 +02:00
vocx-fc
90e1c26f2b Arch: import the os module to find the paths 2020-04-29 11:45:00 +02:00
Yorik van Havre
32e80c2f94 Arch: Fixed louvre width/spacing property 2020-04-14 15:49:36 +02:00
Yorik van Havre
595bfdabf5 Arch: Ability to add windows presets 2020-04-08 18:55:49 +02:00
vocx-fc
1fb5408694 Arch: use the new Draft trackers module
Previously it was `DraftTrackers.py`.
Now we import the trackers from `draftguitools/gui_trackers.py`.
2020-03-31 12:09:25 +02:00
paullee0
7786a28eff [ArchWindow] getSubVolume() Bug - When the Window is a Clone, HoleWire in original is ignored
getSubVolume() -

- When Windown is a Clone, HoleWire in Clone is tested
- However, if HoleWire is not set, no further check if HoleWire in Original is set
- The original code direclty check the Base's Wires BoundBox as HoleWire
2020-01-22 10:19:06 +01:00
paullee0
b00dcc329e [ArchWindow] getSubVolume() Bug - When HoleDepth is set but the Window is a Clone, no opening is created
getSubVolume() -

- When Windown is a Clone, no base is set
- When HoleDepth is set, no further check if there is a Clone to set its base to Clone's base
- The original code return None when no base is set
2020-01-22 10:19:06 +01:00
paullee0
45ef05746e [ArchWindow] Fix getIcon() problem if base is SketchObjectPython
Similar to ArchWall + SketchObjectPython
in Disscusion : https://forum.freecadweb.org/viewtopic.php?t=26815
2020-01-15 10:08:42 +01:00
luz.paz
8af8689d73 Arch: [skip ci] fix header uniformity
This PR fixes header uniformity across all Arch files
2019-12-26 18:24:06 +01:00
Zheng, Lei
ef5acc5023 Arch: relax Part::Feature type checking
For supporting Link inside Arch.
2019-11-17 13:03:42 -03:00
luz.paz
f53ef01d94 Arch: use string operator instead of numeric LGTM fix 2019-10-25 10:23:24 -03:00
Yorik van Havre
ea16fdc3ae Arch: Fixed windows symbol position 2019-08-22 18:52:44 -03:00
Zheng, Lei
88b5b2a845 Draft/Arch related changes
* Add Draft_LinkArray and Draft_PathLinkArray that uses link for both
  data and visualization, which supports linking external objects

* Add link group support for draft snap

* Fix ArchWindows expression ambiguity
2019-08-17 15:32:47 +02:00
Yorik van Havre
94c2617362 Arch: Misc bugfixes 2019-07-05 20:58:44 -03:00
Yorik van Havre
1e66267dac Arch: Added door mode to window command 2019-05-15 21:14:00 -03:00
Yorik van Havre
50013d79ce Arch: Fixed color of windows transparent parts 2019-05-09 12:42:25 -03:00
Yorik van Havre
7ae4a61da5 Arch: Fixed bug in arch windows creation 2019-05-02 15:43:07 -03:00
Yorik van Havre
f5cfaf26cf Arch: fixed error when opening 0.14 files 2019-04-29 12:41:01 -03:00
Yorik van Havre
506cfd9bd2 Arch: Renamed property IfcRole to IfcType 2019-04-09 15:53:01 -03:00
Yorik van Havre
4ea3508967 Arch: Wall, structure, window and panel tools now remember and keep last used values 2019-03-28 17:02:54 -03:00
Yorik van Havre
5cebe1b4c2 Arch: Fixed recursion loop in windows 2019-01-08 16:39:11 -02:00
Yorik van Havre
88f47ee725 Fixed coverity issues
169009 Bad use of null-like value
169005 Bad use of null-like value
169003 Bad use of null-like value
169000 Bad use of null-like value
168998 Bad use of null-like value
168996 Structurally dead code
2018-11-20 12:37:32 -02:00
Yorik van Havre
a3efe18e71 Arch: Fixed bug in windows snapping 2018-11-05 20:00:56 -02:00
Yorik van Havre
a1faed3449 Arch: using basic object names for all arch objects 2018-07-07 14:40:10 -03:00
Yorik van Havre
599921ac7e Arch: Fixed bug in windows 2018-07-02 13:02:57 -03:00
Yorik van Havre
2a116ff4f1 Arch: Handle cloning of BuildingParts 2018-06-29 12:12:54 -03:00
Yorik van Havre
75618d862e Arch: Added Frame and Offset properties to windows 2018-06-21 18:53:52 -03:00
Yorik van Havre
5359ddc4f1 Arch: Fixed bug in windows presets 2018-06-02 14:20:44 -03:00