Commit Graph

22502 Commits

Author SHA1 Message Date
wmayer
fe3f1b51b7 PartDesign: [skip ci] fixes #0004371: Changing Hole profile from ISO to nothing is not possible: "Hole: Cannot get value from invalid enumeration" 2020-09-23 11:11:27 +02:00
donovaly
4a1f81395e [PD] fix 2 hole dialog bugs
- 1. reported here: https://forum.freecadweb.org/viewtopic.php?p=432936#p432851
also unthreaded holes can have a close or standard fit

- 2. reported here: https://forum.freecadweb.org/viewtopic.php?p=432936#p432944
the thread direction is always left. The reason is that this property is an enum but the dialog returns a bool.

- also fix an UI issue with the spin boxes (automatically found and repaired by Qt's designer, thus the many changes in the UI file)
2020-09-23 09:58:53 +02:00
Vanuan
8ea1a38849 HiDPI: Change Sketcher crosshair hot spot xy
See https://forum.freecadweb.org/viewtopic.php?p=432021#p432021
2020-09-23 09:55:41 +02:00
wmayer
2de44b123b FEM: [skip ci] Coverity: Dereference after null check 2020-09-22 20:32:21 +02:00
wmayer
37c4d51501 PartDesign: [skip ci] Coverity: Structurally dead code 2020-09-22 20:22:26 +02:00
wmayer
46ab178102 PartDesign: [skip ci] Coverity: Bad use of null-like value 2020-09-22 20:03:42 +02:00
wmayer
60443034a4 PartDesign: [skip ci] fix method to access main window in shaft wizard 2020-09-22 19:15:59 +02:00
wmayer
ec5bbad626 OpenSCAD: [skip ci] Coverity: Bad use of null-like value 2020-09-22 14:22:10 +02:00
Oscar Rainford
8fe0d19ebe Include Inventor/SbByteBuffer.h in QuarterWidget.cpp to allow compilation with latest Coin3D library. 2020-09-22 14:05:01 +02:00
Yorik van Havre
35d5c5dc4c Arch: allow exporting of objects with no solid or shell to IFC 2020-09-22 13:31:04 +02:00
vocx-fc
621e1d603b Draft: fix loading of arrays 2020-09-22 12:12:00 +02:00
wmayer
700af3aa7f Sketcher: [skip ci] fix computing of hotspot of sketcher icons on Windows 2020-09-21 16:32:25 +02:00
wmayer
ffa1da617f Python: [skip ci] expose Python types in their corresponding modules 2020-09-21 15:04:26 +02:00
Yorik van Havre
376299d55e Added liberapay badge to readme 2020-09-21 15:03:02 +02:00
vocx-fc
6379d802b1 Draft: split svg.get_path function for paths that are BSplines
If it's not a circle nor ellipse nor straight line
convert the curve to BSpline. Move into a subfunction.

Improve a few varible names to be more verbose, like `vertex`
and `edge`.
2020-09-21 14:25:03 +02:00
vocx-fc
f2d10669e5 Draft: svg, move test so the code is less indented
The angle between the curve and plane is tested for being coplanar,
0 or 180 degrees. The negative test is done earlier so that the
return is done earlier, and the rest of the code is not indented.
2020-09-21 14:25:03 +02:00
vocx-fc
8e69b05e9d Draft: split svg.get_path into smaller readable functions
Split the SVG string for circular and elliptical paths.
2020-09-21 14:25:03 +02:00
vocx-fc
2f48f1caba Draft: split svg.get_text into smaller readable functions
Split the code for SVG string that will be displayed
for TechDraw pages; also split the header for other cases.
2020-09-21 14:25:03 +02:00
vocx-fc
0739ffa58e Draft: clean up SVG processing code, add comments
For the try-except blocks we should trap a specific `Exception`,
not just any type. It seems string handling was an issue
with Python 2, so the string needed UTF8 decoding.

When the software no longer supports Python 2, these
blocks can be removed.
2020-09-21 14:25:03 +02:00
vocx-fc
dea7f5d638 Draft: Drawing is still used in get_dxf function 2020-09-21 14:25:03 +02:00
Zheng, Lei
31e8bb27a6 Draft: fix point array without using link 2020-09-21 14:01:42 +02:00
Zheng, Lei
607c14b512 Draft: add support for point link array 2020-09-21 14:01:39 +02:00
wmayer
901ee4e5e1 PD: [skip ci] fix msvc warning 2020-09-21 13:28:56 +02:00
sgrogan
9d62dca003 Update Libpack 2020-09-20 22:26:45 +02:00
tomate44
43604f284b Part: remove uIso and vIso methods from RectangularTrimmedSurface 2020-09-20 18:25:39 +02:00
tomate44
48bf133ea6 convert Geom_TrimmedCurve to subclass 2020-09-20 18:25:39 +02:00
tomate44
053c918e60 Part: remove uIso and vIso methods. Methods from base class GeomSurface will be used instead 2020-09-20 18:25:39 +02:00
vejmarie
f5710fb5cf Fix MacOS build with boost 1.73 and updated Homebrew packages 2020-09-19 19:35:39 +02:00
donovaly
a44f8ffd42 [PD] simplify item handling
according to https://github.com/FreeCAD/FreeCAD/commit/2b676020

"QListWidget::takeItem() returns a pointer to the removed item. So a previous call of QListWidget::item() is superfluous"
2020-09-18 17:30:09 +02:00
Zheng, Lei
e8f5c66435 Gui: fix property editor transaction closing 2020-09-18 13:56:20 +02:00
wmayer
dea2fad512 Web: [skip ci] when dropping local file on StartPage then open it instead of downloading it 2020-09-18 13:14:09 +02:00
donovaly
03c2c76963 [PD] make sections sortable
- allow to sort loft sections by dragging: https://forum.freecadweb.org/viewtopic.php?f=19&t=50222

- fix bug of uninitialized options: https://forum.freecadweb.org/viewtopic.php?f=19&t=50221

- use better code for the context menu of the listWidget (the same we use in other placed of PD)

- add missing tooltip for mirror feature
2020-09-17 23:59:15 +02:00
wmayer
e8b5cfced7 MeshGui: [skip ci] expose highlightSegments() to Python 2020-09-17 18:25:14 +02:00
wmayer
b9e5bce0f0 PD: improve reference highlighting of a pipe
This change allows to highlight the spline, auxiliary spine, profile and sections of a pipe.
This gives the user a much better feedback of what external shapes are already used to build the pipe
2020-09-17 16:19:38 +02:00
wmayer
a3fda6f9ed PD: [skip ci] fixes for pipe task panel
+ Add/Remove are checkable buttons so if user unchecks it then disable highlighting of spine
+ Avoid superfluous char* -> QString conversion
2020-09-17 14:04:36 +02:00
wmayer
2b676020d2 PD: fixes for pipe task panel
+ fix Qt4 build failure
+ fix handling of adding items to spine/auxiliary spine/sections to allow to remove them again
+ QListWidget::takeItem() returns a pointer to the removed item. So a previous call of QListWidget::item() is superfluous
2020-09-17 11:35:41 +02:00
donovaly
5d96f01cf7 [PD] add context menus to sweep Dialog
- elements in the list of edges/spines/sections can now be deleted by pressing DEL and there is a context menu for this action

see https://forum.freecadweb.org/viewtopic.php?f=19&t=50222&p=431021#p431021
2020-09-17 00:45:43 +02:00
wmayer
a028ea94cc PartDesign: [skip ci] hide base feature of pad after it successful recompute 2020-09-16 17:18:49 +02:00
wmayer
ff0f8b0d85 Gui: [skip ci] fix crash in DocumentObjectData::updateChildren() when canceling a pending task 2020-09-16 13:41:03 +02:00
vocx-fc
7a93bcb151 Draft: small fixes to the closest function.
Correct the Pythonic style for the changes made in ea16bb9394.
2020-09-16 13:09:57 +02:00
vocx-fc
c79f890112 Draft: move getDXF to draftfunctions submodule
Update the appropriate interface in `Draft.py`.
2020-09-16 13:09:13 +02:00
Roy-043
f04849446a Arch: Minor improvements to testWallMultiMatAlign unit test. 2020-09-16 13:08:45 +02:00
Roy-043
1e4593aac0 Arch: Arch_Wall fix MultiMaterial alignment bug (unit test)
Added the testWallMultiMatAlign unit test. Have kept the testWall test. Changed the code to 'import FreeCAD as App'.
2020-09-16 13:08:45 +02:00
Roy-043
8ef5e8e333 Arch: Arch_Wall fix MultiMaterial alignment bug. 2020-09-16 13:08:45 +02:00
Roy-043
2cf9f395c1 Draft: Again revised the 5 scale unit tests. No longer relying on the math module.
Also avoided the use of a Boolean 'result' variable.
2020-09-16 13:07:50 +02:00
Roy-043
30fd275089 Draft: Revised the 5 Draft.scale unit tests. No longer using scale_vector_from_center.
The old Draft.scale unit tests uses the scale_vector_from_center function from Draft.scale. This obviously didn't make sense.
2020-09-16 13:07:50 +02:00
Roy-043
687461cf15 Draft: added 5 scale unit tests to test_modifications
The added functions are test_scale_part_feature_arcs, test_scale_part_feature_lines, test_scale_rectangle, test_scale_spline and test_scale_wire.
When comparing vectors and floats a tolerance of 1e-8 is used, but only for the midpoints of the arcs in test_scale_part_feature_arcs is this tolerance required. Scaling a part feature is not possible with the Draft_Scale command, but Draft.scale does support it.
2020-09-16 13:07:50 +02:00
wmayer
53a500ecf5 PartDesign: make sure to remove selection gate when closing task panel 2020-09-16 12:15:19 +02:00
wmayer
32d69af308 Fem: make sure to remove selection gate when closing task panel 2020-09-16 12:15:01 +02:00
wmayer
be22fb0bc5 Part: do not use local event loop in sweep and thickness panel 2020-09-16 12:14:04 +02:00