fix: update silo submodule — save Modified attribute fix #129

forbes · 2026-02-10T00:41:07Z

forbes commented

2026-02-10 00:41:07 +00:00

Updates silo submodule to silo-mod@7cf5867 which fixes:

Silo save failed: 'App.Document' object has no attribute 'Modified'

silo_origin.py was calling doc.Modified = False on an App.Document, but the Modified property only exists on Gui.Document. The save itself succeeded but the modified flag was never cleared, so the document always appeared unsaved.

Fix: use FreeCADGui.getDocument(doc.Name).Modified = False (matching the pattern in silo_commands.py:910-912).

SSE reconnection loop — Issue #13 in silo-mod documents what to check on the server side. The client code is correct (URL fix from PR #85 confirmed), but the server immediately closes the SSE connection after accepting it. Likely needs proxy_buffering off in nginx or equivalent reverse proxy config.

Upstream: kindred/silo-mod#14

Updates silo submodule to silo-mod@7cf5867 which fixes: **`Silo save failed: 'App.Document' object has no attribute 'Modified'`** `silo_origin.py` was calling `doc.Modified = False` on an `App.Document`, but the `Modified` property only exists on `Gui.Document`. The save itself succeeded but the modified flag was never cleared, so the document always appeared unsaved. Fix: use `FreeCADGui.getDocument(doc.Name).Modified = False` (matching the pattern in `silo_commands.py:910-912`). **SSE reconnection loop** — Issue #13 in silo-mod documents what to check on the server side. The client code is correct (URL fix from PR #85 confirmed), but the server immediately closes the SSE connection after accepting it. Likely needs `proxy_buffering off` in nginx or equivalent reverse proxy config. Upstream: kindred/silo-mod#14

forbes added 1 commit 2026-02-10 00:41:08 +00:00

fix: update silo submodule — save Modified attribute fix (#13 )

Build and Test / build (pull_request) Successful in 1h15m2s

Details

0745309559

Pins silo to silo-mod@7cf5867 which fixes:
- 'App.Document' object has no attribute 'Modified' error on every save
  (uses Gui.Document.Modified instead of App.Document.Modified)

forbes merged commit 8e387a35b1 into main

2026-02-10 12:57:04 +00:00

forbes referenced this issue from a commit

2026-02-10 12:57:06 +00:00

Merge pull request 'fix: update silo submodule — save Modified attribute fix' (#129) from fix/silo-save-modified into main

forbes referenced this issue from a commit

2026-02-14 16:31:28 +00:00

Merge pull request #129 from ianrrees/20160327-use-SystemExitException-code

forbes referenced this issue from a commit

2026-02-14 16:34:31 +00:00

Merge pull request #129 from ianrrees/20160327-use-SystemExitException-code

Sign in to join this conversation.