fix: start page always closes on document open #207

forbes · 2026-02-14T18:42:42Z

forbes commented

2026-02-14 18:42:42 +00:00

Fixes #192

Problem

The start page tab persists after opening a document, blocking workflow and causing hangs on close.

Two root causes:

postStart() checks GetBool("closeStart", false) — default is false, so the start page never auto-closes after a document action.
When another MDI tab activates, onMdiSubWindowActivated() disables all QListView updates on the start page. If the widget is then destroyed with updates disabled, Qt can hang during cleanup.

Fix

Remove the closeStart preference gate — always close the start page when a document is opened or created
Call setListViewUpdatesEnabled(true) before closing to prevent the hang
Add hideEvent override as a safety net to re-enable updates whenever the start page is hidden

Fixes #192 ## Problem The start page tab persists after opening a document, blocking workflow and causing hangs on close. **Two root causes:** 1. `postStart()` checks `GetBool("closeStart", false)` — default is `false`, so the start page never auto-closes after a document action. 2. When another MDI tab activates, `onMdiSubWindowActivated()` disables all QListView updates on the start page. If the widget is then destroyed with updates disabled, Qt can hang during cleanup. ## Fix - Remove the `closeStart` preference gate — always close the start page when a document is opened or created - Call `setListViewUpdatesEnabled(true)` before closing to prevent the hang - Add `hideEvent` override as a safety net to re-enable updates whenever the start page is hidden

forbes added 1 commit 2026-02-14 18:42:43 +00:00

fix: start page always closes on document open (#192 )

Build and Test / build (pull_request) Has been cancelled

Details

444aaac1ee

Remove the closeStart preference check so the start page MDI tab
always closes when a document is opened or created. Re-enable
QListView updates before closing to prevent Qt hang during widget
destruction.

Add hideEvent override as a safety net to re-enable disabled
QListView updates whenever the start page is hidden.

forbes merged commit 0b3d4b1274 into main

2026-02-14 18:44:38 +00:00

forbes referenced this issue from a commit

2026-02-14 18:44:39 +00:00

Merge pull request 'fix: start page always closes on document open' (#207) from fix/start-page-blocks-document into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kindred/create#207