docs: classify C++ patches by purpose and upstream-ability (#254) #263

forbes · 2026-02-17T18:22:50Z

forbes commented

2026-02-17 18:22:50 +00:00

Audit and classify all 36 cherry-picked C++ commits in UPSTREAM.md into three categories:

Category	Count	Long-term plan
1 — Extension points	16	KEEP — core differentiator (Origin system, EditingContext, BreadcrumbToolBar, appendToolbar visibility)
2 — Branding/theming	16	KEEP — minimize surface area (splash, about, QSS, icon overrides, theme selector)
3 — Bug fixes	4	UPSTREAM — contribute to FreeCAD and eliminate (#26 Wayland scaling, #27 DlgSettings build fix, #31 window flickering, #33 ToolBarItem type)

Also verified

Category 3 upstream status:

Window flickering (#31) — NOT fixed upstream, good PR candidate (replace setStyleSheet with setPalette on statusBar)
Wayland/menu icon (#26/#27) — partially addressed upstream, menu icon pref not contributed
ToolBarItem/reportException (#33) — Kindred-internal only, not an upstream issue

Assembly fixes (Phase 3):

All 4 patches still needed: joint flip guard, SIGSEGV restore guard, datum plane/point handling
App::Line handling fixed upstream via FreeCAD PR#20026

Closes #254.

Audit and classify all 36 cherry-picked C++ commits in UPSTREAM.md into three categories: | Category | Count | Long-term plan | |----------|-------|----------------| | 1 — Extension points | 16 | KEEP — core differentiator (Origin system, EditingContext, BreadcrumbToolBar, appendToolbar visibility) | | 2 — Branding/theming | 16 | KEEP — minimize surface area (splash, about, QSS, icon overrides, theme selector) | | 3 — Bug fixes | 4 | UPSTREAM — contribute to FreeCAD and eliminate (#26 Wayland scaling, #27 DlgSettings build fix, #31 window flickering, #33 ToolBarItem type) | ### Also verified **Category 3 upstream status:** - Window flickering (#31) — NOT fixed upstream, good PR candidate (replace `setStyleSheet` with `setPalette` on statusBar) - Wayland/menu icon (#26/#27) — partially addressed upstream, menu icon pref not contributed - ToolBarItem/reportException (#33) — Kindred-internal only, not an upstream issue **Assembly fixes (Phase 3):** - All 4 patches still needed: joint flip guard, SIGSEGV restore guard, datum plane/point handling - `App::Line` handling fixed upstream via [FreeCAD PR#20026](https://github.com/FreeCAD/FreeCAD/pull/20026) Closes #254.

forbes added 1 commit 2026-02-17 18:22:51 +00:00

docs: classify C++ patches by purpose and upstream-ability (#254 )

Build and Test / build (pull_request) Failing after 2m2s

Details

076a1e90b0

Add Category column to Phase 2 cherry-pick table:
- 16 × Category 1 (Extension points) — KEEP
- 16 × Category 2 (Branding/theming) — KEEP, minimize
-  4 × Category 3 (Bug fixes) — UPSTREAM candidates

Add upstream verification for Category 3 patches:
- #26/#27 (Wayland scaling, menu icon size): partially upstream, menu pref not contributed
- #31 (window flickering): not upstream, good PR candidate
- #33 (ToolBarItem/reportException): Kindred-internal only

Update Assembly fixes with verified upstream status:
- All 4 patches still needed (joint flip, SIGSEGV, datum plane/point handling)
- App::Line handling fixed upstream via FreeCAD PR#20026

Closes #254.

forbes merged commit 68380357fb into main

2026-02-17 18:26:07 +00:00

forbes deleted branch docs/classify-cpp-patches

2026-02-17 18:26:07 +00:00

forbes referenced this issue from a commit

2026-02-17 18:26:08 +00:00

Merge pull request 'docs: classify C++ patches by purpose and upstream-ability (#254)' (#263) from docs/classify-cpp-patches into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kindred/create#263