fix(theme): eliminate QSS/CFG duplication (#51) #70

forbes · 2026-02-08T23:41:46Z

forbes commented

2026-02-08 23:41:46 +00:00

Summary

Resolves #51. Eliminates the manual QSS stylesheet duplication by making src/Gui/Stylesheets/KindredCreate.qss the single source of truth and generating the PreferencePacks copy at build time.

Problem

Three copies of KindredCreate.qss existed and had diverged. Additionally, the resources/preferences/KindredCreate/KindredCreate.cfg contained all the recent preference defaults (PRs #37, #38, #40, #47) but was never installed by CMake — those settings were applied to the wrong file and never reached users.

Changes

Build system:

src/Gui/PreferencePacks/CMakeLists.txt — Added configure_file() to copy QSS from Stylesheets to PreferencePacks build directory at build time. Install rule now uses the build directory copy.

Preference defaults (cfg sync):

src/Gui/PreferencePacks/KindredCreate/KindredCreate.cfg — Merged all missing preference defaults from the deleted resources copy: Document (undo=50, autosave=5min, backup=3, license=Other), TreeView (PreSelection, SyncView, SyncSelection), NotificationArea, OutputWindow recording defaults, General (AutoloadModule=ZToolsWorkbench)

Deleted files:

resources/preferences/KindredCreate/KindredCreate.cfg — unused, not installed by CMake
resources/preferences/KindredCreate/KindredCreate.qss — unused, not installed by CMake
resources/preferences/package.xml — orphaned metadata for removed directory
src/Gui/PreferencePacks/KindredCreate/KindredCreate.qss — now generated at build time

Documentation:

Updated KNOWN_ISSUES.md, COMPONENTS.md, INTEGRATION_PLAN.md, ARCHITECTURE.md, README.md to reflect single QSS source

## Summary Resolves #51. Eliminates the manual QSS stylesheet duplication by making `src/Gui/Stylesheets/KindredCreate.qss` the single source of truth and generating the PreferencePacks copy at build time. ### Problem Three copies of `KindredCreate.qss` existed and had diverged. Additionally, the `resources/preferences/KindredCreate/KindredCreate.cfg` contained all the recent preference defaults (PRs #37, #38, #40, #47) but **was never installed by CMake** — those settings were applied to the wrong file and never reached users. ### Changes **Build system:** - `src/Gui/PreferencePacks/CMakeLists.txt` — Added `configure_file()` to copy QSS from Stylesheets to PreferencePacks build directory at build time. Install rule now uses the build directory copy. **Preference defaults (cfg sync):** - `src/Gui/PreferencePacks/KindredCreate/KindredCreate.cfg` — Merged all missing preference defaults from the deleted resources copy: Document (undo=50, autosave=5min, backup=3, license=Other), TreeView (PreSelection, SyncView, SyncSelection), NotificationArea, OutputWindow recording defaults, General (AutoloadModule=ZToolsWorkbench) **Deleted files:** - `resources/preferences/KindredCreate/KindredCreate.cfg` — unused, not installed by CMake - `resources/preferences/KindredCreate/KindredCreate.qss` — unused, not installed by CMake - `resources/preferences/package.xml` — orphaned metadata for removed directory - `src/Gui/PreferencePacks/KindredCreate/KindredCreate.qss` — now generated at build time **Documentation:** - Updated KNOWN_ISSUES.md, COMPONENTS.md, INTEGRATION_PLAN.md, ARCHITECTURE.md, README.md to reflect single QSS source

forbes added 1 commit 2026-02-08 23:41:46 +00:00

fix(theme): eliminate QSS/CFG duplication (#51 )

Build and Test / build (pull_request) Has been cancelled

Details

6773ca0dfd

- Make src/Gui/Stylesheets/KindredCreate.qss the single source of truth
- Generate PreferencePacks QSS copy at build time via configure_file()
- Merge missing preference defaults into PreferencePacks cfg:
  Document (undo, autosave, backup, license), TreeView (PreSelection,
  SyncView, SyncSelection), NotificationArea, OutputWindow recording,
  General (AutoloadModule=ZToolsWorkbench)
- Delete unused resources/preferences/KindredCreate/ directory
- Delete src/Gui/PreferencePacks/KindredCreate/KindredCreate.qss from source
- Update documentation to reflect single QSS location

forbes referenced this pull request

2026-02-09 01:20:39 +00:00

fix(theme): QGroupBox indicator, hyperlink color, and report defaults (#41, #43, #44) #82

forbes added 1 commit 2026-02-09 01:28:01 +00:00

merge: resolve conflicts with main (docs)

Build and Test / build (pull_request) Has been cancelled

Details

b3a6c9d925

forbes merged commit 1d2a11572d into main

2026-02-09 01:28:09 +00:00

forbes deleted branch fix/qss-duplication

2026-02-09 01:28:10 +00:00