fix: update ztools submodule — robust PartDesign menu insertion (#57) #72

forbes · 2026-02-09T00:08:01Z

forbes commented

2026-02-09 00:08:01 +00:00

Replaces the fragile chained insert operations in _ZToolsPartDesignManipulator.modifyMenuBar() with independent append operations.

Problem: The old code anchored the first insertion on PartDesign_Boolean and chained each subsequent command off the previous insertion. If PartDesign_Boolean were ever renamed upstream, all four insertions would silently fail (cascade failure).

Fix: Use append with PartDesign_Body as the parent-locator. Each operation is independent — a failure in one does not affect the others. PartDesign_Body is the most fundamental command in the Part Design menu, far less likely to be renamed.

Commands now appear at the bottom of the Part Design menu instead of before PartDesign_Boolean.

Closes #57

Replaces the fragile chained `insert` operations in `_ZToolsPartDesignManipulator.modifyMenuBar()` with independent `append` operations. **Problem:** The old code anchored the first insertion on `PartDesign_Boolean` and chained each subsequent command off the previous insertion. If `PartDesign_Boolean` were ever renamed upstream, all four insertions would silently fail (cascade failure). **Fix:** Use `append` with `PartDesign_Body` as the parent-locator. Each operation is independent — a failure in one does not affect the others. `PartDesign_Body` is the most fundamental command in the Part Design menu, far less likely to be renamed. Commands now appear at the bottom of the Part Design menu instead of before `PartDesign_Boolean`. Closes #57

forbes added 1 commit 2026-02-09 00:08:01 +00:00

fix: update ztools submodule — robust PartDesign menu insertion (#57 )

Build and Test / build (pull_request) Has been cancelled

Details

e261fc4aa4

forbes added 1 commit 2026-02-09 01:29:18 +00:00

Merge remote-tracking branch 'origin/main' into fix/menu-insertion-fragility

Build and Test / build (pull_request) Has been cancelled

Details

4cf2541511

forbes force-pushed fix/menu-insertion-fragility from 4cf2541511 to 1f027747c9

2026-02-09 01:31:01 +00:00