kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix: update ztools submodule — parametric tangent-to-cylinder datums (#58) #81

Merged
forbes merged 2 commits from fix/tangent-cylinder-attachment into main 2026-02-09 01:39:25 +00:00
Conversation 0 Commits 2 Files Changed 1 +1 -1
forbes commented 2026-02-09 00:53:43 +00:00
Owner
Copy Link

Updates ztools submodule to use FreeCAD's TangentPlane MapMode for tangent-to-cylinder datums instead of manual placement.

Problem: plane_tangent_to_cylinder() always fell back to MapMode=Deactivated because TangentPlane requires (face, vertex) references but only the cylindrical face was collected. Datums didn't auto-update when cylinder geometry changed.

Fix: Derive a vertex from the cylinder face's edges via _find_cylinder_vertex(), compute its angular position with _vertex_angle_on_cylinder(), and use AttachmentOffset.Rotation to encode the desired angle offset. The edit panel (on_param_changed) now updates AttachmentOffset when attachment is active, falling back to manual placement for non-Body datums.

Closes #58

Updates ztools submodule to use FreeCAD's `TangentPlane` MapMode for tangent-to-cylinder datums instead of manual placement. **Problem:** `plane_tangent_to_cylinder()` always fell back to `MapMode=Deactivated` because TangentPlane requires (face, vertex) references but only the cylindrical face was collected. Datums didn't auto-update when cylinder geometry changed. **Fix:** Derive a vertex from the cylinder face's edges via `_find_cylinder_vertex()`, compute its angular position with `_vertex_angle_on_cylinder()`, and use `AttachmentOffset.Rotation` to encode the desired angle offset. The edit panel (`on_param_changed`) now updates `AttachmentOffset` when attachment is active, falling back to manual placement for non-Body datums. Closes #58
forbes added 1 commit 2026-02-09 00:53:44 +00:00
fix: update ztools submodule — parametric tangent-to-cylinder datums (#58)
Some checks failed
Build and Test / build (pull_request) Has been cancelled
Details
6b4e099a64
forbes force-pushed fix/tangent-cylinder-attachment from 6b4e099a64 to 1c136add51 2026-02-09 01:36:31 +00:00 Compare
forbes force-pushed fix/tangent-cylinder-attachment from 1c136add51 to f0f4c068d2 2026-02-09 01:38:45 +00:00 Compare
forbes added 1 commit 2026-02-09 01:39:16 +00:00
Merge branch 'main' into fix/tangent-cylinder-attachment
Some checks failed
Build and Test / build (pull_request) Has been cancelled
Details
ad34cffcd6
forbes merged commit 766f9b491c into main 2026-02-09 01:39:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
UX
branding
bug
ci/cd
CI/CD workflows and deployment
 defaults
documentation
Developer documentation
 enhancement
high-priority
low-priority
theme
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/create#81
Delete Branch "fix/tangent-cylinder-attachment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?