kindred/gears
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fixed issue loading old document without traverse_module existing in gear XML

Browse Source
This commit is contained in:
Scott Mudge
2023-03-28 05:15:00 -04:00
committed by lorenz
parent 2def33833a
commit 0eb9913420
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
freecad/gears/features.py
View File

@@ -189,7 +189,7 @@ class InvoluteGear(BaseGear):
"computed", "outside diameter", 1)
obj.addProperty("App::PropertyLength", "df",
"computed", "root diameter", 1)
obj.addProperty("App::PropertyLength", "traverse_module", "computed", "traverse module of the generated gear", 1)
self.add_traverse_module_property(obj)
obj.addProperty("App::PropertyLength", "dw", "computed", "The pitch diameter.", 1)
obj.addProperty("App::PropertyAngle", "angular_backlash", "computed",
"The angle by which this gear can turn without moving the mating gear.")
@@ -211,8 +211,14 @@ class InvoluteGear(BaseGear):
obj.addProperty("App::PropertyBool", "simple", "accuracy", "simple")
obj.addProperty("App::PropertyInteger", "numpoints",
"accuracy", "number of points for spline")
def add_traverse_module_property(self, obj):
obj.addProperty("App::PropertyLength", "traverse_module", "computed", "traverse module of the generated gear", 1)
def compute_traverse_properties(self, obj):
# traverse_module added recently, if old freecad doc is loaded without it, it will not exist when generate_gear_shape() is called
if not hasattr(obj, 'traverse_module'):
self.add_traverse_module_property(obj)
if obj.properties_from_tool:
obj.traverse_module = obj.module / np.cos(obj.gear.beta)
else: