kindred/gears
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix GearConnector AttributeError: replace dw with pitch_diameter

Browse Source 
The obsolete 'dw' property was removed from gear objects but GearConnector
  was still accessing it, causing AttributeError when connecting gears.
  Replaced all instances with 'pitch_diameter.Value' property.
This commit is contained in:
Chris Bruner
2025-11-03 16:41:03 -05:00
committed by lorenz
parent 89acd917ae
commit 33cbe81938
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
freecad/gears/connector.py
View File

@@ -115,8 +115,8 @@ class GearConnector(object):
angle_master = fp.master_gear.Placement.Rotation.Angle * sum(
fp.master_gear.Placement.Rotation.Axis
)
dw_master = fp.master_gear.dw
dw_slave = fp.slave_gear.dw
dw_master = fp.master_gear.pitch_diameter.Value
dw_slave = fp.slave_gear.pitch_diameter.Value
dist = (dw_master + dw_slave) / 2
if fp.master_gear.shift != 0 or fp.slave_gear.shift != 0:
dist, alpha_w = compute_shifted_gears(
@@ -148,8 +148,8 @@ class GearConnector(object):
angle_master = fp.master_gear.Placement.Rotation.Angle * sum(
fp.master_gear.Placement.Rotation.Axis
)
dw_master = fp.master_gear.dw
dw_slave = fp.slave_gear.dw
dw_master = fp.master_gear.pitch_diameter.Value
dw_slave = fp.slave_gear.pitch_diameter.Value
dist = (dw_master - dw_slave) / 2
if fp.master_gear.shift != 0 or fp.slave_gear.shift != 0:
dist, alpha_w = compute_shifted_gears(
@@ -185,7 +185,7 @@ class GearConnector(object):
angle_master = fp.master_gear.Placement.Rotation.Angle * sum(
fp.master_gear.Placement.Rotation.Axis
)
dw_master = fp.master_gear.dw.Value
dw_master = fp.master_gear.pitch_diameter.Value
dw_slave = 0
dist = -(dw_master + dw_slave) / 2
mat0 = app.Matrix() # unity matrix
@@ -205,8 +205,8 @@ class GearConnector(object):
angle_master = fp.master_gear.Placement.Rotation.Angle * sum(
fp.master_gear.Placement.Rotation.Axis
)
dw_master = fp.master_gear.dw
dw_slave = fp.slave_gear.dw
dw_master = fp.master_gear.pitch_diameter.Value
dw_slave = fp.slave_gear.pitch_diameter.Value
dist = (dw_master + dw_slave) / 2
mat0 = app.Matrix() # unity matrix
trans = app.Vector(dist, 0, 0)