kindred/silo
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(jobs): wire auto-triggering on bom_changed events #112

Merged
forbes merged 1 commits from feat-job-auto-trigger into main 2026-02-15 15:44:43 +00:00
Conversation 0 Commits 1 Files Changed 5 +269 -3
forbes commented 2026-02-15 15:43:17 +00:00
Owner
Copy Link

Issue #107

Wire triggerJobs() into individual BOM mutation handlers and add a module guard.

Changes

  • Module guard: triggerJobs() now returns early if the jobs module is disabled, preventing unnecessary DB queries
  • BOM triggers: HandleAddBOMEntry, HandleUpdateBOMEntry, and HandleDeleteBOMEntry now fire bom_changed triggers (matching existing HandleMergeBOM pattern)
  • 4 integration tests: revision trigger, BOM trigger, filter mismatch, module disabled
  • AppShell scroll fix: overflow: hidden → overflow: auto so the Settings page scrolls
  • Deploy script: clean old frontend assets before extracting new ones

Closes #107

## Issue #107 Wire `triggerJobs()` into individual BOM mutation handlers and add a module guard. ### Changes - **Module guard**: `triggerJobs()` now returns early if the jobs module is disabled, preventing unnecessary DB queries - **BOM triggers**: `HandleAddBOMEntry`, `HandleUpdateBOMEntry`, and `HandleDeleteBOMEntry` now fire `bom_changed` triggers (matching existing `HandleMergeBOM` pattern) - **4 integration tests**: revision trigger, BOM trigger, filter mismatch, module disabled - **AppShell scroll fix**: `overflow: hidden` → `overflow: auto` so the Settings page scrolls - **Deploy script**: clean old frontend assets before extracting new ones Closes #107
forbes added 1 commit 2026-02-15 15:43:18 +00:00
feat(jobs): wire auto-triggering on bom_changed events, add module guard 747bae8354 
- Add IsEnabled("jobs") guard to triggerJobs() to skip when module disabled
- Fire bom_changed trigger from HandleAddBOMEntry, HandleUpdateBOMEntry,
  HandleDeleteBOMEntry (matching existing HandleMergeBOM pattern)
- Add 4 integration tests: revision trigger, BOM trigger, filter mismatch,
  module disabled
- Fix AppShell overflow: hidden -> auto so Settings page scrolls
- Clean old frontend assets in deploy script before extracting

Closes #107
forbes merged commit 666cc2b23b into main 2026-02-15 15:44:43 +00:00
forbes deleted branch feat-job-auto-trigger 2026-02-15 15:44:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/silo#112
Delete Branch "feat-job-auto-trigger"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?