fix: style guide batch 2 — buttons, tables, transitions, inputs, validation #84

forbes · 2026-02-13T19:26:43Z

forbes commented

2026-02-13 19:26:43 +00:00

Style Guide Sweep (Batch 2)

Resolves #68, #69, #72, #73, #80. #74 was already compliant.

Changes

#68 — Standardize button styles (12 files)

All button style objects: borderRadius 0.375rem, fontSize 0.75rem, fontWeight 500

#69 — Table header color + selected row (6 files)

thStyle color: subtext1/subtext0 → overlay1
Selected row bg: surface1 → rgba(mauve, 0.08)

#73 — Standardize transitions (6 files)

All inline transitions → all 0.15s ease

#72 — Input focus states (8 files)

New silo-base.css with .silo-input hover/focus pseudo-classes
Applied className to inputs in CreateItemPane, EditItemPane, ProjectsPage, SchemasPage, SettingsPage, LoginPage

#74 — Primary button multiplicity

Verified already compliant (conditional rendering ensures single primary per context)

#80 — Part number validation (3 files)

Implemented Generator.Validate() with per-segment-type checks
Belt-and-suspenders call in HandleCreateItem after Generate()
9 new tests (all 19 pass)

Testing

go test ./internal/partnum/... — 19/19 pass
No remaining fontWeight 600 in button styles
No remaining subtext1 in table headers
No non-standard transition durations

## Style Guide Sweep (Batch 2) Resolves #68, #69, #72, #73, #80. #74 was already compliant. ### Changes **#68 — Standardize button styles (12 files)** - All button style objects: borderRadius 0.375rem, fontSize 0.75rem, fontWeight 500 **#69 — Table header color + selected row (6 files)** - thStyle color: subtext1/subtext0 → overlay1 - Selected row bg: surface1 → rgba(mauve, 0.08) **#73 — Standardize transitions (6 files)** - All inline transitions → `all 0.15s ease` **#72 — Input focus states (8 files)** - New silo-base.css with `.silo-input` hover/focus pseudo-classes - Applied className to inputs in CreateItemPane, EditItemPane, ProjectsPage, SchemasPage, SettingsPage, LoginPage **#74 — Primary button multiplicity** - Verified already compliant (conditional rendering ensures single primary per context) **#80 — Part number validation (3 files)** - Implemented `Generator.Validate()` with per-segment-type checks - Belt-and-suspenders call in HandleCreateItem after Generate() - 9 new tests (all 19 pass) ### Testing - `go test ./internal/partnum/...` — 19/19 pass - No remaining fontWeight 600 in button styles - No remaining subtext1 in table headers - No non-standard transition durations

forbes added 5 commits 2026-02-13 19:26:43 +00:00

fix(web): standardize button borderRadius, fontSize, fontWeight (#68 ) 2585305590

All button style objects now use:
- borderRadius: 0.375rem
- fontSize: 0.75rem
- fontWeight: 500

Files: CreateItemPane, EditItemPane, DeleteItemPane, BOMTab,
CategoryPicker, ProjectsPage, SchemasPage, LoginPage,
ItemsToolbar, SettingsPage, ImportItemsPane, ItemTable

Closes #68

fix(web): table header color overlay1 + selected row mauve tint (#69 ) 289d488469

- All thStyle objects: color subtext1/subtext0 → overlay1
- Selected row bg: surface1 → rgba(mauve, 0.08)

Files: ItemTable, BOMTab, ProjectsPage, SchemasPage,
SettingsPage, AuditTable

Closes #69

fix(web): standardize transition durations to 0.15s ease (#73 ) a9614e704e

All inline transition properties now use 'all 0.15s ease'.

Files: AppShell, CategoryPicker, AuditDetailPanel,
AuditSummaryBar, AuditTable, FileDropZone

Closes #73

feat(web): add input focus states via silo-base.css (#72 ) f4a1c8004b

Create silo-base.css with .silo-input hover/focus pseudo-classes:
- hover: border-color overlay0
- focus: border-color mauve + 0.2rem mauve box-shadow

Applied className='silo-input' to form inputs in:
CreateItemPane, EditItemPane, ProjectsPage, SchemasPage,
SettingsPage, LoginPage

Closes #72

feat(partnum): implement part number validation (#80 ) d5f1b4e587

Implement Generator.Validate() to check part numbers against schemas:
- Split by separator, verify segment count
- Constant: must equal expected value
- Enum: must be in allowed values map
- String: length, case, pattern constraints
- Serial: length + numeric-only check
- Date: length matches expected format output

Add belt-and-suspenders call in HandleCreateItem after Generate().
Add 9 validation tests (all pass alongside 10 existing tests).

Closes #80

forbes merged commit 8316ac085c into main

2026-02-13 19:27:57 +00:00

forbes deleted branch fix-style-guide-batch-2

2026-02-13 19:27:58 +00:00

forbes referenced this issue from a commit

2026-02-13 19:28:00 +00:00

Merge pull request 'fix: style guide batch 2 — buttons, tables, transitions, inputs, validation' (#84) from fix-style-guide-batch-2 into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kindred/silo#84