PVS: V547 Expression is always true/false

This commit is contained in:
wmayer
2019-03-03 18:38:03 +01:00
parent 8d8255981f
commit 32c527c5a6
2 changed files with 5 additions and 13 deletions

View File

@@ -285,13 +285,11 @@ void CmdPrimtiveCompSubtractive::activated(int iMsg)
}
}
if (pcActiveBody) {
copyVisual(FeatName.c_str(), "ShapeColor", pcActiveBody->getNameInDocument());
copyVisual(FeatName.c_str(), "LineColor", pcActiveBody->getNameInDocument());
copyVisual(FeatName.c_str(), "PointColor", pcActiveBody->getNameInDocument());
copyVisual(FeatName.c_str(), "Transparency", pcActiveBody->getNameInDocument());
copyVisual(FeatName.c_str(), "DisplayMode", pcActiveBody->getNameInDocument());
}
copyVisual(FeatName.c_str(), "ShapeColor", pcActiveBody->getNameInDocument());
copyVisual(FeatName.c_str(), "LineColor", pcActiveBody->getNameInDocument());
copyVisual(FeatName.c_str(), "PointColor", pcActiveBody->getNameInDocument());
copyVisual(FeatName.c_str(), "Transparency", pcActiveBody->getNameInDocument());
copyVisual(FeatName.c_str(), "DisplayMode", pcActiveBody->getNameInDocument());
Gui::Command::doCommand(Gui, "Gui.activeDocument().setEdit(\'%s\')", FeatName.c_str());
}

View File

@@ -3844,12 +3844,6 @@ TopoShape Sketch::toShape(void) const
builder.Add(comp, *wt);
result.setShape(comp);
}
// FIXME: if free edges are left over its probably better to
// create a compound with the closed structures and let the
// features decide what to do with it...
if (edge_list.size() > 0)
Base::Console().Warning("Left over edges in Sketch. Only closed structures will be propagated at the moment!\n");
#endif
return result;