kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[App] attempt to fix compiler warnings in Property.h

Browse Source 
- "conversion from 'size_t' to 'int', possible loss of data" in for loops by modernizing the for loops
- fix warning about uninitialized variable
This commit is contained in:
Uwe
2023-02-27 00:30:56 +01:00
parent a000dcf60a
commit 4f324add9f
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/App/Property.h
View File

@@ -550,24 +550,31 @@ public:
protected:
void setPyValues(const std::vector<PyObject*> &vals, const std::vector<int> &indices) override
void setPyValues(const std::vector<PyObject*>& vals, const std::vector<int>& indices) override
{
int i = 0;
if (indices.empty()) {
ListT values;
ListT values {};
values.resize(vals.size());
for (std::size_t i=0,count=vals.size();i<count;++i)
values[i] = getPyValue(vals[i]);
i = 0;
for (auto valsContent : vals) {
values[i] = getPyValue(valsContent);
i++;
}
setValues(std::move(values));
return;
}
assert(vals.size()==indices.size());
assert(vals.size() == indices.size());
atomic_change guard(*this);
for (int i=0,count=indices.size();i<count;++i)
set1Value(indices[i],getPyValue(vals[i]));
i = 0;
for (auto index : indices) {
set1Value(index, getPyValue(vals[i]));
i++;
}
guard.tryInvoke();
}
virtual T getPyValue(PyObject *item) const = 0;
virtual T getPyValue(PyObject* item) const = 0;
protected:
ListT _lValueList;